public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
* [PATCH v3 0/1] image-postproc: ignore systemd preset failures
@ 2026-02-19  4:44 'Badrikesh Prusty' via isar-users
  2026-02-19  4:44 ` [PATCH v3 1/1] " 'Badrikesh Prusty' via isar-users
  2026-02-19 17:52 ` [PATCH v3 0/1] " 'Jan Kiszka' via isar-users
  0 siblings, 2 replies; 7+ messages in thread
From: 'Badrikesh Prusty' via isar-users @ 2026-02-19  4:44 UTC (permalink / raw)
  To: isar-users; +Cc: gokhan.cetin, alexander.heinisch, Badrikesh Prusty

changes in v3:
* Do not disable pre-population of enabled systemd services during build,
  as this is the correct default behavior. Downstream layers can disable
  it if needed.
* Ignore failures from systemd preset only.

changes in v2:
* Disable populate-systemd-preset at build time by default due to service
  failures observed on some systems.

Badrikesh Prusty (1):
  image-postproc: ignore systemd preset failures

 meta/classes-recipe/rootfs.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.39.5

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20260219044406.441933-1-badrikesh.prusty%40siemens.com.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH v3 1/1] image-postproc: ignore systemd preset failures
  2026-02-19  4:44 [PATCH v3 0/1] image-postproc: ignore systemd preset failures 'Badrikesh Prusty' via isar-users
@ 2026-02-19  4:44 ` 'Badrikesh Prusty' via isar-users
  2026-02-19 13:36   ` 'MOESSBAUER, Felix' via isar-users
  2026-02-19 17:52 ` [PATCH v3 0/1] " 'Jan Kiszka' via isar-users
  1 sibling, 1 reply; 7+ messages in thread
From: 'Badrikesh Prusty' via isar-users @ 2026-02-19  4:44 UTC (permalink / raw)
  To: isar-users; +Cc: gokhan.cetin, alexander.heinisch, Badrikesh Prusty

Add '|| true' to systemd preset invocation during image postprocessing
to tolerate failures caused by already-masked units.

Signed-off-by: Badrikesh Prusty <badrikesh.prusty@siemens.com>
---
 meta/classes-recipe/rootfs.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes-recipe/rootfs.bbclass b/meta/classes-recipe/rootfs.bbclass
index 8485b32f..ef3ddb84 100644
--- a/meta/classes-recipe/rootfs.bbclass
+++ b/meta/classes-recipe/rootfs.bbclass
@@ -574,7 +574,7 @@ image_postprocess_populate_systemd_preset() {
         --show systemd || echo "" )
 
     if (test "$SYSTEMD_INSTALLED" = "installed"); then
-        sudo chroot '${ROOTFSDIR}' systemctl preset-all --preset-mode="enable-only"
+        sudo chroot '${ROOTFSDIR}' systemctl preset-all --preset-mode="enable-only" || true
     fi
 }
 
-- 
2.39.5

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20260219044406.441933-2-badrikesh.prusty%40siemens.com.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v3 1/1] image-postproc: ignore systemd preset failures
  2026-02-19  4:44 ` [PATCH v3 1/1] " 'Badrikesh Prusty' via isar-users
@ 2026-02-19 13:36   ` 'MOESSBAUER, Felix' via isar-users
  2026-02-19 15:26     ` 'Prusty, Badrikesh' via isar-users
  0 siblings, 1 reply; 7+ messages in thread
From: 'MOESSBAUER, Felix' via isar-users @ 2026-02-19 13:36 UTC (permalink / raw)
  To: Prusty, Badrikesh, isar-users; +Cc: Heinisch, Alexander, Cetin, Gokhan

On Wed, 2026-02-18 at 23:44 -0500, 'Badrikesh Prusty' via isar-users
wrote:
> Add '|| true' to systemd preset invocation during image postprocessing
> to tolerate failures caused by already-masked units.
> 
> Signed-off-by: Badrikesh Prusty <badrikesh.prusty@siemens.com>
> ---
>  meta/classes-recipe/rootfs.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes-recipe/rootfs.bbclass b/meta/classes-recipe/rootfs.bbclass
> index 8485b32f..ef3ddb84 100644
> --- a/meta/classes-recipe/rootfs.bbclass
> +++ b/meta/classes-recipe/rootfs.bbclass
> @@ -574,7 +574,7 @@ image_postprocess_populate_systemd_preset() {
>          --show systemd || echo "" )
>  
>      if (test "$SYSTEMD_INSTALLED" = "installed"); then
> -        sudo chroot '${ROOTFSDIR}' systemctl preset-all --preset-mode="enable-only"
> +        sudo chroot '${ROOTFSDIR}' systemctl preset-all --preset-mode="enable-only" || true

This is still too coarse. Currently the presetting fails on bullseye
targets with the following error "Failed to preset: Invalid argument.".

While I did not check the root-cause, I'm pretty sure this is a
different error which would be hidden by || true.

Felix

-- 
Siemens AG
Linux Expert Center
Friedrich-Ludwig-Bauer-Str. 3
85748 Garching, Germany

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/f13bbdab9cf960646677e69c6f2cfa79130dcb57.camel%40siemens.com.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v3 1/1] image-postproc: ignore systemd preset failures
  2026-02-19 13:36   ` 'MOESSBAUER, Felix' via isar-users
@ 2026-02-19 15:26     ` 'Prusty, Badrikesh' via isar-users
  0 siblings, 0 replies; 7+ messages in thread
From: 'Prusty, Badrikesh' via isar-users @ 2026-02-19 15:26 UTC (permalink / raw)
  To: MOESSBAUER, Felix, isar-users; +Cc: Heinisch, Alexander, Cetin, Gokhan


Hi,

I guess the error of invalid argument is due to invalid preset configs
in /usr/lib/systemd/system-preset/ or the preset files missing in
system-preset/ directory. With my initial check the `preset-all` and
`preset-mode` flags are available since systemd v215.

For masked service failures, I tested this on my systems locally with a
newer version of systemd as well. The command also fails with exit code
1 when running the preset on Debian Trixie and Forky. I’m not sure how
the builds for Trixie continues despite these failures.

Logs:
```
> systemctl --version
systemd 259 (259-1)
+PAM +AUDIT +SELINUX +APPARMOR +IMA +IPE +SMACK +SECCOMP +GCRYPT -GNUTLS +OPENSSL +ACL +BLKID +CURL +ELFUTILS +FIDO2 +IDN2 -IDN +KMOD +LIBCRYPTSETUP +LIBCRYPTSETUP_PLUGINS +LIBFDISK +PCRE2 +PWQUALITY +P11KIT +QRENCODE +TPM2 +BZIP2 +LZ4 +XZ +ZLIB +ZSTD +BPF_FRAMEWORK +BTF -XKBCOMMON -UTMP +SYSVINIT +LIBARCHIVE
547G ~
> sudo systemctl preset-all --preset-mode="enable-only"
Failed to preset all units: Unit /etc/systemd/system/hibernate.target is masked
547G ~
> echo $?
1

> systemctl --version
systemd 257 (257.9-1~deb13u1)
+PAM +AUDIT +SELINUX +APPARMOR +IMA +IPE +SMACK +SECCOMP +GCRYPT -GNUTLS +OPENSSL +ACL +BLKID +CURL +ELFUTILS +FIDO2 +IDN2 -IDN +IPTC +KMOD +LIBCRYPTSETUP +LIBCRYPTSETUP_PLUGINS +LIBFDISK +PCRE2 +PWQUALITY +P11KIT +QRENCODE +TPM2 +BZIP2 +LZ4 +XZ +ZLIB +ZSTD +BPF_FRAMEWORK +BTF -XKBCOMMON -UTMP +SYSVINIT +LIBARCHIVE
847E ~
> sudo systemctl preset-all --preset-mode="enable-only"
Failed to preset all units: Unit /etc/systemd/system/sleep.target is masked
847E ~
> echo $?
1
```

________________________________________
From: Moessbauer, Felix (FT RPD CED OES-DE) <felix.moessbauer@siemens.com>
Sent: 19 February 2026 19:06
To: Prusty, Badrikesh (FT FDS CES LX PBU 2); isar-users@googlegroups.com
Cc: Heinisch, Alexander (FT RPD CED SES-AT); Çetin, Gökhan (FT D EU TR C&E)
Subject: Re: [PATCH v3 1/1] image-postproc: ignore systemd preset failures

On Wed, 2026-02-18 at 23:44 -0500, 'Badrikesh Prusty' via isar-users
wrote:
> Add '|| true' to systemd preset invocation during image postprocessing
> to tolerate failures caused by already-masked units.
>
> Signed-off-by: Badrikesh Prusty <badrikesh.prusty@siemens.com>
> ---
>  meta/classes-recipe/rootfs.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes-recipe/rootfs.bbclass b/meta/classes-recipe/rootfs.bbclass
> index 8485b32f..ef3ddb84 100644
> --- a/meta/classes-recipe/rootfs.bbclass
> +++ b/meta/classes-recipe/rootfs.bbclass
> @@ -574,7 +574,7 @@ image_postprocess_populate_systemd_preset() {
>          --show systemd || echo "" )
>
>      if (test "$SYSTEMD_INSTALLED" = "installed"); then
> -        sudo chroot '${ROOTFSDIR}' systemctl preset-all --preset-mode="enable-only"
> +        sudo chroot '${ROOTFSDIR}' systemctl preset-all --preset-mode="enable-only" || true

This is still too coarse. Currently the presetting fails on bullseye
targets with the following error "Failed to preset: Invalid argument.".

While I did not check the root-cause, I'm pretty sure this is a
different error which would be hidden by || true.

Felix

--
Siemens AG
Linux Expert Center
Friedrich-Ludwig-Bauer-Str. 3
85748 Garching, Germany

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/SG2PR06MB5107B7AF30FF99BF6D45AFD6916BA%40SG2PR06MB5107.apcprd06.prod.outlook.com.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v3 0/1] image-postproc: ignore systemd preset failures
  2026-02-19  4:44 [PATCH v3 0/1] image-postproc: ignore systemd preset failures 'Badrikesh Prusty' via isar-users
  2026-02-19  4:44 ` [PATCH v3 1/1] " 'Badrikesh Prusty' via isar-users
@ 2026-02-19 17:52 ` 'Jan Kiszka' via isar-users
  2026-02-19 19:10   ` 'Jan Kiszka' via isar-users
  1 sibling, 1 reply; 7+ messages in thread
From: 'Jan Kiszka' via isar-users @ 2026-02-19 17:52 UTC (permalink / raw)
  To: Badrikesh Prusty, isar-users; +Cc: gokhan.cetin, alexander.heinisch

On 19.02.26 05:44, 'Badrikesh Prusty' via isar-users wrote:
> changes in v3:
> * Do not disable pre-population of enabled systemd services during build,
>   as this is the correct default behavior. Downstream layers can disable
>   it if needed.
> * Ignore failures from systemd preset only.
> 
> changes in v2:
> * Disable populate-systemd-preset at build time by default due to service
>   failures observed on some systems.
> 
> Badrikesh Prusty (1):
>   image-postproc: ignore systemd preset failures
> 
>  meta/classes-recipe/rootfs.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Is this series aiming at these new warnings of Isar?

DEBUG: Executing shell function image_postprocess_disable_systemd_firstboot
/proc/ is not mounted. This is not a supported mode of operation. Please fix
your invocation environment to mount /proc/ and /sys/ properly. Proceeding anyway.
Your mileage may vary.
Created symlink '/etc/systemd/system/systemd-firstboot.service' → '/dev/null'.
WARNING: Your image is not configured completely according to systemd-firstboot.
WARNING: It prompted: ""
DEBUG: Shell function image_postprocess_disable_systemd_firstboot finished

Jan

-- 
Siemens AG, Foundational Technologies
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/2c47f23b-7944-40be-9721-0a0b88b9d78f%40siemens.com.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v3 0/1] image-postproc: ignore systemd preset failures
  2026-02-19 17:52 ` [PATCH v3 0/1] " 'Jan Kiszka' via isar-users
@ 2026-02-19 19:10   ` 'Jan Kiszka' via isar-users
  2026-02-20  8:20     ` 'MOESSBAUER, Felix' via isar-users
  0 siblings, 1 reply; 7+ messages in thread
From: 'Jan Kiszka' via isar-users @ 2026-02-19 19:10 UTC (permalink / raw)
  To: Badrikesh Prusty, isar-users, Felix Moessbauer
  Cc: gokhan.cetin, alexander.heinisch

On 19.02.26 18:52, Jan Kiszka wrote:
> On 19.02.26 05:44, 'Badrikesh Prusty' via isar-users wrote:
>> changes in v3:
>> * Do not disable pre-population of enabled systemd services during build,
>>   as this is the correct default behavior. Downstream layers can disable
>>   it if needed.
>> * Ignore failures from systemd preset only.
>>
>> changes in v2:
>> * Disable populate-systemd-preset at build time by default due to service
>>   failures observed on some systems.
>>
>> Badrikesh Prusty (1):
>>   image-postproc: ignore systemd preset failures
>>
>>  meta/classes-recipe/rootfs.bbclass | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
> 
> Is this series aiming at these new warnings of Isar?
> 
> DEBUG: Executing shell function image_postprocess_disable_systemd_firstboot
> /proc/ is not mounted. This is not a supported mode of operation. Please fix
> your invocation environment to mount /proc/ and /sys/ properly. Proceeding anyway.
> Your mileage may vary.
> Created symlink '/etc/systemd/system/systemd-firstboot.service' → '/dev/null'.
> WARNING: Your image is not configured completely according to systemd-firstboot.
> WARNING: It prompted: ""
> DEBUG: Shell function image_postprocess_disable_systemd_firstboot finished
> 

Hmm, no. This seems to be another to-do for Felix' rootless patches. I
was running them, and this warning is gone when going back to vanilla Isar.

Jan

-- 
Siemens AG, Foundational Technologies
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/64b54a7b-4a10-4621-a090-6f63a987f183%40siemens.com.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v3 0/1] image-postproc: ignore systemd preset failures
  2026-02-19 19:10   ` 'Jan Kiszka' via isar-users
@ 2026-02-20  8:20     ` 'MOESSBAUER, Felix' via isar-users
  0 siblings, 0 replies; 7+ messages in thread
From: 'MOESSBAUER, Felix' via isar-users @ 2026-02-20  8:20 UTC (permalink / raw)
  To: Prusty, Badrikesh, isar-users, Kiszka, Jan
  Cc: Heinisch, Alexander, Cetin, Gokhan

On Thu, 2026-02-19 at 20:10 +0100, Jan Kiszka wrote:
> On 19.02.26 18:52, Jan Kiszka wrote:
> > On 19.02.26 05:44, 'Badrikesh Prusty' via isar-users wrote:
> > > changes in v3:
> > > * Do not disable pre-population of enabled systemd services during build,
> > >   as this is the correct default behavior. Downstream layers can disable
> > >   it if needed.
> > > * Ignore failures from systemd preset only.
> > > 
> > > changes in v2:
> > > * Disable populate-systemd-preset at build time by default due to service
> > >   failures observed on some systems.
> > > 
> > > Badrikesh Prusty (1):
> > >   image-postproc: ignore systemd preset failures
> > > 
> > >  meta/classes-recipe/rootfs.bbclass | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > 
> > Is this series aiming at these new warnings of Isar?
> > 
> > DEBUG: Executing shell function image_postprocess_disable_systemd_firstboot
> > /proc/ is not mounted. This is not a supported mode of operation. Please fix
> > your invocation environment to mount /proc/ and /sys/ properly. Proceeding anyway.
> > Your mileage may vary.
> > Created symlink '/etc/systemd/system/systemd-firstboot.service' → '/dev/null'.
> > WARNING: Your image is not configured completely according to systemd-firstboot.
> > WARNING: It prompted: ""
> > DEBUG: Shell function image_postprocess_disable_systemd_firstboot finished
> > 
> 
> Hmm, no. This seems to be another to-do for Felix' rootless patches. I
> was running them, and this warning is gone when going back to vanilla Isar.

Good catch. We need /proc and /sys mounted, which we currently not do
in this task.

Felix

> 
> Jan
> 
> -- 
> Siemens AG, Foundational Technologies
> Linux Expert Center

-- 
Siemens AG
Linux Expert Center
Friedrich-Ludwig-Bauer-Str. 3
85748 Garching, Germany

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/cc816d1921dae6691dd414ea9f48a06c28148fd6.camel%40siemens.com.

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2026-02-20  8:21 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-19  4:44 [PATCH v3 0/1] image-postproc: ignore systemd preset failures 'Badrikesh Prusty' via isar-users
2026-02-19  4:44 ` [PATCH v3 1/1] " 'Badrikesh Prusty' via isar-users
2026-02-19 13:36   ` 'MOESSBAUER, Felix' via isar-users
2026-02-19 15:26     ` 'Prusty, Badrikesh' via isar-users
2026-02-19 17:52 ` [PATCH v3 0/1] " 'Jan Kiszka' via isar-users
2026-02-19 19:10   ` 'Jan Kiszka' via isar-users
2026-02-20  8:20     ` 'MOESSBAUER, Felix' via isar-users

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox