From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Tue, 08 Oct 2024 07:16:24 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-yb1-f187.google.com (mail-yb1-f187.google.com [209.85.219.187]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 4985GM2x019959 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 8 Oct 2024 07:16:23 +0200 Received: by mail-yb1-f187.google.com with SMTP id 3f1490d57ef6-e1159fb161fsf7207030276.1 for ; Mon, 07 Oct 2024 22:16:23 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1728364577; cv=pass; d=google.com; s=arc-20240605; b=DW7VglB8HT71HmODJwKEziH0vg+AoH4DTbezw+OvvD8+71o+CQ9yGsiya/u16kzQf8 ga+Esw6B/bAPQiVIyZSooVoZ+bufdNXbUAePokCcLQEWxWa4JV40fAKMkdIOuOPZ+f07 ouYbXRoG7LH3/i9Hd/uyYiJIU4HVMwjOYTwwVkLFTHy9FL1FHWgWx3yBEYX2e2YmWgOU Tdg0UqtAzE+A3lbWnGFBtqSHNEutsTUHAslBUzblCSEgKyLNxVys6fE/eRLMGXlyVXYw DSqpGD03MsxK4+x0R/nExKI6ry2xk0BTd+vm3nDevwSPIlZBeHqXOuXXrU0mIoAo1ymm HN4Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:user-agent :content-transfer-encoding:autocrypt:references:in-reply-to:date:to :from:subject:message-id:sender:dkim-signature; bh=fIIt3bbGVhmyoxU6u0U8lcOTLRuxHkw+MGs1/IrpMrw=; fh=UVvs1CQLwsPuKGv90yh9METQyaMCt3m7qtnlpOif6Wg=; b=JExpJ9QN9WMlvf2q4DoOpXIYHuiHUfRBbWMqtihKdOV+ydxyPKqPJHWkwFkt+Mhc3x 2szhC1P4CWks4MccHg30Qub5gRoeOFjSx71FBRtDJ9hjOlsDc89BTzy3B+NWeQjf1hME Qt4tIeliXT6J1GoO1r0OrHVH8jLm5U4qrxHyyJ7enlybpPJb6BbgEST/LOdHKxJAzjdb FHzYkbvdblS/mCPB2imHGB7q26JeSs9A0jFYqkKBdA+o8Fa44Uf/bpM9A6TPgp98NiRZ i9+HsiA/2vG6E6FRAkrjCv98gvorcxwgxVMKubWBBOD0YypVzfDxeyJHYHjWAS3PPf4b 9Bew==; darn=ilbers.de ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1728364577; x=1728969377; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:user-agent:content-transfer-encoding :autocrypt:references:in-reply-to:date:to:from:subject:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=fIIt3bbGVhmyoxU6u0U8lcOTLRuxHkw+MGs1/IrpMrw=; b=GtcpVVfZvYIMYTNDp9/pjZFmIzZ6Sb6qWWgS2bYkg5NUJRtZlQOwqRm3jwJIOXIMPy TZxyKW0J5yQWcQ3/EEY14YA8q45ZxcHiFN2Mw+9Hlp8ipatlcbWpXnYOT8VSZdMUDS3m 7qD53MXU7LliwrP5eN2AQh+AIGi1RmB1vGivQfdC3DL0w9cH4ZTfEbSG9h3V8JkStk0y EmaMI1Yz0UY72gmhz/EIrW5+yui9+kaYcIS1dbnGU3wLoOrCaGNwBabPaqj/mQkoHPxP GY8HTHWOR5QI6F2i01nmITQ40p5e5vxHz9SGujYOqtXYnrs9yN5+4aKTgSsriByafSxC orng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728364577; x=1728969377; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :user-agent:content-transfer-encoding:autocrypt:references :in-reply-to:date:to:from:subject:message-id:x-beenthere :x-gm-message-state:sender:from:to:cc:subject:date:message-id :reply-to; bh=fIIt3bbGVhmyoxU6u0U8lcOTLRuxHkw+MGs1/IrpMrw=; b=f4qVa60MAngzgaDAfipl6IXsa5ihwZbYFK/twAx3XNx9LA5S4jZHQitBRzbEmJTULS ubtYRaOLFAI4jbki//c9DYL0YvhGRnS4Y2gBGBmDKfl0lGZ3KRXIwhRT51azGFXla7A3 zXHc3JSyNThijqrxN+ogwP+BHagb0jqzSNKuuWOVS1lj/xNYhvkJMjZbJnWzc4H5zj11 diu0/FFnQGBZDWtaS3kHNAGt9UXM4GsJvXhoVpBhvZ1cshKKdpfSnYmtv911p3ncImgl NWr778KrwezQywCUdB3wldej8PGx4cXqO6Sxq46g9tCfW/KQ8af0xqJDF0WRaopkHCnc szwA== Sender: isar-users@googlegroups.com X-Forwarded-Encrypted: i=2; AJvYcCWrmZGd3wZZpeb9+sswJUGBQAaC6QmK8t5rNwPCjV5Tb9RnN/4ELJGZucMyUe+dN26jZXdW@ilbers.de X-Gm-Message-State: AOJu0Yy6tTgf5rycApZUVkHdoWrp/5W8xvs6jXKPF0lt+YYR3nwz7U4Z Evp4GoFvC8oGIenS049jggTszAHO+4h29d+Z3mtpRx5MkNkGENMU X-Google-Smtp-Source: AGHT+IFrRSnIYCJxaeqe39dAKSlJwkbROFizZUFaICYZ2qyPt8bk81nZZpS0aFkBP/y3193UueRGeA== X-Received: by 2002:a05:6902:10c7:b0:e1d:a827:2a46 with SMTP id 3f1490d57ef6-e2893922c42mr10690184276.36.1728364576743; Mon, 07 Oct 2024 22:16:16 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6902:120a:b0:e22:5bd7:875 with SMTP id 3f1490d57ef6-e286f5d10cdls246070276.0.-pod-prod-03-us; Mon, 07 Oct 2024 22:16:16 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWKOibUch1FHzAJgCYXfR6XiU9jC8MqbNPdMgPwsO45Bj62kS/2Jqx//Zqyyoz4lfhZCcmj4Ca0LzEY@googlegroups.com X-Received: by 2002:a05:6902:1a4a:b0:e20:291e:7fe1 with SMTP id 3f1490d57ef6-e28936ea426mr10641553276.25.1728364575713; Mon, 07 Oct 2024 22:16:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1728364575; cv=none; d=google.com; s=arc-20240605; b=BzDvKxjUYbkVagdyUVt90c4Snk0zoNGmshXH/aFSOwQUXlVA5H59L0m3CaWJlTv0EV RF6PmzzOFvr2sLDQ3/vPknVJQbzK3GwVRPVQzTYxcdhyN4q5MKmJiw4U4dyFFHT9zb4a aEBK5GvVrpd1o6doIp95yNi6mZvxoFOfyUbpBFH9XTKUWoDYfqxk47dtZIZLmrzoi9qr e6CQxj0NetosN402oQKfEv5jpjSQ8q1COSUUSHWjsVsBrZbQF9nwfXNhzZekn6DxFJ0U 3KYxVoyQaOhQ+x4FWUcG2pO9kReVTxmNh09fXWpi0/wcaSuCeC0HsUejk9pZzF4gbCoi egOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:to:from:subject:message-id; bh=V6eCxJ071tB6K4D1yldOBWJRPv+oCo2Te9naMiCRq3k=; fh=O+ZMFUiiuyZKsfz7Fw8hsdknZlxcSFSsLsCydBEGD0o=; b=Mxyk4ydpX3nwkyRSLiYJ3yXB4YeQejutbJ3pJnP7e2g1pUD+Pp4QvjTyEom3ccGc5P sKY6aMB4f1ZietDQbMr6pMsWMd8cKlQn4nP/auXa5irKpcXtxDt/SP3ub2W2wl/CUU/S LbALuPvgUGZMliPxjzku3A88z/lv35URbxHpMXHP2YaUQvWvCxSw1ECYg3Qv+kuw7Rfb rbnz8Oi6b5LM6KaIw1Wnl/BgSbkBr11xuuXyLThGzyYs44bbVP+DEYJAeVwgPf9Vs58m eMnzSzQQ6Jd/lbY79SWgdW8w6/aNA3239Uxt9l9O4CjWzXAlmdZ+5nUfg+zyIkVaPnad tW0A==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id 3f1490d57ef6-e28a593d58esi258776276.1.2024.10.07.22.16.15 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 07 Oct 2024 22:16:15 -0700 (PDT) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Received: from [IPv6:::1] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 4985GBgm019945 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 8 Oct 2024 07:16:12 +0200 Message-ID: <2c4a2e70bcb490cf571748b2a35449a2d7193dee.camel@ilbers.de> Subject: Re: [PATCH v2] Fix linux-starfive build under sid From: Uladzimir Bely To: Jan Kiszka , isar-users@googlegroups.com Date: Tue, 08 Oct 2024 08:16:11 +0300 In-Reply-To: References: <20241004082906.29224-1-ubely@ilbers.de> <475f51bd-d227-405b-a9da-0d2b41a98319@siemens.com> <65edc6fed0558a7de81638e1d0dec5d1297839e9.camel@ilbers.de> <10f5c181-82c6-4f28-b9a8-c815459923a6@siemens.com> <64de5f65-a90a-4d44-8962-218ff016c950@siemens.com> <8a2e073548325768f995620c6d6dc5dda36bf0a5.camel@ilbers.de> <8e2696ba-1311-4e0c-89dc-8c29e84ac0c6@siemens.com> Autocrypt: addr=ubely@ilbers.de; prefer-encrypt=mutual; keydata=mQENBGO2eUkBCACtT+T3OrPVSExBmqfgXT3lp9XcdxRzjYp26wezkgYjjBXaf36bxtaAf S471VoQtpar0RVeFfW7WDDdfX9ZclSj36zBQe+RVSJzoNoNQfjOXWuSHb5Z+cpAFtqBY4muxK4+ia IlLJd6CN3ejOsLHATtCeHHq8wi0z2T+KdLQO+wQRgo2hjj0Lp9pGTrKJry50HP/o7Vbdu14dOx2xq r8+wPc6SQbBIrcqaa4MqCQC00vQG7eXvo+k2MOw59FDdpMH0KR9mHgp3u/s4I+4YRBArukt9G9xz/ rsEFmxAIBC6N/a6Hzwg4puc91n7ABDsPg8Vp+X3MDraujN0dvR6OKVNtABEBAAG0IFVsYWR6aW1pc iBCZWx5IDx1YmVseUBpbGJlcnMuZGU+iQFOBBMBCAA4FiEEJqPNVhVGyk12Eh+PAUQYBM/2FkoFAm O2eUkCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQAUQYBM/2FkprlAgAmuna8Hm9EyoEtTl DBGDg6Zm4ZLp5ffvZBE946h92jepDrteoxsJ7pSzJVC2HmDLa4iZUao7lLLbDsUj5x45/iLJcqBZK k3YnAxP2r6a+kI+1VVQY1pxdG1nlJAbdNzoojm/qmezNPSrqni61KVMQKsXBCWhIjSXDSM9CsBj21 a+9qaVqfxovJGTn9lgrZO+xzKQNMKZeOouJlscVuFj21P0ww3/YENiU/nMeTSuYypO76mDtAd08Jo nc3yuHa9MJGei5ixN3wT+IrGR2aL2hdw2M6NgH7sYbL2Zi4ugD6RXHJai1Bh2yvFSVqSQ+M6QOInT 4ud7wslm1XRB065dXtA== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.0 (by Flathub.org) MIME-Version: 1.0 X-Spam-Status: No, score=-4.6 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2, RCVD_IN_RP_CERTIFIED,RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-Original-Sender: ubely@ilbers.de X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-TUID: xsQ088Dis1iW On Fri, 2024-10-04 at 12:53 +0200, Jan Kiszka wrote: > On 04.10.24 12:49, Uladzimir Bely wrote: > > On Fri, 2024-10-04 at 12:45 +0200, Jan Kiszka wrote: > > > On 04.10.24 12:37, Uladzimir Bely wrote: > > > > On Fri, 2024-10-04 at 12:27 +0200, Jan Kiszka wrote: > > > > > On 04.10.24 12:22, 'Jan Kiszka' via isar-users wrote: > > > > > > On 04.10.24 11:43, Uladzimir Bely wrote: > > > > > > > On Fri, 2024-10-04 at 10:38 +0200, Jan Kiszka wrote: > > > > > > > > On 04.10.24 10:17, Uladzimir Bely wrote: > > > > > > > > > The patch is taken from the linux kernel upstream >=3D > > > > > > > > > 6.8. > > > > > > > > >=20 > > > > > > > > > Signed-off-by: Uladzimir Bely > > > > > > > > > --- > > > > > > > > > =C2=A0...oc-arguments-order-in-btrfs_ioctl_se.patch | 43 > > > > > > > > > +++++++++++++++++++ > > > > > > > > > =C2=A0.../linux/linux-starfive_6.6-visionfive2.bb=C2=A0= =C2=A0 |=C2=A0 1 + > > > > > > > > > =C2=A02 files changed, 44 insertions(+) > > > > > > > > > =C2=A0create mode 100644 meta-isar/recipes- > > > > > > > > > kernel/linux/files/0001- > > > > > > > > > btrfs-fix-kvcalloc-arguments-order-in- > > > > > > > > > btrfs_ioctl_se.patch > > > > > > > > >=20 > > > > > > > > > Changes since v1 (Fix linux build under sid and > > > > > > > > > trixie): > > > > > > > > >=20 > > > > > > > > > - Since we don't build linux-mainline/linux-phy > > > > > > > > > kernels > > > > > > > > > for > > > > > > > > > trixie/sid > > > > > > > > > apply kernel patch only for linux-starfive_6.6- > > > > > > > > > visionfive2 > > > > > > > > > target. > > > > > > > > >=20 > > > > > > > > > I additionally checked [1] for existing branches and > > > > > > > > > can > > > > > > > > > conclude: > > > > > > > > > =C2=A0- recent 6.6-based branch > > > > > > > > > "JH7110_VisionFive2_upstream" > > > > > > > > > is > > > > > > > > > still > > > > > > > > > affected and requires the patch > > > > > > > > > =C2=A0- recent "starfive-tech/visionfive" is 6.10-based > > > > > > > > > already > > > > > > > > > includes > > > > > > > > > the fix, but using it leads to different build > > > > > > > > > errors. > > > > > > > > > Also, > > > > > > > > > I'm > > > > > > > > > not > > > > > > > > > sure if it properly supports "VisionFive2" board. > > > > > > > > >=20 > > > > > > > > > So, for now, the simplest way to fix build error we > > > > > > > > > have > > > > > > > > > in > > > > > > > > > CI is > > > > > > > > > to > > > > > > > > > just apply upstream patch. > > > > > > > > >=20 > > > > > > > > > [1] https://github.com/starfive-tech/linux > > > > > > > > >=20 > > > > > > > > > diff --git a/meta-isar/recipes- > > > > > > > > > kernel/linux/files/0001- > > > > > > > > > btrfs- > > > > > > > > > fix- > > > > > > > > > kvcalloc-arguments-order-in-btrfs_ioctl_se.patch > > > > > > > > > b/meta- > > > > > > > > > isar/recipes-kernel/linux/files/0001-btrfs-fix- > > > > > > > > > kvcalloc- > > > > > > > > > arguments- > > > > > > > > > order-in-btrfs_ioctl_se.patch > > > > > > > > > new file mode 100644 > > > > > > > > > index 00000000..afe09eab > > > > > > > > > --- /dev/null > > > > > > > > > +++ b/meta-isar/recipes-kernel/linux/files/0001- > > > > > > > > > btrfs- > > > > > > > > > fix- > > > > > > > > > kvcalloc- > > > > > > > > > arguments-order-in-btrfs_ioctl_se.patch > > > > > > > > > @@ -0,0 +1,43 @@ > > > > > > > > > +From 6ff09b6b8c2fb6b3edda4ffaa173153a40653067 Mon > > > > > > > > > Sep 17 > > > > > > > > > 00:00:00 > > > > > > > > > 2001 > > > > > > > > > +From: Dmitry Antipov > > > > > > > > > +Date: Thu, 21 Dec 2023 11:47:45 +0300 > > > > > > > > > +Subject: [PATCH] btrfs: fix kvcalloc() arguments > > > > > > > > > order > > > > > > > > > in > > > > > > > > > btrfs_ioctl_send() > > > > > > > > > + > > > > > > > > > +When compiling with gcc version 14.0.0 20231220 > > > > > > > > > (experimental) > > > > > > > > > +and W=3D1, I've noticed the following warning: > > > > > > > > > + > > > > > > > > > +fs/btrfs/send.c: In function 'btrfs_ioctl_send': > > > > > > > > > +fs/btrfs/send.c:8208:44: warning: 'kvcalloc' sizes > > > > > > > > > specified > > > > > > > > > with > > > > > > > > > 'sizeof' > > > > > > > > > +in the earlier argument and not in the later > > > > > > > > > argument [- > > > > > > > > > Wcalloc- > > > > > > > > > transposed-args] > > > > > > > > > + 8208 |=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = sctx->clone_roots =3D > > > > > > > > > kvcalloc(sizeof(*sctx- > > > > > > > > > > clone_roots), > > > > > > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 ^ > > > > > > > > > + > > > > > > > > > +Since 'n' and 'size' arguments of 'kvcalloc()' are > > > > > > > > > multiplied to > > > > > > > > > +calculate the final size, their actual order doesn't > > > > > > > > > affect > > > > > > > > > the > > > > > > > > > result > > > > > > > > > +and so this is not a bug. But it's still worth to > > > > > > > > > fix > > > > > > > > > it. > > > > > > > > > + > > > > > > > > > +Signed-off-by: Dmitry Antipov > > > > > > > > > +Reviewed-by: David Sterba > > > > > > > > > +Signed-off-by: David Sterba > > > > > > > > > +--- > > > > > > > > > + fs/btrfs/send.c | 4 ++-- > > > > > > > > > + 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > > + > > > > > > > > > +diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c > > > > > > > > > +index 4e36550618e5..2d7519a6ce72 100644 > > > > > > > > > +--- a/fs/btrfs/send.c > > > > > > > > > ++++ b/fs/btrfs/send.c > > > > > > > > > +@@ -8205,8 +8205,8 @@ long btrfs_ioctl_send(struct > > > > > > > > > inode > > > > > > > > > *inode, > > > > > > > > > struct btrfs_ioctl_send_args *arg) > > > > > > > > > +=C2=A0 goto out; > > > > > > > > > +=C2=A0 } > > > > > > > > > +=20 > > > > > > > > > +- sctx->clone_roots =3D kvcalloc(sizeof(*sctx- > > > > > > > > > > clone_roots), > > > > > > > > > +- =C2=A0=C2=A0=C2=A0=C2=A0 arg- > > > > > > > > > > clone_sources_count + 1, > > > > > > > > > ++ sctx->clone_roots =3D kvcalloc(arg- > > > > > > > > > > clone_sources_count + 1, > > > > > > > > > ++ =C2=A0=C2=A0=C2=A0=C2=A0 sizeof(*sctx- > > > > > > > > > > clone_roots), > > > > > > > > > +=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 GFP_KERNEL); > > > > > > > > > +=C2=A0 if (!sctx->clone_roots) { > > > > > > > > > +=C2=A0 ret =3D -ENOMEM; > > > > > > > > > +--=20 > > > > > > > > > +2.45.2 > > > > > > > > > + > > > > > > > > > diff --git a/meta-isar/recipes-kernel/linux/linux- > > > > > > > > > starfive_6.6- > > > > > > > > > visionfive2.bb b/meta-isar/recipes- > > > > > > > > > kernel/linux/linux- > > > > > > > > > starfive_6.6- > > > > > > > > > visionfive2.bb > > > > > > > > > index f4dd5c9a..a267241f 100644 > > > > > > > > > --- a/meta-isar/recipes-kernel/linux/linux- > > > > > > > > > starfive_6.6- > > > > > > > > > visionfive2.bb > > > > > > > > > +++ b/meta-isar/recipes-kernel/linux/linux- > > > > > > > > > starfive_6.6- > > > > > > > > > visionfive2.bb > > > > > > > > > @@ -8,6 +8,7 @@ require recipes-kernel/linux/linux- > > > > > > > > > custom.inc > > > > > > > > > =C2=A0SRC_URI +=3D " \ > > > > > > > > > =C2=A0=C2=A0=C2=A0=C2=A0 > > > > > > > > > https://github.com/starfive-tech/linux/archive/${SRCREV}.= tar.gz;downloadfilename=3Dlinux-starfive-${SRCREV}.tar.gz > > > > > > > > > =C2=A0\ > > > > > > > > > =C2=A0=C2=A0=C2=A0=C2=A0 > > > > > > > > > file://0001-riscv-efistub-Ensure-GP-relative-addressing-i= s-not-u.patch > > > > > > > > > =C2=A0\ > > > > > > > > > +=C2=A0=C2=A0=C2=A0 > > > > > > > > > file://0001-btrfs-fix-kvcalloc-arguments-order-in-btrfs_i= octl_se.patch > > > > > > > > > =C2=A0\ > > > > > > > > > =C2=A0=C2=A0=C2=A0=C2=A0 file://starfive2_extra.cfg" > > > > > > > > > =C2=A0SRCREV =3D "9fe004eaf1aa5b23bd5d03b4cfe9c3858bd884c= 4" > > > > > > > > > =C2=A0SRC_URI[sha256sum] =3D > > > > > > > > > "9eaf7659aa57e2c5b399b7b33076f1376ec43ef343680e0a57e0 > > > > > > > > > a2a9 > > > > > > > > > bef6 > > > > > > > > > c0ae" > > > > > > > >=20 > > > > > > > > NACK, update the kernel. I think I already told you. > > > > > > > > May > > > > > > > > even > > > > > > > > obsolete > > > > > > > > the other patch. > > > > > > >=20 > > > > > > > Yes, I tried this (see the text above the diff starts). > > > > > > > Updated > > > > > > > 6.6- > > > > > > > based branch still requires both patches. > > > > > > >=20 > > > > > >=20 > > > > > > https://github.com/starfive-tech/linux/commits/starfive-6.6.31-= dubhe > > > > > >=20 > > > > > > As I told you. > > > > > >=20 > > > > > > I'm sending the proper patch in a minute. > > > > > >=20 > > > > >=20 > > > > > Sorry, seems that's the wrong tree, and > > > > > JH7110_VisionFive2_6.6.y_devel > > > > > was not updated properly. > > > > >=20 > > > > > But there is no way to build against sid except for using an > > > > > older > > > > > snapshot. How did you test this? > > > > >=20 > > > > > Jan > > > > >=20 > > > >=20 > > > > I tested few branches: > > > > - JH7110_VisionFive2_upstream - this seems to be a proper tree > > > > (at > > > > least, it includes starfive_visionfive2_defconfig, and > > > > appropriate > > > > devicetree files look complete). But this still has now a fix > > > > and > > > > requires both patches > > >=20 > > > Yes, it is. I've created > > > https://github.com/starfive-tech/linux/issues/140=C2=A0to resolve the > > > problem > > > "upstream" eventually. > > >=20 > > > > - starfive-tech/visionfive - this is based on linux-6.10, > > > > includes > > > > both patches. But there are different build errors here and no > > > > starfive_visionfive2_defconfig present. Also, board devicetree > > > > files > > > > has less stuff. > > >=20 > > > That's version 1 of the VisionFive, a different board. > > >=20 > > > > - starfive-6.6.31-dubhe - this includes the patch (but not the > > > > other > > > > one). But there is also no proper defconfig and board > > > > deficetrees > > > > are > > > > not looking full enough. > > >=20 > > > Even a different SoC that may lack patches we need. I was misled. > > >=20 > > > >=20 > > > > Some tests were done in one of our CI instances where we > > > > already > > > > have > > > > an updated version of debootstrap installed. Manual check of > > > > the > > > > build > > > > can be also done under kas-container shell, but some additional > > > > steps > > > > (e.g., adding bookworm-backports to source list and installing > > > > "debootstrap/bookworm-backports") are required before running > > > > bitbake. > > > >=20 > > >=20 > > > You must be natively building - I don't have that much time. > > > Crossbuild > > > is borken once again, but the snapshot we also use in isar-cip- > > > core > > > is > > > fine (but not affected by the compiler update), see my kas menu > > > patch. > > >=20 > >=20 > > Yes, I was building it natively for tests (as well as CI does). > >=20 > > Trixie/sid cross builds are currently broken (not only on riscv64). > > That's another issue to solve (or, maybe, wait for upstream?). > >=20 >=20 > Use snapshots for crossbuilding. As I wrote, native building takes > way > too much time to be used in practice. >=20 > BTW, we can bump to the latest revision of > JH7110_VisionFive2_6.6.y_devel and drop the other patch at this > chance. > Just noticed that 6.6.20, their current head, actually contains it. >=20 > Jan >=20 Let's postpone bumping the development revision until both patches are merged. Or, at least, it could be done with a separate patchset. v2 is applied to the next. --=20 Best regards, Uladzimir. --=20 You received this message because you are subscribed to the Google Groups "= isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to isar-users+unsubscribe@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/= isar-users/2c4a2e70bcb490cf571748b2a35449a2d7193dee.camel%40ilbers.de.