From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6529810911788531712 X-Received: by 10.28.158.193 with SMTP id h184mr1463689wme.22.1520351804370; Tue, 06 Mar 2018 07:56:44 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.28.52.133 with SMTP id b127ls1557015wma.6.canary-gmail; Tue, 06 Mar 2018 07:56:43 -0800 (PST) X-Google-Smtp-Source: AG47ELtm7olrzT+iqrpL0L3aSq5fdS2X991KhGp18e4jzcSsL2CpyneX0Z0QOr26qEIVmjsKp4rt X-Received: by 10.28.87.78 with SMTP id l75mr1580270wmb.9.1520351803888; Tue, 06 Mar 2018 07:56:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520351803; cv=none; d=google.com; s=arc-20160816; b=zkTiy1QzLgbsbXbpshDG7PWHaGqqbkHpxye8hXNo/X0BW70q35o4T3SQpgIJ3JbzMA Tcd67T2l8amF6Sp52KPsM1VVbBqTxQ8QP9T/9K3OkZ2htTdFoVEyhClaZsst9iHOQiSk YnsrknbS0eatPIdQt178SuBXElIlwmOU65jyaDpGyr5V1ralLdx3M/bdP4vwBdfO7xZL CAlOjPkBfd9dtbpLnPbEkrUJUSnghszUGMdbgQ19UXSIjeW4/Y11CFM6xEAOe/e2HTsw C35xk5D+4pRXHP1NzPnYdgit4AVAxU877y4ORzNGG3ePnXYcB1luve0v+K7X5J02iDxI WCNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=EkwADaDuHAlP1ZPrDeQ/KvpBq7/CTpPm6SCAjryyky0=; b=GDDaeh7gpXt3PH0YTHMQ+IuJfHD+BBmlmHu46cZ3ZqScqzE8+QXquyxUygBvHBsI0v GXYScc4PycbZozOEt38mA3H7FxqvenjN1r4UetHiL0XUif2+yfovkNpyFKhNMyAnIUwm nwl4zpRdONds5Q/DXkQzht8dNYs0zIJGUoF1L9GnktVlilsq3N3Nhw9cdog5iRGg2yHM +GMFzLzSjPIpo4++erL0ZYStpWajW6ZLulCnsGJUI+ugNi/kFKhf5V+FoF7lJp+cugkf AFkl0E3/A2dEAwisziLYSpiEps1KoGCr3DJhV9ntzPIBaCkSp7K8Sp/n9wPqurNFmggF 7hRA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id j199si295481wmj.1.2018.03.06.07.56.43 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Mar 2018 07:56:43 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail3.siemens.de (mail3.siemens.de [139.25.208.14]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id w26Fuhms008302 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 6 Mar 2018 16:56:43 +0100 Received: from [139.25.194.173] ([139.25.194.173]) by mail3.siemens.de (8.15.2/8.15.2) with ESMTP id w26Fuhhk022698; Tue, 6 Mar 2018 16:56:43 +0100 Subject: Re: [PATCH v2 2/4] example-module: Do not return error on init To: Alexander Smirnov , isar-users@googlegroups.com References: <20180306124055.15990-3-asmirnov@ilbers.de> <20180306154012.17121-1-asmirnov@ilbers.de> From: Jan Kiszka Message-ID: <2c4c122e-15e6-cbeb-8030-12d8d51d7149@siemens.com> Date: Tue, 6 Mar 2018 16:56:41 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <20180306154012.17121-1-asmirnov@ilbers.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: /hey/MB7PCrY On 2018-03-06 16:40, Alexander Smirnov wrote: > Also make module re-loadable by adding exit hook. > > Signed-off-by: Alexander Smirnov > --- > .../recipes-kernel/example-module/files/src/example-module.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/meta-isar/recipes-kernel/example-module/files/src/example-module.c b/meta-isar/recipes-kernel/example-module/files/src/example-module.c > index 07cb214..4e74ee7 100644 > --- a/meta-isar/recipes-kernel/example-module/files/src/example-module.c > +++ b/meta-isar/recipes-kernel/example-module/files/src/example-module.c > @@ -11,9 +11,15 @@ > static int __init example_module_init(void) > { > printk("Just an example\n"); > - return -ENOANO; > + return 0; > +} > + > +static void __exit example_module_exit(void) > +{ > + return; > } > > module_init(example_module_init); > +module_exit(example_module_exit); > > MODULE_LICENSE("GPL"); > Looks better :) Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux