Re: [PATCH v3 2/3] deploy boot files via sstate-cache

[Jan Kiszka <jan.kiszka@siemens.com>]

On 09.01.24 13:46, Moessbauer, Felix (T CED OES-DE) wrote:
> Am Freitag, dem 29.12.2023 um 09:29 +0200 schrieb Anton Mikanovich:
>> 23/02/2023 08:43, Felix Moessbauer wrote:
>>> This patch changes how we deploy the boot files.
>>> Instead of manually deploying, we use the sstate infrastructure for
>>> that. By that, accidental overrides of the artifacts can be
>>> automatically detected. On clean, the artifacts are also cleaned.
>>>
>>> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
>>
>> Hello Felix,
>>
>> This logic fails on fargets that deploy DTB files if building several
>> distros
>> inside one builddir. DTB filenames are usually the same in this case,
>> so 
>> it is
>> detected as copy of already exist files.
> 
> Hi,
> 
> this is a bug in the initial deploy logic which is just uncovered by
> the deploy-via-sstate mechanism. In the past, we probably had data-
> races on these files (of course only if the targets were build in
> parallel).
> 
> One possible fix would be to prefix the DTB files with the
> image+machine+distro name. How is this done in OE?

Careful with renaming, I'm not sure of we aren't picking up the DTBs
from there and also relying on the names as the firmware will need
specific naming as well. This needs at least double-checking.

Jan

-- 
Siemens AG, Technology
Linux Expert Center