From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Fri, 22 May 2026 16:29:24 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-ed1-f63.google.com (mail-ed1-f63.google.com [209.85.208.63]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 64METOC0005602 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 22 May 2026 16:29:24 +0200 Received: by mail-ed1-f63.google.com with SMTP id 4fb4d7f45d1cf-67c4b488521sf8057516a12.1 for ; Fri, 22 May 2026 07:29:24 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1779460159; cv=pass; d=google.com; s=arc-20240605; b=P3dNQiYwPnXGMlqnUlSr/GDQC8GyFmF0GN5myd83p/uzIHW/eXLP/RSbZLF/TAI+RT gk1XXdbcMOLR6aqqzo9rTXwD/wIjo6TvGR5MsWgevBu+shdFlpTVPY4H8smAarLYQ76b qAsgECRKsrj775/n5xOEbH3IWTfKEEtqkhhBBBQL1zBhGKpD7mhZ8w+zaERvYUtOyaYE shs9Vkj5J1DuzxikZA+fkkPaEh0s+Wa7tMEFhi0BDpZAR5nxybAF0lj4ZHR0oCM4PwkB 3IKU4uJPTqbZK38zgwa8Re+M+8nK7KemV+Osgmb0P54rSVIPO0J+VUfsT3AOfWynB/UL CVxA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:dkim-signature; bh=Jn+IXZsu9n3wXl7cXWzo01aFPiz1I6W8IToBhQTQtX0=; fh=hVjhu8Iwkad/YRBJrqoS/1Lo87knBMSJ4mvuooG8r3M=; b=Vy6Psw7IvFCZkhSqhpgAx7vFXFmz/dBzcNvGY7zx9o5fUTD6Kw/mJox6w6ait4wRQS In4Lks1stgV5tAaQDQcdwcUEFp5QiklNheOS7+vkUdb/MoyDyBeIl6GDHWZEm4ONk0lx 5YkqGq9zoVbg1dcFpZGr8YLeWDMEuUQnU44ovfvMB70M1BrlqgYCmzrAJtKwR5blPN81 TxJ3eoRQ4hEu5QfXrR7UBvxZi4al6OZSQBIddkHiYzQbJpGa4EhNSNEqm+ed+EPUsswY RI1Fl+WWSs1X9+FWCmpDEte1ZIurYBdjpaxkWXMknJjVybq/AwdjUst6nIyaH3KIi9x+ 5ehg==; darn=ilbers.de ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=wzh@ilbers.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20251104; t=1779460159; x=1780064959; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:in-reply-to:from:content-language:references:cc :to:subject:user-agent:mime-version:date:message-id:sender:from:to :cc:subject:date:message-id:reply-to; bh=Jn+IXZsu9n3wXl7cXWzo01aFPiz1I6W8IToBhQTQtX0=; b=DsHXyhV+1aoRVcUVhMaAcqNwvjc0Z3f3abnPDqvhO2aP2A83ELJAErrGjJ6FLx7ejo P3o3okRmKup5/Kh20gJbUQJ2/j7XF8jrYRYib7CC3ZNOVTK1Daq7yY1eqVBOpuilR4pC yd+qldinlluRFteg43bPMY3GR3ZL+ipikuuQCA68UOnqFYcADEKW/z4OfJbZ0hnoq8XU S13piJRABVfsz5+jwHLjYgIzu21vgisdJIS39uZd6LXfi4cyBzGdwfUnsaecWBQJXT+o Ie9mSc+MXb/95jxKN7A1eXkLCET1v86C1TT3fQBZ6gfIAN+V4ZfVj4LaJKqFSMw3MoA+ CoOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779460159; x=1780064959; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:in-reply-to :from:content-language:references:cc:to:subject:user-agent :mime-version:date:message-id:x-beenthere:x-gm-message-state:sender :from:to:cc:subject:date:message-id:reply-to; bh=Jn+IXZsu9n3wXl7cXWzo01aFPiz1I6W8IToBhQTQtX0=; b=dswS89bxkzjIEEAuoh69gneCI2lK9wwauZ0OAlTBRKzfJT4g6lvRjDW1QDEovMn7Bt lkU5GT1VKgRaMIxUsXiZB0Aoxqj+B3Q5jRsKUGVKnMACmj8pIFczazHSm2aoALoqzYxL AwYozaXo7k9KW0q7Z4E44i1gamxe5qgMcEjXJYXXF4oZAbWT5SRHWMXjJGgnXppKjKXI mzQpFDJLrsfXxMgzEKL73ahV61l2Lsio140yPcFI+tcfn7AEcpaa57RCVVo9a7uluFIN 0mP9oTiGtU7jAM0Kimcb+YCrzvvxFTXIMjrqsDqOEzykc1A3Qsys15v/CMED9hCD9HJ/ H39A== Sender: isar-users@googlegroups.com X-Forwarded-Encrypted: i=2; AFNElJ8/iNq+ppMSyPTTXmPWcqXgbPE+RqenmhG03O4ZQk0jm2rFAxdKTJGEolWFVcKdDc7mb+Jr@ilbers.de X-Gm-Message-State: AOJu0YwnSYr2E9ZEqdkkOeM4JctoYFjRsXp2yg3sPORjSPbdb3cUOBng LmJXYKQ5qnkFcr4Q3oLMGhfLsRshUQ5TF/WOACGVJWKPhlj0Bq5Fm/AG X-Received: by 2002:a05:6402:458e:b0:683:f485:c63c with SMTP id 4fb4d7f45d1cf-6889c4321c4mr2027554a12.1.1779460158583; Fri, 22 May 2026 07:29:18 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com; h="AUV6zMMGN7YKr4H9nPlS7VYVU5d+Qdh51tmMH4cjSI4d9Jbxqg==" Received: by 2002:aa7:d48b:0:b0:672:f72:23ae with SMTP id 4fb4d7f45d1cf-6833038a3d3ls10271898a12.1.-pod-prod-03-eu; Fri, 22 May 2026 07:29:16 -0700 (PDT) X-Forwarded-Encrypted: i=2; AFNElJ9y4BZgEWFunIy0a2Sam46ucoSvti3jExSsKAqNY578OILJoR06kS7dBeghO2mPaRIrm7kn3ifbTt75@googlegroups.com X-Received: by 2002:a17:907:75dc:b0:bd5:27b7:adaf with SMTP id a640c23a62f3a-bdd272cf2efmr193285866b.33.1779460156355; Fri, 22 May 2026 07:29:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1779460156; cv=none; d=google.com; s=arc-20240605; b=Jwv9mWrMCkej9ZplkVHDC3RYJKzbnUUNDjZ1y/hQ90xqmknzVL4bUjtsMdVYJ+8/ho gh7pZUAQPPzo3oXFnjZ5e/lBLfL5QztpMflTFAtPNmTsUJnAYBcQSTrzagbdpwPaDyWK vUYNbf7t1h5UN9LopGFjwayUCf6g16W+SVjtfEwtygRAMTV1htWkEnsnMzu7EPSHHeLX VMrcu32uNP8NHUN4ZKyC04eYLXM7LkcU4tB2zcyZbOUbINxJlPCr6InOeKHKookMb5VG qZCem9dLadwEOhtLJa31dlEGl3IQI4fDjlZkIW2j4Y/d6Dg2xUYcPl3aoTb821Porbr0 mHxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id; bh=dolfO0K0J4wqlL+JD8Ks29DDcFES76nJoing0KVWqaE=; fh=RvCnPT+1m1e50cqHb+CxlVfdmvtK4TKvM16y3FVCFbo=; b=RbWvQykKOmR9ZVpIeU/FNTM4639pBM6RzpuUTGWcbzYM4zhLMXUlAMxIsrCLJgMduy Lje0ZWBgf1UORSbci0tEoZfAgvBD8jHkv3KQelwcq7/sHBqX4OV5p10ZH2Hv7ywpcb/3 yemdBjtsqvE+CoKnJL1pI1Orb8A/2fGH2xeMVLb9rbKC/F2Pgpup73ykcICQRUQPj/w+ D6w2CmX7cc24/iXTFrtKvnWrF5uqVHYmPy+Y6wqEjQZuZgQhlksOx1dxwWVNb87Rep89 Yq8vYOw1KqdI14VgByZuRU9/2PFv7MLudsnPqMIfP430K090tKAPJegxgwpRKDBr00l/ fm0A==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=wzh@ilbers.de Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id a640c23a62f3a-bddc2461138si3437366b.1.2026.05.22.07.29.16 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 22 May 2026 07:29:16 -0700 (PDT) Received-SPF: pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Received: from [192.168.178.148] ([88.130.203.42]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 64METFEl005596 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 22 May 2026 16:29:15 +0200 Message-ID: <2d686c47-a66e-4dbf-9741-d1d7303951e2@ilbers.de> Date: Fri, 22 May 2026 16:29:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] repository: default Priority to optional when field is absent To: srinuvasan.a@siemens.com, isar-users@googlegroups.com Cc: amikan@ilbers.de, Cedric Hombourger References: <20260515100236.671593-1-srinuvasan.a@siemens.com> <20260515101246.671704-1-srinuvasan.a@siemens.com> Content-Language: en-US From: Zhihang Wei In-Reply-To: <20260515101246.671704-1-srinuvasan.a@siemens.com> Content-Type: text/plain; charset="UTF-8"; format=flowed X-Spam-Status: No, score=-4.6 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2, RCVD_IN_RP_CERTIFIED,RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-Original-Sender: wzh@ilbers.de X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=wzh@ilbers.de Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-TUID: EA7l/BqtFd8a Applied to next, thanks. Zhihang On 5/15/26 12:12, srinuvasan.a via isar-users wrote: > From: Srinuvasan A > > Some upstream packages omit the Priority field from their binary .deb > metadata. reprepro rejects such packages with "No priority given", > aborting repository construction. > > This was observed with a base-apt build that include upstream packages > such as gir1.2-javascriptcoregtk-4.1. Both base-apt and isar-apt use > the repository class. Fix repo_add_packages() to detect a missing > Priority field and fall back to "optional", matching the Debian policy > default. > > Add a test recipe (test-nopriority) that explicitly strips the > Priority field before build, and a citest.py test case that exercises > the isar-apt repository path with this recipe, covering the same > failure mode as the base-apt case. > > Signed-off-by: Srinuvasan A > Signed-off-by: Cedric Hombourger > --- > .../test-nopriority/test-nopriority.bb | 15 +++++++++++++++ > meta/classes-recipe/repository.bbclass | 15 ++++++++++++--- > testsuite/citest.py | 17 +++++++++++++++++ > 3 files changed, 44 insertions(+), 3 deletions(-) > create mode 100644 meta-test/recipes-app/test-nopriority/test-nopriority.bb > mode change 100755 => 100644 testsuite/citest.py > > diff --git a/meta-test/recipes-app/test-nopriority/test-nopriority.bb b/meta-test/recipes-app/test-nopriority/test-nopriority.bb > new file mode 100644 > index 00000000..dfccffd1 > --- /dev/null > +++ b/meta-test/recipes-app/test-nopriority/test-nopriority.bb > @@ -0,0 +1,15 @@ > +# This software is a part of Isar. > +# Copyright (C) 2026 Siemens AG > +# > +# SPDX-License-Identifier: MIT > + > +# Test that a .deb without a Priority field can be added to the repository. > +# The debianize class sets Priority in the Source stanza of debian/control; > +# we strip it here so the resulting .deb has no Priority metadata, exercising > +# the prio_opt fallback in repository.bbclass. > + > +inherit dpkg-raw > + > +do_prepare_build:append() { > + sed -i '/^Priority:/d' ${S}/debian/control > +} > diff --git a/meta/classes-recipe/repository.bbclass b/meta/classes-recipe/repository.bbclass > index a5dd8bbc..ba2803ad 100644 > --- a/meta/classes-recipe/repository.bbclass > +++ b/meta/classes-recipe/repository.bbclass > @@ -61,14 +61,23 @@ repo_add_packages() { > local dir="$1" > local dbdir="$2" > local codename="$3" > + local package > + local priority > + local prio_opt > shift; shift; shift > > if [ -n "${GNUPGHOME}" ]; then > export GNUPGHOME="${GNUPGHOME}" > fi > - reprepro -b "${dir}" --dbdir "${dbdir}" -C main \ > - includedeb "${codename}" \ > - "$@" > + for package in "$@"; do > + prio_opt="" > + priority=$(dpkg-deb -f "${package}" Priority 2>/dev/null || true) > + if [ -z "${priority}" ]; then > + prio_opt="-P optional" > + fi > + reprepro -b "${dir}" --dbdir "${dbdir}" -C main ${prio_opt} \ > + includedeb "${codename}" "${package}" > + done > } > > repo_del_srcpackage() { > diff --git a/testsuite/citest.py b/testsuite/citest.py > old mode 100755 > new mode 100644 > index b3866675..a051ce54 > --- a/testsuite/citest.py > +++ b/testsuite/citest.py > @@ -131,6 +131,23 @@ class CompatTest(CIBaseTest): > self.perform_build_test(targets, compat_arch=True) > > > +class RepositoryTest(CIBaseTest): > + """ > + Test repository functionality. > + :avocado: tags=repository,fast > + """ > + > + def test_repository_nopriority(self): > + """Test that packages without a Priority field can be added to the repo.""" > + targets = [ > + 'mc:qemuamd64-bookworm:isar-image-ci', > + ] > + > + self.init() > + self.perform_build_test(targets, > + image_install='test-nopriority') > + > + > class SbuildFlavor(CIBaseTest): > """ > Test package build with a custom sbuild chroot. -- You received this message because you are subscribed to the Google Groups "isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/2d686c47-a66e-4dbf-9741-d1d7303951e2%40ilbers.de.