From: vijai kumar <vijaikumar.kanagarajan@gmail.com>
To: isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH] meta: Replace no longer available bb.build.FuncFailed
Date: Tue, 18 Feb 2020 23:38:23 -0800 (PST) [thread overview]
Message-ID: <2e0645f0-c397-48c0-b741-988f16a05384@googlegroups.com> (raw)
In-Reply-To: <94d92943-ea75-bda6-1b07-56440856eb14@siemens.com>
[-- Attachment #1.1: Type: text/plain, Size: 2000 bytes --]
My patch[1] exactly addresses this :)
[1] https://groups.google.com/forum/#!topic/isar-users/ZAAKFICAbLA
Thanks,
Vijai Kumar K
On Wednesday, February 19, 2020 at 12:47:05 PM UTC+5:30, Jan Kiszka wrote:
>
> From: Jan Kiszka <jan....@siemens.com <javascript:>>
>
> Follow the pattern in oe-core and issue bb.fatal instead.
>
> Signed-off-by: Jan Kiszka <jan....@siemens.com <javascript:>>
> ---
> meta/classes/base.bbclass | 4 ++--
> meta/classes/dpkg-base.bbclass | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
> index e233164c..b7de921a 100644
> --- a/meta/classes/base.bbclass
> +++ b/meta/classes/base.bbclass
> @@ -171,7 +171,7 @@ python do_fetch() {
> fetcher = bb.fetch2.Fetch(src_uri, d)
> fetcher.download()
> except bb.fetch2.BBFetchException as e:
> - raise bb.build.FuncFailed(e)
> + bb.fatal(str(e))
> }
>
> addtask fetch before do_build
> @@ -190,7 +190,7 @@ python do_unpack() {
> fetcher = bb.fetch2.Fetch(src_uri, d)
> fetcher.unpack(rootdir)
> except bb.fetch2.BBFetchException as e:
> - raise bb.build.FuncFailed(e)
> + bb.fatal(str(e))
> }
>
> addtask unpack after do_fetch before do_build
> diff --git a/meta/classes/dpkg-base.bbclass
> b/meta/classes/dpkg-base.bbclass
> index 1decf587..5d2c161c 100644
> --- a/meta/classes/dpkg-base.bbclass
> +++ b/meta/classes/dpkg-base.bbclass
> @@ -42,7 +42,7 @@ python do_adjust_git() {
> if subprocess.call(cmd) != 0:
> bb.fatal("git alternates adjustment failed")
> except bb.fetch2.BBFetchException as e:
> - raise bb.build.FuncFailed(e)
> + bb.fatal(str(e))
> }
>
> addtask adjust_git after do_unpack before do_patch
> --
> 2.16.4
>
>
> --
> Siemens AG, Corporate Technology, CT RDA IOT SES-DE
> Corporate Competence Center Embedded Linux
>
[-- Attachment #1.2: Type: text/html, Size: 2862 bytes --]
next prev parent reply other threads:[~2020-02-19 7:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 7:17 Jan Kiszka
2020-02-19 7:38 ` vijai kumar [this message]
2020-02-19 7:39 ` Jan Kiszka
2020-02-20 10:27 ` Henning Schild
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e0645f0-c397-48c0-b741-988f16a05384@googlegroups.com \
--to=vijaikumar.kanagarajan@gmail.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox