Re: [PATCH] dpkg: Account for empty local apt cache after package build

[Jan Kiszka <jan.kiszka@siemens.com>]

On 18.10.23 22:33, Klincov, Wadim (SMO SDT TEC SPA TPQ) wrote:
> On Wed, 2023-10-18 at 15:08 +0200, 'Jan Kiszka' via isar-users wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> A build dependency-free package combined with sstate caching and
>> cleared
>> deb cache can trigger
>>
>>> cp -Ln --no-preserve=owner /var/cache/apt/archives/*.deb -t
>>> /home/builder/example-raw/rootfs/var/cache/apt/archives/
>>> -------------------------------------------------------------------
>>> -------------------------------------------------
>>>
>>> cp: cannot stat '/var/cache/apt/archives/*.deb': No such file or
>>> directory
>>>
>>> E: Command 'cp -Ln --no-preserve=owner
>>> /var/cache/apt/archives/*.deb -t /home/builder/example-
>>> raw/rootfs/var/cache/apt/archives/' failed to run.
>>
>> Account for that.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>  meta/classes/dpkg.bbclass | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
>> index d89b0fd9..7249f32b 100644
>> --- a/meta/classes/dpkg.bbclass
>> +++ b/meta/classes/dpkg.bbclass
>> @@ -109,7 +109,7 @@ dpkg_runbuild() {
>>          --chroot-setup-commands="mkdir -p ${deb_dir}" \
>>          --chroot-setup-commands="ln -sf ${ext_deb_dir}/*.deb -t
>> ${deb_dir}/" \
>>          --finished-build-commands="rm -f ${deb_dir}/sbuild-build-
>> depends-main-dummy_*.deb" \
>> -        --finished-build-commands="cp -Ln --no-preserve=owner
>> ${deb_dir}/*.deb -t ${ext_deb_dir}/" \
>> +        --finished-build-commands="[ -n "$(find ${deb_dir} -maxdepth
>> 1 -name '*.deb' -print -quit)" ] && cp -Ln --no-preserve=owner
>> ${deb_dir}/*.deb -t ${ext_deb_dir}/" \
> Just tried it and it still fails due to the non-zero status of `-n` not
> getting caught. Maybe the previous `|| \:` or using find to copy
> directly might help?

Ah, indeed, missed that because my caches was non-empty again for the
test. v2 is on the way.

Thanks,
Jan

-- 
Siemens AG, Technology
Linux Expert Center