From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6739560601010307072 X-Received: by 2002:a1c:544e:: with SMTP id p14mr6291944wmi.72.1569404159004; Wed, 25 Sep 2019 02:35:59 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:eacc:: with SMTP id o12ls1921813wrn.5.gmail; Wed, 25 Sep 2019 02:35:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqy8xYGnOmfszaKJGrqnCER5IxGOMUZYDKjUl5EzOWCjAHkzThEZJpWcCjQ7oz+x4hLUb5Xa X-Received: by 2002:a5d:494d:: with SMTP id r13mr8223587wrs.166.1569404158446; Wed, 25 Sep 2019 02:35:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569404158; cv=none; d=google.com; s=arc-20160816; b=f/cGHMcHezt1JwVKgFhXGaw3N5ZaM/l1vST6eb0Tn3WtnZZV0qPHfyPpmp+p894jFx B4zMnp/gzwWvkmINvZlQ7ZEUi633u1vXaKTsfs9xlgxADEvpUKsB9x7hnzxjLt+RrCwy wQ0Fp1dHa5mzbuwKczQYxGlwBUVd9fgxglSFfJuiGzvBfXsWdK4/DvEiRiQ54+3RRC5v G9q1AO3Lagvl6otAzLoi9Yg3G80hepRvGfEH1Ds14H/Ex2SM5wXhhNd8BjwW/zSSR0Hs MK6yE+zZLAWfYsOBns09yNFRiDkxwRH7YVGEeWlyOGfV8YxVtglhk4SWqJwrlVHR+OlI mpUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:references:to:from:subject; bh=VAhM0lrzpJlMcdffxQVHTqdDzhPIza5ZRyqO9rh71kE=; b=K8oH04zK9xUnOdee3eO2DVdz4ZZqKJ178CComdevDDTlRtZPcx/f6q7beO2mDHnHeA zwM7OVCOtydG58w4XKttrV2AjqADZIw3JhxcHtsY1q+wT/o6y5DWxVNRLMO4XsBxJvpx yGMAyG6TEusWy8JgiUlRZR4IZXMQoqEellYVQeO0arXSRWep+7DyZ4mXcxJo/3C3mffq 8JgRecZdHdWKimWfuAyjd95Ps4hE1xzsgnQ1M/yZyonMrK0zvzxUl2XFiPnLFeHmoarz 6yy/fq3QZOg9WVHRWr4aTaDiSFIWXiAzaRjTBS5rYWpCFG/SiJz4Nsk3r+1W8CLfCeVb JM+g== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id q8si235878edn.5.2019.09.25.02.35.58 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Sep 2019 02:35:58 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id x8P9ZwYF024852 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 25 Sep 2019 11:35:58 +0200 Received: from [139.23.72.208] ([139.23.72.208]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x8P9ZvLL011556 for ; Wed, 25 Sep 2019 11:35:57 +0200 Subject: Re: [PATCH v5 00/27] Pending patches, fix for isar-bootstrap, devshell From: Jan Kiszka To: isar-users@googlegroups.com References: <20190923095026.3wqlycptrogbjocu@yssyq.m.ilbers.de> <5c7c8de8-fa74-3f25-4da6-87860a44dbe8@siemens.com> <20190923102337.g6nnnorsuq4rtpth@yssyq.m.ilbers.de> <5010413d-441a-f040-df08-db0be9640b62@siemens.com> <20190925084111.m4ifrrdlhwdbo5rh@yssyq.m.ilbers.de> <4afcdaab-c9fd-fa27-82af-1da1b3c750ea@siemens.com> <20190925092230.37iinm52lo2ggx4n@yssyq.m.ilbers.de> Message-ID: <2e518348-0cb8-6983-20bd-1d0ccdefed0f@siemens.com> Date: Wed, 25 Sep 2019 11:35:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: B0liI4V3HTK9 On 25.09.19 11:26, [ext] Jan Kiszka wrote: > On 25.09.19 11:22, Baurzhan Ismagulov wrote: >> On Wed, Sep 25, 2019 at 10:51:02AM +0200, Jan Kiszka wrote: >>>> I've added OVERRIDES_append = ":gnupg" to local.conf for the signed base-apt >>>> test case. ci_build "-f -r -s" worked, waiting for the complete test. >>> >>> IOW, we are missing a reason to add gnupg to the chroot when building from a >>> signed base-apt, right? >> >> In this wording, I'd say "no" since it doesn't seem to have been designed to >> append gnupg to debootstrap --include dynamically if we have custom keys. IMU, >> DISTRO_BOOTSTRAP_BASE_PACKAGES_append_gnupg = ",gnupg2" suggests that the user >> should add the OVERRIDES manually as well. Andreas? > > No, this is defined by get_distro_needs_gpg_support. > >> >> If that could be done implicitly, it would be better. However, in the current >> implementation, the keys are checked after debootstrap, so I haven't started >> shuffling stuff around. >> > > It's probably another condition to be added to that function. Checking... > I suspect this will fix the issue, but the test runs will take some time: diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc index 215c41b..991410a 100644 --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc @@ -169,6 +169,8 @@ def get_distro_needs_https_support(d, is_host=False): def get_distro_needs_gpg_support(d): apt_keys = d.getVar("DISTRO_BOOTSTRAP_KEYS") or "" apt_keys += " " + (d.getVar("THIRD_PARTY_APT_KEYS") or "") + if bb.utils.to_boolean(d.getVar('ISAR_USE_CACHED_BASE_REPO')): + apt_keys += " " + (d.getVar("BASE_REPO_KEY") or "") if apt_keys != " ": return "gnupg" return "" Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux