Re: [PATCH] meta: Add targz image class

[Jan Kiszka <jan.kiszka@siemens.com>]

On 20.11.18 12:50, Harald Seiler wrote:
> Signed-off-by: Harald Seiler <hws@denx.de>
> ---
>   meta/classes/targz-img.bbclass | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
>   create mode 100644 meta/classes/targz-img.bbclass
> 
> diff --git a/meta/classes/targz-img.bbclass b/meta/classes/targz-img.bbclass
> new file mode 100644
> index 0000000..898c2a8
> --- /dev/null
> +++ b/meta/classes/targz-img.bbclass
> @@ -0,0 +1,12 @@
> +# This software is a part of ISAR.

Missing copyright and license statement. That should be something like

# This software is a part of ISAR.
# Copyright (c) Siemens AG, 2018
#
# SPDX-License-Identifier: MIT

("Siemens" if this was part of our contract work)

> +
> +TARGZ_IMAGE_FILE = "${DEPLOY_DIR_IMAGE}/${IMAGE_FULLNAME}.tar.gz"
> +
> +do_targz_image[stamp-extra-info] = "${DISTRO}-${MACHINE}"
> +
> +do_targz_image() {
> +    rm -f ${TARGZ_IMAGE_FILE}
> +    sudo tar -cvzf ${TARGZ_IMAGE_FILE} -C ${IMAGE_ROOTFS} .

We need sudo in order to see files that are root-visible only, right?

> +}
> +
> +addtask targz_image before do_build after do_copy_boot_files
> 

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux