public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'Jan Kiszka' via isar-users" <isar-users@googlegroups.com>
To: Cedric Hombourger <cedric.hombourger@siemens.com>,
	isar-users@googlegroups.com
Subject: Re: [PATCH] image: allow multiple image recipes to deploy DTB_FILES
Date: Fri, 5 Jul 2024 09:37:49 +0200	[thread overview]
Message-ID: <2f1bad7a-5e81-468b-8c75-804e7cee1a49@siemens.com> (raw)
In-Reply-To: <20240705071856.904-1-cedric.hombourger@siemens.com>

On 05.07.24 09:18, 'Cedric Hombourger' via isar-users wrote:
> sstate is checking for overlapping files in DEPLOY_DIR and will
> raise an error when building a second image for a machine that
> uses DTB_FILES.
> 
> Reproducer:
>   bitbake mc:phyboard-mira-bookworm:isar-image-base
>   bitbake mc:phyboard-mira-bookworm:isar-image-debug
> 
> Signed-off-by: Cedric Hombourger <cedric.hombourger@siemens.com>
> ---
>  meta/classes/image.bbclass | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index c29d9e26..8b316c83 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -27,7 +27,11 @@ INITRD_IMAGE ?= ""
>  INITRD_DEPLOY_FILE = "${@ d.getVar('INITRD_IMAGE') or '${IMAGE_FULLNAME}-initrd.img'}"
>  
>  # This defines the deployed dtbs for reuse by imagers
> +# Since we may be building several images with the same set of DTB_FILES, silent sstate
> +# overlap checks
>  DTB_FILES ?= ""
> +DEPLOY_DTB_FILES = "${@ ' '.join(['${DEPLOY_DIR_IMAGE}/' + os.path.basename(dtb) for dtb in d.getVar('DTB_FILES').split()]) }"
> +SSTATE_ALLOW_OVERLAP_FILES += "${DEPLOY_DTB_FILES}"
>  
>  # Useful variables for imager implementations:
>  PP = "/home/builder/${PN}-${MACHINE}"

There is still
https://patchwork.isar-build.org/project/isar/list/?series=1209 pending
which looks much less risky to paper over a real conflict.

Jan

-- 
Siemens AG, Technology
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/2f1bad7a-5e81-468b-8c75-804e7cee1a49%40siemens.com.

  reply	other threads:[~2024-07-05  7:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-05  7:18 'Cedric Hombourger' via isar-users
2024-07-05  7:37 ` 'Jan Kiszka' via isar-users [this message]
2024-07-05  7:47   ` 'cedric.hombourger@siemens.com' via isar-users
2024-07-05  7:54     ` Uladzimir Bely
2024-07-05  7:55     ` 'Jan Kiszka' via isar-users
2024-07-05  9:55       ` 'cedric.hombourger@siemens.com' via isar-users
2024-07-11  8:52         ` 'cedric.hombourger@siemens.com' via isar-users
2024-07-11 10:54           ` 'Jan Kiszka' via isar-users

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f1bad7a-5e81-468b-8c75-804e7cee1a49@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=cedric.hombourger@siemens.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox