[PATCH] image: acquire lock when running do_cache_base_repo()

[PATCH] image: acquire lock when running do_cache_base_repo()

[Cedric Hombourger]

The base repository gets updated as images are built. As multiple
images may be built concurrently, accesses to the base cache repo
should be serialized by having do_cache_base_repo acquire the
following lock file: ${REPO_BASE_DIR}/isar.lock

Fixes: https://groups.google.com/forum/#!topic/isar-users/ElRP1h_9m9I
Signed-off-by: Cedric Hombourger <Cedric_Hombourger@mentor.com>
---
 meta/classes/image.bbclass | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index d8fbfd5..be00817 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -128,6 +128,7 @@ addtask populate_sdk after do_rootfs
 inherit base-apt-helper
 
 do_cache_base_repo[depends] = "base-apt:do_cache_config"
+do_cache_base_repo[lockfiles] = "${REPO_BASE_DIR}/isar.lock"
 do_cache_base_repo[stamp-extra-info] = "${MACHINE}-${DISTRO}"
 
 do_cache_base_repo() {
-- 
2.11.0

Re: [PATCH] image: acquire lock when running do_cache_base_repo()

[Maxim Yu. Osipov]

On 2/7/19 6:10 PM, Cedric Hombourger wrote:
> The base repository gets updated as images are built. As multiple
> images may be built concurrently, accesses to the base cache repo
> should be serialized by having do_cache_base_repo acquire the
> following lock file: ${REPO_BASE_DIR}/isar.lock

Applied to the 'next',

Thanks,
Maxim.

> Fixes: https://groups.google.com/forum/#!topic/isar-users/ElRP1h_9m9I
> Signed-off-by: Cedric Hombourger <Cedric_Hombourger@mentor.com>
> ---
>   meta/classes/image.bbclass | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index d8fbfd5..be00817 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -128,6 +128,7 @@ addtask populate_sdk after do_rootfs
>   inherit base-apt-helper
>   
>   do_cache_base_repo[depends] = "base-apt:do_cache_config"
> +do_cache_base_repo[lockfiles] = "${REPO_BASE_DIR}/isar.lock"
>   do_cache_base_repo[stamp-extra-info] = "${MACHINE}-${DISTRO}"
>   
>   do_cache_base_repo() {
> 


-- 
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov