From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6655307462908837888 X-Received: by 2002:a2e:9e41:: with SMTP id g1-v6mr466787ljk.22.1549612048989; Thu, 07 Feb 2019 23:47:28 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a19:d9db:: with SMTP id s88ls463730lfi.14.gmail; Thu, 07 Feb 2019 23:47:28 -0800 (PST) X-Google-Smtp-Source: AHgI3IZap5Z4WEZX/9vCRywVPAUgAhCqvnSK9iOjutLuA44mvUANUxyTJOyX4F/aeSA/YyJ8C9SR X-Received: by 2002:ac2:5215:: with SMTP id a21mr888407lfl.5.1549612048222; Thu, 07 Feb 2019 23:47:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549612048; cv=none; d=google.com; s=arc-20160816; b=CwWl///szO5rSsKaC9h8/lN5qAUs3dZSkuWQVclqr2LmHq6hz9PQlm0eouC3dwVadJ L7qI60XljEcc6fB3cTCiaF/3OJhzNW8JVBnyyPjq2o3zAo7v5jdNFfT8DHxXKo31wV4O A/U+QVBAFT69uLyO75iFB1Kvw2oWND2i//v3FVIcuAaYDtM+MnZbxORFIwWF04nmxMHm DpOMfC2RNLYb9rwG7pAECpMt1C0SDP+K+J4f1dD6cU2mnvsX62pozn0bu5yywQ+ynOdn 5gQgetVBUaqb+Z+mwYuN4NFR676B5bSnZg/Iu1XcqvzYPRTiesVCXijgI9odV6qWJAKd L8aA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:from:references:to:subject; bh=CIE5MY0XUNyIkFdTH2alDLwM8R519IHTZQ1sGy6Jf/4=; b=NpxTqFqZtVB9oohKi8/Dg1SYIaDE1QiIYiPOUiRyMqbqnytyFFZ93vq6i4189nL8G5 A+54uOK3mIkFX0DRN6vFeDLKv3UxUO1GCRIaxUK56iNZO2hc89VzgkQyj4JZ2ICfZuel njHqtm9713MFnF6wETDuaWyRzgBrUcmPirA7T3dJ7ldYqE7OKvxkUfhavslVkg9v0+mn 6CsTFcGVrGjbf06ZblyBJOPI5cHeHfOjDbIUxmm7eO1GvSZU1VBO1OtTT0QI4bhtocQF xdP/UJGv748iOWlCfOSekYC00Q0AiiIKUZZNJhWeVaDpN6zNtUENC6gp/nQtw0tIbq1n 7tfQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id m4si59132lfh.1.2019.02.07.23.47.27 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 07 Feb 2019 23:47:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Received: from [192.168.50.163] (d51a48a80.access.telenet.be [81.164.138.128]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id x187lQZq025545 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 8 Feb 2019 08:47:26 +0100 Subject: Re: [PATCH] image: acquire lock when running do_cache_base_repo() To: Cedric Hombourger , isar-users@googlegroups.com References: <1549559456-916-1-git-send-email-Cedric_Hombourger@mentor.com> From: "Maxim Yu. Osipov" Organization: ilbers GmbH Message-ID: <2f467373-16c4-967a-2c18-8b68bfff6b13@ilbers.de> Date: Fri, 8 Feb 2019 08:47:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <1549559456-916-1-git-send-email-Cedric_Hombourger@mentor.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: jJ/qolBSFAuy On 2/7/19 6:10 PM, Cedric Hombourger wrote: > The base repository gets updated as images are built. As multiple > images may be built concurrently, accesses to the base cache repo > should be serialized by having do_cache_base_repo acquire the > following lock file: ${REPO_BASE_DIR}/isar.lock Applied to the 'next', Thanks, Maxim. > Fixes: https://groups.google.com/forum/#!topic/isar-users/ElRP1h_9m9I > Signed-off-by: Cedric Hombourger > --- > meta/classes/image.bbclass | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass > index d8fbfd5..be00817 100644 > --- a/meta/classes/image.bbclass > +++ b/meta/classes/image.bbclass > @@ -128,6 +128,7 @@ addtask populate_sdk after do_rootfs > inherit base-apt-helper > > do_cache_base_repo[depends] = "base-apt:do_cache_config" > +do_cache_base_repo[lockfiles] = "${REPO_BASE_DIR}/isar.lock" > do_cache_base_repo[stamp-extra-info] = "${MACHINE}-${DISTRO}" > > do_cache_base_repo() { > -- Maxim Osipov ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn Germany +49 (151) 6517 6917 mosipov@ilbers.de http://ilbers.de/ Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov