From: "Schmidl, Tobias" <tobiasschmidl@siemens.com>
To: "isar-users@googlegroups.com" <isar-users@googlegroups.com>,
"jan.kiszka@siemens.com" <jan.kiszka@siemens.com>
Cc: "joe.macdonald@siemens.com" <joe.macdonald@siemens.com>
Subject: Re: [PATCH] expand-on-first-boot: Switch from resize2fs to systemd-growfs
Date: Wed, 25 May 2022 13:04:15 +0000 [thread overview]
Message-ID: <2f549cd2234e44f8fabb436b3620e7a9501229d5.camel@siemens.com> (raw)
In-Reply-To: <e14b46d8-8972-78eb-280d-3fab0705fe8e@siemens.com>
Hi all,
Am Mittwoch, dem 25.05.2022 um 14:47 +0200 schrieb Jan Kiszka:
>
> Just for the sake of completeness: Since which Debian version is this
> the case? I assume buster is fine, right? But stretch was not.
>
>
That's correct, it was introduced with v236 [1], so halfway between
stretch (v232) and buster (v241).
[1]:
https://github.com/systemd/systemd/blob/ec5e113f099a3078194ae5fe43f72f52f41fe76b/NEWS#L6515-L6524
> >
> > +if [ -x /lib/systemd/systemd-growfs ]; then
> > + MOUNT_POINT=$(findmnt "${LAST_PART}" -o target -n)
> > + if [ -z "$MOUNT_POINT" ]; then
> > + echo "Cannot find mount point for ${LAST_PART}"
> > + exit 1
> > + fi
> > + mount "${MOUNT_POINT}" || true
> > + /lib/systemd/systemd-growfs "${MOUNT_POINT}"
> > +else
> > + resize2fs "${LAST_PART}"
> > +fi
>
> I wonder if / how long we should keep the two paths...
>
That's a strategic decision - do we want to keep the possibility of non-
systemd systems open? Otherwise this script should IMHO add a runtime
dependency to systemd (>=236).
Kind regards,
Tobias
next prev parent reply other threads:[~2022-05-25 13:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 12:32 Tobias Schmidl
2022-05-25 12:47 ` Jan Kiszka
2022-05-25 12:57 ` Bezdeka, Florian
2022-05-25 13:03 ` Bezdeka, Florian
2022-05-25 13:04 ` Schmidl, Tobias [this message]
2022-05-25 13:08 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f549cd2234e44f8fabb436b3620e7a9501229d5.camel@siemens.com \
--to=tobiasschmidl@siemens.com \
--cc=isar-users@googlegroups.com \
--cc=jan.kiszka@siemens.com \
--cc=joe.macdonald@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox