From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Fri, 04 Oct 2024 10:36:15 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-oa1-f63.google.com (mail-oa1-f63.google.com [209.85.160.63]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 4948aDeg029829 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 4 Oct 2024 10:36:14 +0200 Received: by mail-oa1-f63.google.com with SMTP id 586e51a60fabf-27b732ecdaasf1237817fac.1 for ; Fri, 04 Oct 2024 01:36:14 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1728030967; cv=pass; d=google.com; s=arc-20240605; b=Zwxise6RyuPNBlNzy4EznHeyKr9hIwOxurL44XkmjU/53IofeI6Du/7vHwb92u3efm NrBKvXfZHVUlgJcKcnE8RPNtDmOyOoN5cvTtxcWqxc3ucDhv8eKqMz8S4BMMRSBJ9NRI ohmpPgTYQdyC8gwzCeaLxuO7qT4qvE3iufG87KZ5h2up09lleyAQZuK+hcErT+hzbfqd 5XUsu8KZQMUG9JWu/5SHJR07H95VLtozHNlSkDmsQGaqgzSPaH7qRszDnNRPKa+OfLnZ FbJWO7P3EjsTQaXKXxuUxDvcSo6Xo7ADbyNWH4dw6vjU332g2HT11ZQZrIA8wIfwZaD+ JBwQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:user-agent :content-transfer-encoding:autocrypt:references:in-reply-to:date:to :from:subject:message-id:sender:dkim-signature; bh=m0PnQQ53mcMhe46Li9hV5EUB0qqpYjcVMIZTpYq+Q38=; fh=xQRccjnNhBBBxhLupUQZVXkeiXHg8ihmtLBSlQUdRR0=; b=Xq+k7F9rXuVNHQgyAkozno6POdrUEBcazUdv0JYOii8SWo0YO1x+/KLxYKaAqGdLye 7AK12c08b0nJK9f3IUyKiJGBjUk2sW0ZqRGkSjBnJno5JbHa7xHfijea2X1CwlmSCTT2 y0hgMI7ScNzhTNzWw8ISTHKIMYvBK5SLeFfOTwkSeX9WawPK2jCLTjgcRPLxGXs77l0p 5wCmO2H3lPscIl3MhB0wLA2b5olkg9ovawGWQ8vJMGaSDAjIW3qzSagWvxwRA9WCGgDb u9jbsF4U7ADpk0ujbocnb4RR71l7VJUvrZz5so0CXgQALVDa46EA2mE/ZSumZhKTnysP k9XA==; darn=ilbers.de ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1728030967; x=1728635767; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:user-agent:content-transfer-encoding :autocrypt:references:in-reply-to:date:to:from:subject:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=m0PnQQ53mcMhe46Li9hV5EUB0qqpYjcVMIZTpYq+Q38=; b=ooOXF8BdiRoNjAkJrm6m6g9SI+ZNkgAJkWo3pdO8/RyDVemqNEt5E87sedmwPUW7Ud pN57tRLtvaGYHRfct3Ut05b6wDjODJCEu6wm+WWPjk9NngiAfq2Lnb70saxNH6a98dk9 dtbbmOnqu9sIllhcRZ89NVwUVG+IGBQiqkIkjOBwjBO3tAbBNGEQdJnEeMpYUetO4mtJ v1WapeXe3nXkKyF/vDuKjrc72px9ObfuvB8EUI3YqVgfNBZS/uYP/kPxfM/kzYPUC0EV lj8zc3jCAhQ+MnuVN7T+qYGqi7MppbrjsWXUw71f0vM9CtdGAvnAUvtJUbM/9a/rnshA Nu8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728030967; x=1728635767; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :user-agent:content-transfer-encoding:autocrypt:references :in-reply-to:date:to:from:subject:message-id:x-beenthere :x-gm-message-state:sender:from:to:cc:subject:date:message-id :reply-to; bh=m0PnQQ53mcMhe46Li9hV5EUB0qqpYjcVMIZTpYq+Q38=; b=chmD1/sXn+4nf4JK93KRSrIpe8x/fbAYjJw8G1l33YKGNMvIysSjdIVmjosmxq/EzA NR36jC/eW8qIcOTSySyIEhb11fZ4KpIeGpmuuaDZRKRSlMBOIYeRD9oBOPVFZdhAvKzw T+L7FectXyYPvXvKpum+k2vuUrVKrLkBGs1gAp41hBbGD7zIhY9UI2zY+IuLZ9Oaz6N9 twU4RHkuIbElTGMnigMosXR5j+fPQi8y6e+Ig2vpxIhIZTgK1pEi9KHvbzgSygkDm+Ab 5XO1gXcrGAX3ptHaHbluukC34yrFj3qjyRVy8yC7kyJrwfENIqwMFXWAriB2d5Wd8Bbf 510g== Sender: isar-users@googlegroups.com X-Forwarded-Encrypted: i=2; AJvYcCV3yTBvfCshLMrgYAyFKLtdU60YQEIviE7x4Jr7hTi22azagAmyDqTi0MLi9Q8O3Ljugt20@ilbers.de X-Gm-Message-State: AOJu0YyYOOux/XxikzPQCWMkzF2/BQ1do8H6LZVONiRZxJqqezUvlo7S peO393dLs4n69SOGm/WjYa7RIvBjXbgtGJZQfrmR/LfTDXTsWtwV X-Google-Smtp-Source: AGHT+IEakci8Kk+kwnpRnSrLpqWZMQeaQqeDJhPlskPQn3ZtTx2fUrira9KZbr+RHbnLWHIGlbY7/g== X-Received: by 2002:a05:6870:6589:b0:270:1eca:e9fd with SMTP id 586e51a60fabf-287c1d3fbe5mr1283796fac.3.1728030967522; Fri, 04 Oct 2024 01:36:07 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6870:6712:b0:25c:b2c1:8569 with SMTP id 586e51a60fabf-287a489e952ls123919fac.1.-pod-prod-04-us; Fri, 04 Oct 2024 01:36:06 -0700 (PDT) X-Received: by 2002:a05:6870:9129:b0:277:e2fb:4035 with SMTP id 586e51a60fabf-287c1e18eebmr1392281fac.27.1728030966238; Fri, 04 Oct 2024 01:36:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1728030966; cv=none; d=google.com; s=arc-20240605; b=JsjyCOCo5RsyDJtx2cd5eyQr+x8BaRrTOT1p9UTp1Dkh9UCugtedNkVIryDyKwEhOL PmD2+84yYkrtZ+VNrAy5Am4B4dZywmQ1SugrfAyC7eKSCznA9e/7MsY4Uu++6TuoWdB9 jxHUeN58d5r1ejfQXkFl2/m2Q96+W7O7Rubc1i225GrFiSoBcyThTohgkc2HmvbMx3WU St1N4GJ2VfK9LmVk7FEn3Wr/0siYhhqJpwb/pvSciQFLJyDTOC1qbSst6leQulqLH0RK ElsLY21M/P2ESHr2ZgTWwhIX3IBJrlaOxOXANcW7WUFSFHQOvjd5QyNpx2IA/ax2WeEc wc4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:to:from:subject:message-id; bh=giPWEvUhxPqywgbTVp7MOPJcrHVwNdpg0HTf+nbhCE8=; fh=7tclEdh7YbwSQowgJ6LNq720O7H5HTEaqj22NJWRE2E=; b=lK07cLFOwkiopCjSztPT4qtSScgkvpY0YkQLzHAX3TDLLZjcH2xUaSOmsK9a15ImTo nsjwWXfEM8jTZYQLX0FHuJ5wlQBM5Zv5b6QdHQvAbAy2QMqsA93L6ch1LM8J0FS18CPc BrPq8l9PibzmmpnbnSxzg/D1HDVfqWVyk1RHmS6u2AKkPh3xId3zW4KsL6HDStMk+B/b 6iDiJxiXafwtsrJpnBFrp0LGawqcYoo++bmyLjKT3a7qnYMpIPn4hjzRBvEWuHuoa/OS vvBHc1dy1YBTuN7edx+Q4C4de9SrrfMTLKn4/awRty8R6j4c4cqQdVzRxSbBAyvpp1DG nSRw==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id 006d021491bc7-5e7c0ea844esi148182eaf.1.2024.10.04.01.36.05 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 04 Oct 2024 01:36:05 -0700 (PDT) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Received: from [IPv6:::1] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 4948a2RT029820 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 4 Oct 2024 10:36:03 +0200 Message-ID: <2f9153f297dad825e45f01c577594dd59f6ee03a.camel@ilbers.de> Subject: Re: [PATCH v2] Fix linux-starfive build under sid From: Uladzimir Bely To: isar-users@googlegroups.com Date: Fri, 04 Oct 2024 11:36:01 +0300 In-Reply-To: <20241004082906.29224-1-ubely@ilbers.de> References: <20241004082906.29224-1-ubely@ilbers.de> Autocrypt: addr=ubely@ilbers.de; prefer-encrypt=mutual; keydata=mQENBGO2eUkBCACtT+T3OrPVSExBmqfgXT3lp9XcdxRzjYp26wezkgYjjBXaf36bxtaAf S471VoQtpar0RVeFfW7WDDdfX9ZclSj36zBQe+RVSJzoNoNQfjOXWuSHb5Z+cpAFtqBY4muxK4+ia IlLJd6CN3ejOsLHATtCeHHq8wi0z2T+KdLQO+wQRgo2hjj0Lp9pGTrKJry50HP/o7Vbdu14dOx2xq r8+wPc6SQbBIrcqaa4MqCQC00vQG7eXvo+k2MOw59FDdpMH0KR9mHgp3u/s4I+4YRBArukt9G9xz/ rsEFmxAIBC6N/a6Hzwg4puc91n7ABDsPg8Vp+X3MDraujN0dvR6OKVNtABEBAAG0IFVsYWR6aW1pc iBCZWx5IDx1YmVseUBpbGJlcnMuZGU+iQFOBBMBCAA4FiEEJqPNVhVGyk12Eh+PAUQYBM/2FkoFAm O2eUkCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQAUQYBM/2FkprlAgAmuna8Hm9EyoEtTl DBGDg6Zm4ZLp5ffvZBE946h92jepDrteoxsJ7pSzJVC2HmDLa4iZUao7lLLbDsUj5x45/iLJcqBZK k3YnAxP2r6a+kI+1VVQY1pxdG1nlJAbdNzoojm/qmezNPSrqni61KVMQKsXBCWhIjSXDSM9CsBj21 a+9qaVqfxovJGTn9lgrZO+xzKQNMKZeOouJlscVuFj21P0ww3/YENiU/nMeTSuYypO76mDtAd08Jo nc3yuHa9MJGei5ixN3wT+IrGR2aL2hdw2M6NgH7sYbL2Zi4ugD6RXHJai1Bh2yvFSVqSQ+M6QOInT 4ud7wslm1XRB065dXtA== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.0 (by Flathub.org) MIME-Version: 1.0 X-Spam-Status: No, score=-4.6 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2, RCVD_IN_RP_CERTIFIED,RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-Original-Sender: ubely@ilbers.de X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-TUID: baD25xUD0kuJ On Fri, 2024-10-04 at 11:17 +0300, Uladzimir Bely wrote: > The patch is taken from the linux kernel upstream >=3D 6.8. >=20 > Signed-off-by: Uladzimir Bely > --- > =C2=A0...oc-arguments-order-in-btrfs_ioctl_se.patch | 43 > +++++++++++++++++++ > =C2=A0.../linux/linux-starfive_6.6-visionfive2.bb=C2=A0=C2=A0 |=C2=A0 1 + > =C2=A02 files changed, 44 insertions(+) > =C2=A0create mode 100644 meta-isar/recipes-kernel/linux/files/0001-btrfs- > fix-kvcalloc-arguments-order-in-btrfs_ioctl_se.patch >=20 > Changes since v1 (Fix linux build under sid and trixie): >=20 > - Since we don't build linux-mainline/linux-phy kernels for > trixie/sid > apply kernel patch only for linux-starfive_6.6-visionfive2 target. >=20 > I additionally checked [1] for existing branches and can conclude: > =C2=A0- recent 6.6-based branch "JH7110_VisionFive2_upstream" is still > affected and requires the patch > =C2=A0- recent "starfive-tech/visionfive" is 6.10-based already includes > the fix, but using it leads to different build errors. Also, I'm not > sure if it properly supports "VisionFive2" board. >=20 > So, for now, the simplest way to fix build error we have in CI is to > just apply upstream patch. BTW, in case of using kas-isar images, this build error is currently masked by debootstrap one. Even recent kas-4.5 currently uses debootstrap version 1.0.28 that can't create trixie/sid rootfs. Since some of kas developers are also reading this, I could propose to update kas images to debootstrap/bookworm-backports version (1.0.134) that works fine. >=20 > [1] https://github.com/starfive-tech/linux >=20 > diff --git a/meta-isar/recipes-kernel/linux/files/0001-btrfs-fix- > kvcalloc-arguments-order-in-btrfs_ioctl_se.patch b/meta-isar/recipes- > kernel/linux/files/0001-btrfs-fix-kvcalloc-arguments-order-in- > btrfs_ioctl_se.patch > new file mode 100644 > index 00000000..afe09eab > --- /dev/null > +++ b/meta-isar/recipes-kernel/linux/files/0001-btrfs-fix-kvcalloc- > arguments-order-in-btrfs_ioctl_se.patch > @@ -0,0 +1,43 @@ > +From 6ff09b6b8c2fb6b3edda4ffaa173153a40653067 Mon Sep 17 00:00:00 > 2001 > +From: Dmitry Antipov > +Date: Thu, 21 Dec 2023 11:47:45 +0300 > +Subject: [PATCH] btrfs: fix kvcalloc() arguments order in > btrfs_ioctl_send() > + > +When compiling with gcc version 14.0.0 20231220 (experimental) > +and W=3D1, I've noticed the following warning: > + > +fs/btrfs/send.c: In function 'btrfs_ioctl_send': > +fs/btrfs/send.c:8208:44: warning: 'kvcalloc' sizes specified with > 'sizeof' > +in the earlier argument and not in the later argument [-Wcalloc- > transposed-args] > + 8208 |=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 sctx->clone_root= s =3D kvcalloc(sizeof(*sctx- > >clone_roots), > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^ > + > +Since 'n' and 'size' arguments of 'kvcalloc()' are multiplied to > +calculate the final size, their actual order doesn't affect the > result > +and so this is not a bug. But it's still worth to fix it. > + > +Signed-off-by: Dmitry Antipov > +Reviewed-by: David Sterba > +Signed-off-by: David Sterba > +--- > + fs/btrfs/send.c | 4 ++-- > + 1 file changed, 2 insertions(+), 2 deletions(-) > + > +diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c > +index 4e36550618e5..2d7519a6ce72 100644 > +--- a/fs/btrfs/send.c > ++++ b/fs/btrfs/send.c > +@@ -8205,8 +8205,8 @@ long btrfs_ioctl_send(struct inode *inode, > struct btrfs_ioctl_send_args *arg) > +=C2=A0 goto out; > +=C2=A0 } > +=20 > +- sctx->clone_roots =3D kvcalloc(sizeof(*sctx->clone_roots), > +- =C2=A0=C2=A0=C2=A0=C2=A0 arg->clone_sources_count + 1, > ++ sctx->clone_roots =3D kvcalloc(arg->clone_sources_count + 1, > ++ =C2=A0=C2=A0=C2=A0=C2=A0 sizeof(*sctx->clone_roots), > +=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 GFP_KERNEL); > +=C2=A0 if (!sctx->clone_roots) { > +=C2=A0 ret =3D -ENOMEM; > +--=20 > +2.45.2 > + > diff --git a/meta-isar/recipes-kernel/linux/linux-starfive_6.6- > visionfive2.bb b/meta-isar/recipes-kernel/linux/linux-starfive_6.6- > visionfive2.bb > index f4dd5c9a..a267241f 100644 > --- a/meta-isar/recipes-kernel/linux/linux-starfive_6.6- > visionfive2.bb > +++ b/meta-isar/recipes-kernel/linux/linux-starfive_6.6- > visionfive2.bb > @@ -8,6 +8,7 @@ require recipes-kernel/linux/linux-custom.inc > =C2=A0SRC_URI +=3D " \ > =C2=A0=C2=A0=C2=A0=C2=A0 > https://github.com/starfive-tech/linux/archive/${SRCREV}.tar.gz;downloadf= ilename=3Dlinux-starfive-${SRCREV}.tar.gz > =C2=A0\ > =C2=A0=C2=A0=C2=A0=C2=A0 > file://0001-riscv-efistub-Ensure-GP-relative-addressing-is-not-u.patch > =C2=A0\ > +=C2=A0=C2=A0=C2=A0 > file://0001-btrfs-fix-kvcalloc-arguments-order-in-btrfs_ioctl_se.patch > =C2=A0\ > =C2=A0=C2=A0=C2=A0=C2=A0 file://starfive2_extra.cfg" > =C2=A0SRCREV =3D "9fe004eaf1aa5b23bd5d03b4cfe9c3858bd884c4" > =C2=A0SRC_URI[sha256sum] =3D > "9eaf7659aa57e2c5b399b7b33076f1376ec43ef343680e0a57e0a2a9bef6c0ae" > --=20 > 2.45.2 >=20 --=20 Best regards, Uladzimir. --=20 You received this message because you are subscribed to the Google Groups "= isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to isar-users+unsubscribe@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/= isar-users/2f9153f297dad825e45f01c577594dd59f6ee03a.camel%40ilbers.de.