From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7117657722680508416 X-Received: by 2002:a17:907:608b:b0:725:f45:39be with SMTP id ht11-20020a170907608b00b007250f4539bemr46943048ejc.669.1657212848274; Thu, 07 Jul 2022 09:54:08 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6402:42c7:b0:43a:82dc:c2a2 with SMTP id i7-20020a05640242c700b0043a82dcc2a2ls3949933edc.3.gmail; Thu, 07 Jul 2022 09:54:07 -0700 (PDT) X-Google-Smtp-Source: AGRyM1u6XEGJn6ksZS1l3N+gaQDBhOzTyps9qvX52Vkn86E2Xli+u7hDSZEmB0fa0T2Q3N2mi7jo X-Received: by 2002:a05:6402:2911:b0:43a:2b8b:4c76 with SMTP id ee17-20020a056402291100b0043a2b8b4c76mr34011515edb.206.1657212847100; Thu, 07 Jul 2022 09:54:07 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1657212847; cv=pass; d=google.com; s=arc-20160816; b=wpzkkcrsJwxAjJMOq3ueiHV2Cv3Cwuxr11w9HKgphVrYDD7JdlkY8OR86oq6GIRP4a y+hD56NzAW7m3Mxb+sX3ntE3VMUrZKYXKgCbqLkrv3xCO/Chw47JMqz5wd5+c0rnsDoT cpbM3zuk8CA3MyqV0kRgf6BnuJ8nBlsVXdpt55W/H/ztUzBZo2phxS32WKx7pS87f+7W 8S8AFAtuoDeVHdVu2we7FVW0hn4jMCqLTorYUCrg9fU+TTCYqOjNzoKyVMGNBpqBjpHn HDLXvEzlJsYtDJcd72yYO585LeyGqYTTfeYy2ndmrC/mePh5LPwp1hdMI27vREq67mn9 s91A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :dkim-signature; bh=csKSDFQE5LZWRcJ3SPVR2s9x1Fjzw++f1uFSJzHOsaM=; b=ibTjqNrdtzJ4/R7DaADaR958X64oAexQ6Yn9l7pCqRMFOvtCP3MrtHS+bm6UYohmYD AHL7kbDveHHYF8Id1nibAE3mKbANUB7THKQJE7EFQ1lbSnRX446RLkXYPvXO+/c6x3K1 01inL9Bp67jeZ4enNDZL4kWZyq2QO79wjCEVZXt2NvbQIKTQBTC7DZxNO81B0Fy0SzEg qdvYos3U6OEjKDGoFTcb4amAB7/YZ78jfC6L1GklXLtDs6pwPjschzQ9nOBToZfwO7Fa 4FoB/eZR8fKcZ+NZFJPH8yvqA/iV8ZClypOzp3SmnJhuatI2Ogqsw/No2KADcDSZ5ENn /5TA== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=UsME7E1N; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.1.47 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10047.outbound.protection.outlook.com. [40.107.1.47]) by gmr-mx.google.com with ESMTPS id a22-20020a170906245600b0072695cb14f9si1237962ejb.0.2022.07.07.09.54.06 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Jul 2022 09:54:07 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.1.47 as permitted sender) client-ip=40.107.1.47; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=UsME7E1N; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.1.47 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oEO2YHnL4KIXOqfGLAR5BnzHzhQ0tX+J7I7ILrHIXzkLxrY58pSzOkyK7EyV+b208VuasNDNyZgZK+A//7i4LCBhoRK7tTEZAH9vF7mnyrMYLtULqVlpVa3qo2Y2tMMaDjIxTXPJ3vCNBi7YNnvrippRGOmvMrZOWuPVahhLoFUVtKq6aMMJzoSYJtm00squA9vICvSHJap9enPoj6NoEV+8ZyQIiYmT7xgP8V/diHHTuEekQb1SsmtdgR6ZHlCoKQWQzpvHvfo2Ja3Dc2+94eLt9aqJEu3LZDlrumoBtYw7FxS573/YEU6/F4PB43zC4WRVbZhCueShoy8YwTV1vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=csKSDFQE5LZWRcJ3SPVR2s9x1Fjzw++f1uFSJzHOsaM=; b=VAIu9BkkYQ4lGPZZrzgdoeZAiElR1DHltPwoGoU4k1i/b+CTsorRlx7QsXl0UljkAN5weJ4YgnYBSKpy8ybPJcmyRln9jS0Qud6z/h0s3fwNMPCV0HBjzGOWArO2L6vHXmA6SWDLdHHg25qJ/Bj6KWDCqWhNEr6SmFca6OpPL06hFoXiK5GuPcBaPxRWg+on7s5hfyPk2HOnEuHq7g696FaFRxrEvCzCQx8w4rSNcq9sOBovMmZ8CM62cuHWYbvqIVqfd3ZRmj0mP9rxkgrfNEaB/3RNn0q+iDb2EZFXUcTMzYt/d8QofSe2fFtOrEvJSz8N6OleuehsQKGHrYraZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 194.138.21.72) smtp.rcpttodomain=googlegroups.com smtp.mailfrom=siemens.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=siemens.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=csKSDFQE5LZWRcJ3SPVR2s9x1Fjzw++f1uFSJzHOsaM=; b=UsME7E1NY8R0nygVmQcTkt508e7D3gXRNEZwpuEfatp8WJVhd42GM5sl0cdhVR/s5YugSbAwXH4Ni1FoCgnFwmJYEU7Bv12L9h81yk2kKfL5+8n/1m3AGaT6MRDTCopWyIlErURFsyGKDCdDpgxwBNuku5Wd3bn72W0m0twWMoE7dBfORT8uUcgIZ/JplyVSOYF+TCvooc9LYxgQ+QFH+0Sx2Q9DMnPu9xfUc2C56AHcEaP0Wmq3ngcxZzmsfc5q9WchIfkG4vVLuNky8sHxK8JlzTcYCkTxwQ/vwGBkntWAUk4Wuv4F4GcVT37hoShBY0bZebltXPUgum2CGi79/w== Received: from SV0P279CA0065.NORP279.PROD.OUTLOOK.COM (2603:10a6:f10:14::16) by AM9PR10MB5007.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:3dc::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15; Thu, 7 Jul 2022 16:54:05 +0000 Received: from HE1EUR01FT041.eop-EUR01.prod.protection.outlook.com (2603:10a6:f10:14:cafe::5e) by SV0P279CA0065.outlook.office365.com (2603:10a6:f10:14::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.17 via Frontend Transport; Thu, 7 Jul 2022 16:54:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 194.138.21.72) smtp.mailfrom=siemens.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=siemens.com; Received-SPF: Pass (protection.outlook.com: domain of siemens.com designates 194.138.21.72 as permitted sender) receiver=protection.outlook.com; client-ip=194.138.21.72; helo=hybrid.siemens.com; pr=C Received: from hybrid.siemens.com (194.138.21.72) by HE1EUR01FT041.mail.protection.outlook.com (10.152.1.3) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Thu, 7 Jul 2022 16:54:05 +0000 Received: from DEMCHDC89XA.ad011.siemens.net (139.25.226.103) by DEMCHDC9SMA.ad011.siemens.net (194.138.21.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.9; Thu, 7 Jul 2022 18:54:04 +0200 Received: from [139.25.68.37] (139.25.68.37) by DEMCHDC89XA.ad011.siemens.net (139.25.226.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.9; Thu, 7 Jul 2022 18:54:04 +0200 Message-ID: <2f9332c2-ac3b-719c-e92f-466992e03d36@siemens.com> Date: Thu, 7 Jul 2022 18:54:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 1/2] linux-module: create S if not existing Content-Language: en-US To: Henning Schild , Felix Moessbauer CC: References: <20220707154634.3860434-1-felix.moessbauer@siemens.com> <20220707180014.77c03a53@md1za8fc.ad001.siemens.net> From: Jan Kiszka In-Reply-To: <20220707180014.77c03a53@md1za8fc.ad001.siemens.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-Path: jan.kiszka@siemens.com X-Originating-IP: [139.25.68.37] X-ClientProxiedBy: DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) To DEMCHDC89XA.ad011.siemens.net (139.25.226.103) X-TM-AS-Product-Ver: SMEX-14.0.0.3080-8.6.1018-26680.007 X-TM-AS-Result: No-10--19.564100-8.000000 X-TMASE-MatchedRID: Cc2Ao8tLfKA5QaOxwNGfvo9bHfxDWoibGnjuHJNyKRxweJDozYf4KzKE tjy6tQe+waUU9evdfcMmFX089bePLDCBjkkm6KKi1zmfJ2aPKtAVlVZBrluia4lSWYvdSPSYjWP 6asaL88U4WKr1PmPdtUAc6DyoS2rIGWtzbrhLRggB982VRgwFpiKEYwBLB2tebWsCUkrA4EnbLu vAgD3xvKFIbih0s/42UArJnwHoG3Qz8KjPsddejHnqmEftZ1J1c0V+BYKkBrEdZEkR8Y/meTImV mVRsC9Y33Nl3elSfsqZfoHtMdmkJeYjmPzvYjWRLxxHBMdDc7oy7wvC8Uc6HZ4CIKY/Hg3AtOt1 ofVlaoLUHQeTVDUrItRnEQCUU+jzjoczmuoPCq2UTGVAhB5EbQ== X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--19.564100-8.000000 X-TMASE-Version: SMEX-14.0.0.3080-8.6.1018-26680.007 X-TM-SNTS-SMTP: C173C14F3096C8A6AAE931EEAAF61228D275E4AA468DEC2660390068172E98FB2000:8 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2d7fa814-e3c4-4875-8039-08da60394d6d X-MS-TrafficTypeDiagnostic: AM9PR10MB5007:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pFIjv1n8EaJrhknAHqmPLf/D3FjoNBEkf1liFwH2kc+dv2JeQsXZQEigpYdgd8C8fTX/wLziaQe9F3QhEowc1UkIeAOgsINeKRxpVpCwf5ZvGsYwGLg+gsUkr3OdvKOTA5RtLj1E4APiinEFBpv6MvCK6EyVaIBA5TbDX9X/3zIWGngxXeLVEB2MDy6/Gccx5jineMMB8CkMqDV+mE9TWHMlV+duewVyeWuy+uTu8+bQimto7sdhIJoi90M4iGAajY3VutshPoi1Zk4V0xUe6JuitgghqSLTO5madSSzGZsjtLzQ9Zhi+OPi21ljTXmqU88/Z9QPWlGxIIJHsryFrHjm5eNkqhcz3IBk6tLe4brHrdmgfowD/286hs4IAq+CXTuq1Wm4iZY3cbu/310wfVbhAkXv0Stx7bgnfezjSvb4OXbLAYhVSZAT1iPv0c4rwOgkMOOmHXz7SzLDZcSg6HgocYDR0empEJ817G1IryMjoCoxNshVNKFuhqAIrctqICRSKk6Ov9RllFw8wW3kix5MLt5Tpk4mdAhLHq64yNm4Ng/q5Efw8hOoyJYZiCucJO6zGlQX6y1JP1SCr/Ag7wujhBJ144cmUBSCi1cIB3BH1W6Uj/yX/F9JsxLCsM7kqtDou8mL7oA57cEnmP/zL5Yu8t7sHPRtLW4tDbp4SvfZoj0G+gaCsix0NEhCJRBIRlDXcfrQNEDvj383NSVpODZ+YjkRFDqqPpsM9+Cv83VphhBb2MPVl8Mai3QN3M7rkfG+i3mTCW/B66LCi3UKibRcUefxvDe+glBx8iITOaXlP50VcgFoByoh05ZgJP5OM/S2cIFx+zoYOu9FARbTLPwmXsNUI0JTOk8oYagPSpQiLmDxDsHKjyDEHFdlRqxgd+J1/aFl44VXKDpDqc6ugUBnLL0nVRnnJvEb9SG5lYI= X-Forefront-Antispam-Report: CIP:194.138.21.72;CTRY:DE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:hybrid.siemens.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(376002)(39860400002)(346002)(136003)(396003)(46966006)(36840700001)(40470700004)(8676002)(70206006)(47076005)(2616005)(5660300002)(956004)(336012)(86362001)(8936002)(31686004)(82310400005)(40480700001)(478600001)(36756003)(41300700001)(2906002)(31696002)(186003)(70586007)(16526019)(26005)(4326008)(53546011)(82960400001)(81166007)(356005)(316002)(40460700003)(44832011)(16576012)(6636002)(82740400003)(6706004)(36860700001)(110136005)(3940600001)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2022 16:54:05.3952 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2d7fa814-e3c4-4875-8039-08da60394d6d X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38ae3bcd-9579-4fd4-adda-b42e1495d55a;Ip=[194.138.21.72];Helo=[hybrid.siemens.com] X-MS-Exchange-CrossTenant-AuthSource: HE1EUR01FT041.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR10MB5007 X-TUID: dcJEOCf73V/U On 07.07.22 18:00, Henning Schild wrote: > Am Thu, 7 Jul 2022 17:46:33 +0200 > schrieb Felix Moessbauer : > >> We copy the debian folder into S, but at do_prepare_build >> time S might not have been created yet. >> This patch makes sure that the directory is created if >> it does not exist. >> >> Signed-off-by: Felix Moessbauer >> --- >> meta/recipes-kernel/linux-module/module.inc | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/meta/recipes-kernel/linux-module/module.inc >> b/meta/recipes-kernel/linux-module/module.inc index >> 50acfe14..97eff294 100644 --- >> a/meta/recipes-kernel/linux-module/module.inc +++ >> b/meta/recipes-kernel/linux-module/module.inc @@ -28,6 +28,7 @@ >> TEMPLATE_FILES = "debian/control.tmpl \ debian/rules.tmpl" >> TEMPLATE_VARS += "KERNEL_NAME KERNEL_TYPE KERNEL_IMAGE_PKG >> KERNEL_HEADERS_PKG PN" >> +do_prepare_build[dirs] += "${S}" >> do_prepare_build() { >> cp -r ${WORKDIR}/debian ${S}/ > > A little weird but i know the module you write that for is weird on its > own ... nvidia. But what we do here is put packaging metadata into the > code, which should be there after unpack ... everything else is "weird" > ... no code no packaging needed. > > But hey it does not hurt. It is definitely weird and will lead to new error patterns when folks specify a wrong S value - did you check that? If a broken S will not silently generate a nop-recipe now, we can take this, but I would like to see more reasoning of the case where S is filled with code AFTER do_prepare_build. Jan -- Siemens AG, Technology Competence Center Embedded Linux