From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6523072403514327040 X-Received: by 10.223.155.196 with SMTP id e4mr203492wrc.2.1519034051205; Mon, 19 Feb 2018 01:54:11 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.223.198.76 with SMTP id u12ls919665wrg.13.gmail; Mon, 19 Feb 2018 01:54:10 -0800 (PST) X-Google-Smtp-Source: AH8x224dVxDzXsmMGfg5UFo5kGME6gxUI4v9nNdyXXid9dHFNzGQAr/+GR168BacFYERerf2O1Ra X-Received: by 10.223.197.204 with SMTP id v12mr1134783wrg.29.1519034050751; Mon, 19 Feb 2018 01:54:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519034050; cv=none; d=google.com; s=arc-20160816; b=bweaK+729cGUj94s3qRuLhx7hSP/QImMiQZOJ5L5XAUIAO4ft0HkHcDqF77MSMr+PK GqnqBj3XWTDt0V26QoYc5AHkzzah9k2LKRhAQRRAxqOwfY1+JrDHgzNbBaCkWNJqMEc4 cCSh3msUTrYkx6JwnmwCIz477mERpaMOyITusU84sa/cPeGsDVlavZ3LhNsU4T/4/V/D pJqOsZQur+CQo6djk+c0kLrBxJSyO9Zp6IcIQT4Moo4twz1zxuW6Bp7Sl7AK/nYNJJNU yECJeckd3eTsJaHMxxqJfd3RVFyplq8bwF2eAaAcX5S720sCki6dIK3hCh19j+6LbMjM JIjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=2YA/H10D+u0mtyQH/7gqsrrX2aqDLpO5AeYi6c2ltIw=; b=R1984B4dxMuvBVTIl/KM5bABTpFJ8zCbW7UUh2BPR5UbsAO3kQWrcT9YTprXptPiFX 6DqW/5hResGd7WUiJsF4WIyP+GPycZJJTZhzDHfhnkfl1c6WqySIueB98oGbqJoJ7NBq x37yHuay3cYy0e2JGdpDkTcLkkIOmicrU5/mzO3oSUrYB/tVS1kBGJElZ8trwARpVUl8 SbAC3Tb1DFCRJ14KR3Z+OBW9pu+5zcFyc5rT/lWcFju29b6Bg1a7tGwlp5vZXjFLPsrv RgG94h7nbdu6UGvBMPEpNdGXHHDbE+ArldPt+4vjbl7yrQ53uLQl1Z5hJyaZtyrv6rsj 5Y9g== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id c11si358352wrb.0.2018.02.19.01.54.10 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Feb 2018 01:54:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Received: from [10.0.2.15] ([188.227.110.165]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id w1J9s6M8030994 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Mon, 19 Feb 2018 10:54:09 +0100 Subject: Re: [PATCH 3/8] isar-events: Do not match on distro and arch To: Jan Kiszka , isar-users References: From: Alexander Smirnov Message-ID: <2fe1c09e-a28e-58c8-559b-135a7005584f@ilbers.de> Date: Mon, 19 Feb 2018 12:54:01 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: HUOTviiZiTQW On 02/16/2018 11:52 AM, Jan Kiszka wrote: > From: Jan Kiszka > > There might be operations in flight that are mounting more for a > particular $distro-$arch when the completion event arrives. Simply > trying to umount everything under the TMPDIR increases the chance to > catch them later, e.g. because we have to wait for some mount point to > become free. > > Signed-off-by: Jan Kiszka > --- > meta/classes/isar-events.bbclass | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/meta/classes/isar-events.bbclass b/meta/classes/isar-events.bbclass > index 68208f1..29c7437 100644 > --- a/meta/classes/isar-events.bbclass > +++ b/meta/classes/isar-events.bbclass > @@ -27,11 +27,9 @@ python isar_handler () { > > if isinstance(e, bb.event.BuildCompleted): > tmpdir = d.getVar('TMPDIR', True) > - distro = d.getVar('DISTRO', True) > - arch = d.getVar('DISTRO_ARCH', True) > > - if tmpdir and distro and arch: > - basepath = tmpdir + '/work/' + distro + '-' + arch > + if tmpdir: > + basepath = tmpdir + '/work/' It would be nice to comment your idea inline here. In general commit message already contains the description, but I assume that there could be lots of new commits for this file in the future. So it will be unnecessary complication to find these clues. :-) Alex