From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6615476053044363264 X-Received: by 2002:a19:e307:: with SMTP id a7-v6mr138365lfh.3.1540473698750; Thu, 25 Oct 2018 06:21:38 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:350e:: with SMTP id z14-v6ls760601ljz.25.gmail; Thu, 25 Oct 2018 06:21:38 -0700 (PDT) X-Google-Smtp-Source: AJdET5f1citQzXa393SkCVC0t5na8KruFoMVAvspS5wmOCgpGiDYibdPUNlTBk1Ey+ZHyRUDZUqj X-Received: by 2002:a2e:9cc2:: with SMTP id g2-v6mr150200ljj.18.1540473698073; Thu, 25 Oct 2018 06:21:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540473697; cv=none; d=google.com; s=arc-20160816; b=Z+3GmfTxLXTjTpbMT4rUiSEQX2z5CdI3ZOorp80XAaibkKl0IkrcKblBi+yd1KbKh3 6wh/AZpfq0DJ3HmVIwTUjQbgYaihODbdnYhik42wUwgMLoC5PKFaGx32BPaLb070mh5w OK+JApyk8qToBwtt+A6rAURfI6G0OKH6PrLy9QcqUXskMX+20eclPoRBRp+FQrQvq+cQ 5FM8Rg2UGG/DIUNAdhODwJXnczmLtwIaPPmEj06LrrQQvAUt13seZvZD0qu5TBY0JbrZ U7zj/oRvW9pR7AfS+i6hr9lmX1JWX3NQjBsLGNnXkOXoIcWRLIrrLMazenj+xygtBIqB K75g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=X6M4QeyFltqI4PHtBhKUpOalmc7bteUlFMC82z5PZX0=; b=WwD2SOt4XxVs3T0rzPwUPsZTtJboRXgL5lNNE8enc27bRLtEbLWviKOQyT5Rw5An3s aBjxt3f2zQROjgh+UGIH6kaeo/gL3Uoal5hT7jBc1ChfVFGItQf1je1zfLvJme2FFi5m 8QTyndJlMlv5cTx+ApP3QHh3sBOv18CiQdXH+zxt0OEB1nvH/x+BBLABEGvbPFftyY36 GTWKAd1D2NEsx9oTvwwM4mgZLc4TxD/iH2YSyh9d7U8QHK427YKwtfkPQm3otAIfpQKO GJ+9xcS3hLm23hJ6EZZsvrUbj4SZ02OvicEp0DZbh9xwKExtngJknKMgc9gqycSsCCmT JjJg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id u142-v6si78293lja.2.2018.10.25.06.21.37 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Oct 2018 06:21:37 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id w9PDLYjR021763 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 25 Oct 2018 15:21:35 +0200 Received: from [167.87.14.128] ([167.87.14.128]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id w9PDLXhZ019792; Thu, 25 Oct 2018 15:21:34 +0200 Subject: Re: DISTRO is set too late To: Harald Seiler , "Maxim Yu. Osipov" , isar-users@googlegroups.com References: <56972bf2e66e3d979a1ce1c332594fee59e4ba8f.camel@denx.de> <485248d7-c66f-8d84-093c-1b74c90dfe8d@ilbers.de> <21866f1be8507deb16d968b3d209656327d5eb4c.camel@denx.de> <84dbc16b-4273-07f3-846d-88a2aab1848c@ilbers.de> From: Jan Kiszka Message-ID: <30bb5a44-53ee-90fd-7740-27111ff01b83@siemens.com> Date: Thu, 25 Oct 2018 14:21:32 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: lM6FkEF00Eqi On 23.10.18 13:37, Harald Seiler wrote: > On Tue, 2018-10-23 at 14:34 +0300, Maxim Yu. Osipov wrote: >> On 10/23/18 1:10 PM, Harald Seiler wrote: >>> On Tue, 2018-10-23 at 12:48 +0300, Maxim Yu. Osipov wrote: >>>> Hi Harald, >>>> >>>> The list of supported distros is under isar/meta-isar/conf/distro/*.conf >>>> (debian-wheezy is officially not supported but still present for >>>> convenience). >>> >>> We are using `debian-stretch`. If I add >>> >>> DISTRO = "debian-stretch" >>> >>> to `local.conf`, I can build. But this should not be necessary as >>> $DISTRO is also set from multiconf. The issue is that this happens >>> too late, so when $DISTRO_SUITE is expanded, it hasn't happened yet. >>> >>>> How did you get the value `poky` for DISTRO in your environment? >>> >>> Hmm, apparently this is kas adding >>> >>> DISTRO ??= "poky" >>> >>> to `local.conf` if no distro is supplied in its config. This should, >>> again, not be an issue, because the multiconf sets >>> >>> DISTRO ?= "debian-stretch" >>> >>> What seems to go wrong is that the multiconf is read too late, so >>> that base-apt-helper.bb tries to expand $DISTRO before is has gotten >>> its final value. I don't think this is the intended behavior ... >>> >> >> I don't use kas. >> >> I've ran `bitbake -e multiconfig:qemuarm-stretch:isar-image-base` and >> DISTRO/DISTRO_SUITE are expanded properly: >> >> # $DISTRO [2 operations] >> # set /home/myo/work/isar/src/trunk/isar/build/conf/local.conf:30 >> # [_defaultval] "debian-stretch" >> # set? >> /home/myo/work/isar/src/trunk/isar/meta-isar/conf/multiconfig/qemuarm-stretch.conf:6 >> # "debian-stretch" >> # pre-expansion value: >> # "debian-stretch" >> DISTRO="debian-stretch" >> >> ... >> >> # >> # $DISTRO_SUITE >> # set? >> /home/myo/work/isar/src/trunk/isar/meta/classes/base-apt-helper.bbclass:5 >> # "${@ d.getVar('DISTRO', True).split('-')[1]}" >> DISTRO_SUITE="stretch" >> >> >> >> If I set in local.conf >> >> DISTRO ??= "debian-jessie" >> >> DISTRO/DISTRO_SUITE are also expanded properly: >> >> # $DISTRO [2 operations] >> # set /home/myo/work/isar/src/trunk/isar/build/conf/local.conf:30 >> # [_defaultval] "debian-jessie" >> # set? >> /home/myo/work/isar/src/trunk/isar/meta-isar/conf/multiconfig/qemuarm-stretch.conf:6 >> # "debian-stretch" >> # pre-expansion value: >> # "debian-stretch" >> DISTRO="debian-stretch" >> >> ... >> >> # >> # $DISTRO_SUITE >> # set? >> /home/myo/work/isar/src/trunk/isar/meta/classes/base-apt-helper.bbclass:5 >> # "${@ d.getVar('DISTRO', True).split('-')[1]}" >> DISTRO_SUITE="stretch" > > I did a little more testing. Apparently, it works fine if the weak default value > contains at least one `-`. The rest of the value can be anything (though I do get > some warnings if it is not a valid distro). > > So this works: > > DISTRO ??= "invalid-distro" > > But this doesn't: > > DISTRO ??= "invalid_distro" > > I didn't dig into all details, and maybe this is actually resolving the issue better, but I had to fix a similar issue with my kas-driven layer lik this: https://github.com/siemens/jailhouse-images/commit/e595c6d62ddc6e8a608b199dc767dab9bc12f216 Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux