ISAR_REBUILD_ESSENTIAL_PKGS - upgrade packages present in isar-bootstrap

ISAR_REBUILD_ESSENTIAL_PKGS - upgrade packages present in isar-bootstrap

[cedric.hombourger]

Hello Adriaan, Uladzimir,

ISAR_REBUILD_ESSENTIAL_PKGS (as I understand it) injects dependencies to 
all non-essential recipes to make sure such packages are built first.

Wouldn't we also need to upgrade them when we bootstrap the image?

For example, if my layer ships a customized recipe for the base-files 
package, we would want my custom version to be in the image, not Debian's.

I can prepare an example to support the discussion if needed.

Thanks
Cedric

Re: ISAR_REBUILD_ESSENTIAL_PKGS - upgrade packages present in isar-bootstrap

[Jan Kiszka]

On 11.10.23 09:05, 'cedric.hombourger@siemens.com' via isar-users wrote:
> Hello Adriaan, Uladzimir,
> 
> ISAR_REBUILD_ESSENTIAL_PKGS (as I understand it) injects dependencies to 
> all non-essential recipes to make sure such packages are built first.
> 
> Wouldn't we also need to upgrade them when we bootstrap the image?
> 
> For example, if my layer ships a customized recipe for the base-files 
> package, we would want my custom version to be in the image, not Debian's.
> 
> I can prepare an example to support the discussion if needed.

This used to be ensured by performing an update/upgrade for all packages
coming from isar-apt. Can you demonstrate that this is no longer the case?

Jan

-- 
Siemens AG, Technology
Linux Expert Center

Re: ISAR_REBUILD_ESSENTIAL_PKGS - upgrade packages present in isar-bootstrap

[cedric.hombourger]

On 11/10/2023 10:27, Jan Kiszka wrote:
> On 11.10.23 09:05, 'cedric.hombourger@siemens.com' via isar-users wrote:
>> Hello Adriaan, Uladzimir,
>>
>> ISAR_REBUILD_ESSENTIAL_PKGS (as I understand it) injects dependencies to
>> all non-essential recipes to make sure such packages are built first.
>>
>> Wouldn't we also need to upgrade them when we bootstrap the image?
>>
>> For example, if my layer ships a customized recipe for the base-files
>> package, we would want my custom version to be in the image, not Debian's.
>>
>> I can prepare an example to support the discussion if needed.
> This used to be ensured by performing an update/upgrade for all packages
> coming from isar-apt. Can you demonstrate that this is no longer the case?

Yes that's what I was hoping. I don't know if I missing something 
obvious. Here's a (public) git repo that may be used to demonstrate the 
problem: https://github.com/chombourger/test-isar-essential-package

I used the following grep command to check which version of my 
customized base-files package ended-up in the image:

grep base-files 
build/tmp/deploy/images/qemuamd64/isar-image-base-debian-bookworm-qemuamd64.manifest

I noticed that an explicit IMAGE_PREINSTALL:append = " base-files" 
caused the version to be upgraded. Is that expected? Should we make such 
a suggestion in the documentation?

I should also note that ISAR_REBUILD_ESSENTIAL_PKGS does not seem to add 
dependencies between image recipes and essential packages (I had to add 
base-files to DEPENDS to get it built)

Thanks!

> Jan
>

Re: ISAR_REBUILD_ESSENTIAL_PKGS - upgrade packages present in isar-bootstrap

[Jan Kiszka]

On 11.10.23 23:00, Hombourger, Cedric (DI SW CAS ES LI) wrote:
> On 11/10/2023 10:27, Jan Kiszka wrote:
>> On 11.10.23 09:05, 'cedric.hombourger@siemens.com' via isar-users wrote:
>>> Hello Adriaan, Uladzimir,
>>>
>>> ISAR_REBUILD_ESSENTIAL_PKGS (as I understand it) injects dependencies to
>>> all non-essential recipes to make sure such packages are built first.
>>>
>>> Wouldn't we also need to upgrade them when we bootstrap the image?
>>>
>>> For example, if my layer ships a customized recipe for the base-files
>>> package, we would want my custom version to be in the image, not Debian's.
>>>
>>> I can prepare an example to support the discussion if needed.
>> This used to be ensured by performing an update/upgrade for all packages
>> coming from isar-apt. Can you demonstrate that this is no longer the case?
> 
> Yes that's what I was hoping. I don't know if I missing something 
> obvious. Here's a (public) git repo that may be used to demonstrate the 
> problem: https://github.com/chombourger/test-isar-essential-package
> 
> I used the following grep command to check which version of my 
> customized base-files package ended-up in the image:
> 
> grep base-files 
> build/tmp/deploy/images/qemuamd64/isar-image-base-debian-bookworm-qemuamd64.manifest
> 
> I noticed that an explicit IMAGE_PREINSTALL:append = " base-files" 
> caused the version to be upgraded. Is that expected? Should we make such 
> a suggestion in the documentation?

Yeah, right, that is still needed. I wonder if we should auto-upgrade
the schroots when ISAR_REBUILD_ESSENTIAL_PKGS is non-empty.

> 
> I should also note that ISAR_REBUILD_ESSENTIAL_PKGS does not seem to add 
> dependencies between image recipes and essential packages (I had to add 
> base-files to DEPENDS to get it built)

That should work: essential.bbclass is inherited by image.bbclass, and
it adds dependencies to do_install_rootfs.

Jan

-- 
Siemens AG, Technology
Linux Expert Center