From: Uladzimir Bely <ubely@ilbers.de>
To: Anton Mikanovich <amikan@ilbers.de>, isar-users@googlegroups.com
Subject: Re: [PATCH] CI: End the last target with comma
Date: Wed, 02 Aug 2023 07:07:41 +0300 [thread overview]
Message-ID: <31e4e2baaf8d50bad2580df60d6d6c8c193ac6ba.camel@ilbers.de> (raw)
In-Reply-To: <20230719102219.898352-1-amikan@ilbers.de>
On Wed, 2023-07-19 at 13:22 +0300, Anton Mikanovich wrote:
> Add commas to the last target in the list for better maintainability.
>
> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> ---
> testsuite/citest.py | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/testsuite/citest.py b/testsuite/citest.py
> index c706abe0..8253bd52 100755
> --- a/testsuite/citest.py
> +++ b/testsuite/citest.py
> @@ -29,7 +29,7 @@ class DevTest(CIBaseTest):
> 'mc:qemuamd64-bullseye:isar-image-ci',
> 'mc:qemuarm-bullseye:isar-image-base',
> 'mc:qemuarm-bullseye:isar-image-base:do_populate_sdk',
> - 'mc:qemuarm64-bullseye:isar-image-base'
> + 'mc:qemuarm64-bullseye:isar-image-base',
> ]
>
> self.init()
> @@ -38,7 +38,7 @@ class DevTest(CIBaseTest):
> def test_dev_apps(self):
> targets = [
> 'mc:qemuamd64-bullseye:isar-image-ci',
> - 'mc:qemuarm64-bullseye:isar-image-base'
> + 'mc:qemuarm64-bullseye:isar-image-base',
> ]
>
> self.init()
> @@ -82,7 +82,7 @@ class ReproTest(CIBaseTest):
> def test_repro_signed(self):
> targets = [
> 'mc:rpi-arm-v7-bullseye:isar-image-base',
> - 'mc:qemuarm64-bullseye:isar-image-base'
> + 'mc:qemuarm64-bullseye:isar-image-base',
> ]
>
> self.init()
> @@ -94,7 +94,7 @@ class ReproTest(CIBaseTest):
> def test_repro_unsigned(self):
> targets = [
> 'mc:qemuamd64-bullseye:isar-image-base',
> - 'mc:qemuarm-bullseye:isar-image-base'
> + 'mc:qemuarm-bullseye:isar-image-base',
> ]
>
> self.init()
> @@ -130,7 +130,7 @@ class CrossTest(CIBaseTest):
> 'mc:stm32mp15x-bullseye:isar-image-base',
> 'mc:qemuarm-bookworm:isar-image-ci',
> 'mc:qemuarm64-bookworm:isar-image-ci',
> - 'mc:qemuarm64-focal:isar-image-base'
> + 'mc:qemuarm64-focal:isar-image-base',
> ]
>
> self.init()
> @@ -138,7 +138,7 @@ class CrossTest(CIBaseTest):
>
> def test_cross_rpi(self):
> targets = [
> - 'mc:rpi-arm-v7-bullseye:isar-image-base'
> + 'mc:rpi-arm-v7-bullseye:isar-image-base',
> ]
>
> self.init()
> @@ -201,7 +201,7 @@ class NoCrossTest(CIBaseTest):
> 'mc:qemuarm-bookworm:isar-image-ci',
> 'mc:qemui386-bookworm:isar-image-base',
> 'mc:qemumipsel-bookworm:isar-image-ci',
> - 'mc:hikey-bookworm:isar-image-base'
> + 'mc:hikey-bookworm:isar-image-base',
> ]
>
> self.init()
> @@ -214,7 +214,7 @@ class NoCrossTest(CIBaseTest):
> 'mc:rpi-arm-bullseye:isar-image-base',
> 'mc:rpi-arm-v7-bullseye:isar-image-base',
> 'mc:rpi-arm-v7l-bullseye:isar-image-base',
> - 'mc:rpi-arm64-v8-bullseye:isar-image-base'
> + 'mc:rpi-arm64-v8-bullseye:isar-image-base',
> ]
>
> self.init()
> @@ -227,7 +227,7 @@ class NoCrossTest(CIBaseTest):
> targets = [
> 'mc:qemuamd64-trixie:isar-image-ci',
> 'mc:qemuarm64-trixie:isar-image-ci',
> - 'mc:qemuarm-trixie:isar-image-ci'
> + 'mc:qemuarm-trixie:isar-image-ci',
> ]
>
> self.init()
> @@ -239,7 +239,7 @@ class NoCrossTest(CIBaseTest):
> def test_nocross_sidports(self):
> targets = [
> 'mc:qemuriscv64-sid-ports:isar-image-base',
> - 'mc:sifive-fu540-sid-ports:isar-image-base'
> + 'mc:sifive-fu540-sid-ports:isar-image-base',
> ]
>
> self.init()
> @@ -260,7 +260,7 @@ class ContainerImageTest(CIBaseTest):
> targets = [
> 'mc:container-amd64-buster:isar-image-base',
> 'mc:container-amd64-bullseye:isar-image-base',
> - 'mc:container-amd64-bookworm:isar-image-base'
> + 'mc:container-amd64-bookworm:isar-image-base',
> ]
>
> self.init()
> --
> 2.34.1
>
Applied to next.
prev parent reply other threads:[~2023-08-02 4:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 10:22 Anton Mikanovich
2023-07-19 10:24 ` Anton Mikanovich
2023-07-19 12:29 ` Henning Schild
2023-08-02 4:07 ` Uladzimir Bely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31e4e2baaf8d50bad2580df60d6d6c8c193ac6ba.camel@ilbers.de \
--to=ubely@ilbers.de \
--cc=amikan@ilbers.de \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox