Re: [PATCH v7] dpkg: Restore support for replacing pre-installed packages in sbuild-chroot

["'Jan Kiszka' via isar-users" <isar-users@googlegroups.com>]

On 07.02.25 16:57, Anton Mikanovich wrote:
> 29/01/2024 09:59, 'Jan Kiszka' via isar-users wrote:
>> On 27.01.24 08:42, Uladzimir Bely wrote:
>>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>>
>>> During the migration to sbuild, support for using self-built packages in
>>> the build environment was lost if those were already part of the
>>> sbuild-chroot. This restores it by adding --apt-distupgrade to the
>>> sbuild call. But that is not enough because sbuild will only upgrade
>>> packages from already configured sources, not those specified via
>>> --extra-repository. We therefore have to switch back to configuring
>>> isar-apt during sbuild-chroot creation.
>>>
>>> As rootfs_configure_isar_apt configures the isar repo under
>>> /isar-apt, we bind-mount the one in /home/builder/${PN} to that folder.
>>> Another difference is that we now need to run apt-get update explicitly,
>>> but only for isar-apt.
>>>
>>> For apt fetching, we neither need nor want isar-apt to be available.
>>> Rebuilding self-generated apt packages is generally pointless as the
>>> needs are better addressed in the generating recipe itself. Exposing
>>> isar-apt to the fetch may furthermore lead to fetching a previously
>>> built source package of the same recipe, rather than pulling the
>>> external version.
>>>
>>> And because the sbuild-chroots are now left behind with isar-apt
>>> configured, the configuration in imager_run can be removed (credits to
>>> Srinuvasan Arjunan).
>>>
>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>> Reviewed-by: Uladzimir Bely <ubely@ilbers.de>
>> Thanks for sending - thought I did, but I only prepared locally, never
>> triggered the submission.
>>
>> Jan
>>
> Hello Jan,
> 
> It looks like this change creates one more issue.
> Here are simple steps to reproduce:
> 
> Prepare test recipe:
> 
> $ cat meta-isar/recipes-app/hello/pcre2.bb
> inherit dpkg
> 
> SRC_URI = "apt://pcre2"
> 
> CHANGELOG_V = "<orig-version>+isar"
> 
> do_prepare_build() {
>         deb_add_changelog
> }
> 
> Go to kas shell (qemuamd64 bookworm):
> 
> $ kas-container shell
> 
> Perform those steps:
> 
> builder@b5422048da4a:/build$ bitbake -c local_isarapt cowsay
> builder@b5422048da4a:/build$ bitbake -c build pcre2
> builder@b5422048da4a:/build$ bitbake -c cleansstate sbuild-chroot-target
> builder@b5422048da4a:/build$ bitbake -c build cowsay

The outcome is expected: local_isarapt is incorrectly run prior to
deploy_deb of pcre2. This won't happen during a normal build when cowsay
DEPENDS on pcre2, though, because of do_local_isarapt[deptask] =
"do_deploy_deb".

Now, if you used ISAR_REBUILD_ESSENTIAL_PKGS in your actual scenario, we
do have problem because your patch 21a05608d85b forgot to adjust
meta/classes/essential.bbclass. I'll send a fix.

Jan

-- 
Siemens AG, Foundational Technologies
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/321e7729-5785-47d3-bfd5-a5c875010945%40siemens.com.