Re: [PATCH v2] debianize: use date of the most recent file instead of "now"

[Jan Kiszka <jan.kiszka@siemens.com>]

On 09.03.19 21:26, Cedric Hombourger wrote:
> The changelog generated by Isar would use the current date/time
> causing each build to be different. Use the date/time of the
> most recent file to achieve reproducible builds (assuming files
> contained in the payload have the same contents and timestamps).
> In the event where the package is not shipping any files, Isar
> will default to the current date/time.
> 
> Signed-off-by: Cedric Hombourger <Cedric_Hombourger@mentor.com>
> ---
>   meta/classes/debianize.bbclass | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/classes/debianize.bbclass b/meta/classes/debianize.bbclass
> index 510aebd..ad3a98e 100644
> --- a/meta/classes/debianize.bbclass
> +++ b/meta/classes/debianize.bbclass
> @@ -6,7 +6,12 @@
>   CHANGELOG_V ?= "${PV}"
>   
>   deb_add_changelog() {
> -	date=$( LANG=C date -R )
> +	timestamp=$(find ${S}/ -type f -not -path "${S}/debian/*" -printf "%T@\n"|sort -n -r|head -n 1)
> +	if [ -n "${timestamp}" ]; then
> +		date=$(LANG=C date -R -d @${timestamp})
> +	else
> +		date=$(LANG=C date -R)
> +	fi
>   	cat <<EOF > ${S}/debian/changelog
>   ${PN} (${CHANGELOG_V}) UNRELEASED; urgency=low
>   
> 

Patch looks good.

In fact, I received a similar remark regarding the changelog we embedded into 
custom u-boots, and the same should apply to kernel modules as well. Maybe we 
should switch those recipes to changelog generation via debianize to benefit 
from this here.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux