From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6662603229503684608 X-Received: by 2002:a1c:8003:: with SMTP id b3mr96998wmd.25.1552368409530; Mon, 11 Mar 2019 22:26:49 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:b641:: with SMTP id g62ls180280wmf.11.canary-gmail; Mon, 11 Mar 2019 22:26:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqzd+HAJwHUz5YUVeKBzCFlSS0rXsM3+Q2E6tzM4dhnephOtxqzHTr8ZAQpLW/odJi+p+EIV X-Received: by 2002:a1c:358a:: with SMTP id c132mr91345wma.23.1552368409009; Mon, 11 Mar 2019 22:26:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552368409; cv=none; d=google.com; s=arc-20160816; b=vSB1/ExE4KHcWnxzrRIhYGHiE3vRLvRszQApbB7Vvbv0a57rfT7INaBUEG7GG5vuGg 3aQEHtBR4b9qsPbBgfjjVlTCLbyc/SSEps2mGPcneQ87lQi5I/4S6OXV5WAepXKJyLlr VvU+zXmkTGSxDj2W/wv5iYKAcqYxy1VYAoytNYzLHj4tDdR4oaZwwlqNBLcDDIL0h5eV y4JsurcweUVWuGUH9ClJsGwSAh9MaeQnUpXrD6qsGyQmC0/wkSnL59PZl0/wbDX7PMyi ajRTrygNK+i0txhxBeAho/iSrbyy18j1ITyu0HIIHQnngugGXV+g/1xqdu/sDHZBvCl6 25WA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=fmSptUPOkReZjAkRxdSr9bcADyHD66YXeXI7H8Tip7M=; b=hlP5fQb1pTn1XWXWGjuyDoYTm9Wjt/gV18m/s0XYo+YZVER+aJnRtpmkPqI9rDSVQk nY01Fz7uhMQV+/fMKNGqhQGPVpMhNulfbSbIw34HpM9LNyCLlTPeOwvt3STeG3stqWC9 WS9p8qtwy+EdOTo8RQoS5YFBtek6yZV2bzpgAjS8nM6qodnWgsdJOo0FlEZKNbTe1ysI 5LmrvPgs40PzgiyvPpyLw+mjc7ERDiStEuB/pI/HWb5PRIretwxhFCF6ZbryxxVWtz1+ Z8+z1zL0Rc2KfYNnowkbZ7qVDzaXCGKyJ/WCdHMmCtOAtkKM5W6ATHFKwHGFJkdts4Fk ytIg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id f185si61368wme.1.2019.03.11.22.26.48 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Mar 2019 22:26:49 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id x2C5QmlC014788 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 12 Mar 2019 06:26:48 +0100 Received: from [167.87.0.54] ([167.87.0.54]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x2C5QlWC023913; Tue, 12 Mar 2019 06:26:48 +0100 Subject: Re: [PATCH v2] debianize: use date of the most recent file instead of "now" To: Cedric Hombourger , isar-users@googlegroups.com, Henning Schild References: <20190227110017.36737bde@md1za8fc.ad001.siemens.net> <1552163202-1450-1-git-send-email-Cedric_Hombourger@mentor.com> From: Jan Kiszka Message-ID: <32273766-b305-f232-7b48-bf7e7f5fbecb@siemens.com> Date: Tue, 12 Mar 2019 06:26:46 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <1552163202-1450-1-git-send-email-Cedric_Hombourger@mentor.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: SBAJU1nADJiH On 09.03.19 21:26, Cedric Hombourger wrote: > The changelog generated by Isar would use the current date/time > causing each build to be different. Use the date/time of the > most recent file to achieve reproducible builds (assuming files > contained in the payload have the same contents and timestamps). > In the event where the package is not shipping any files, Isar > will default to the current date/time. > > Signed-off-by: Cedric Hombourger > --- > meta/classes/debianize.bbclass | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/meta/classes/debianize.bbclass b/meta/classes/debianize.bbclass > index 510aebd..ad3a98e 100644 > --- a/meta/classes/debianize.bbclass > +++ b/meta/classes/debianize.bbclass > @@ -6,7 +6,12 @@ > CHANGELOG_V ?= "${PV}" > > deb_add_changelog() { > - date=$( LANG=C date -R ) > + timestamp=$(find ${S}/ -type f -not -path "${S}/debian/*" -printf "%T@\n"|sort -n -r|head -n 1) > + if [ -n "${timestamp}" ]; then > + date=$(LANG=C date -R -d @${timestamp}) > + else > + date=$(LANG=C date -R) > + fi > cat < ${S}/debian/changelog > ${PN} (${CHANGELOG_V}) UNRELEASED; urgency=low > > Patch looks good. In fact, I received a similar remark regarding the changelog we embedded into custom u-boots, and the same should apply to kernel modules as well. Maybe we should switch those recipes to changelog generation via debianize to benefit from this here. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux