From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6842309179660566528 X-Received: by 2002:adf:e88a:: with SMTP id d10mr37047064wrm.247.1602584799850; Tue, 13 Oct 2020 03:26:39 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a5d:4a52:: with SMTP id v18ls36848wrs.2.gmail; Tue, 13 Oct 2020 03:26:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwbQTuDDDhOqYZ/o/9UI+BTKCi3DO8c+BPmeecSaFrxLYgwSWfl4RKtX4VbiGtqpo/UvwJH X-Received: by 2002:adf:e54b:: with SMTP id z11mr26700742wrm.128.1602584798969; Tue, 13 Oct 2020 03:26:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602584798; cv=none; d=google.com; s=arc-20160816; b=FV+omdgTw7LrYITZ+487ndGrps7nUph8kibTiIsghULD1vBAkrI/hTV9LTpjsx3GM6 OQTWzOitwiv2KcZJ+jik6gR7l38KzJhZiyY4tPfp/KHuesWIB6yCl5hVbAKREpjFA9FW UPTlPyCkK0s8lwMboP2kn0+GCQWDtQ/yyjL4Sm1amdQMofS7JlLs1xtPS6ceGlBBTyMu snku3G5zyGIYwdMNO9dL97i7jBMX4LUiF5PnFUEONlozCtfNX8Kq8lQp58slLYy6c+Ds l5IPG4kaUrfFl0R8y8aZGyvcnz2zXK54e1GbCWPTL04PbWl462maM9H7KgBTNLziTwsc TBJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id; bh=Y/Mws26wkINozg8aknScgztNmSpswawpDeD5+c67p1E=; b=JnHg7y8Geu/XK83zvi7SxcwZpXS5EHmecdOmWbC8nqjHxoRA0KRr0Shy0jplbN8NiL 6UZgKQuukGI2UnMI24bR9RNGYV5gxMgFCqcpKm7a/PPUPygaoqwE9Ru9Tw9GKU5gvuKW y/KutmDrUCVIByDl8JTEnKj8Z2Dis8969QsPSz9Tp+EINzPOyTF5g7aMG8ivEepbL2a2 YDas7TxrNFTmuUH5+a+SFpHBn/BRS+3FFpdSPgvwbpKJ0Xg8vROIHZIHb8syFdJT3GwA j6qp6K1g8SqF/1Y6vd6zh9eCksmDoIEP7S9p38ngZRpHHcTKXdViB5X+AtBmbiIK9ybd vWhA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of hws@denx.de) smtp.mailfrom=hws@denx.de Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net. [212.18.0.9]) by gmr-mx.google.com with ESMTPS id w206si629242wmb.2.2020.10.13.03.26.38 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Oct 2020 03:26:38 -0700 (PDT) Received-SPF: neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of hws@denx.de) client-ip=212.18.0.9; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of hws@denx.de) smtp.mailfrom=hws@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4C9WtQ4y5bz1r6nM; Tue, 13 Oct 2020 12:26:38 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4C9WtQ466rz1r0mC; Tue, 13 Oct 2020 12:26:38 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id j2FChCUtwMIy; Tue, 13 Oct 2020 12:26:37 +0200 (CEST) X-Auth-Info: KnXZLrscHrHAuTg5jIhSmDulaRxGgEe9iP81FabZgI4= Received: from maia (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Tue, 13 Oct 2020 12:26:37 +0200 (CEST) Message-ID: <33231e4d0ef88346879f00e761ede03eb39f1454.camel@denx.de> Subject: Re: [PATCH] image: Run copy_boot_files after rootfs postprocessing From: Harald Seiler To: Jan Kiszka , isar-users@googlegroups.com Cc: Claudius Heine , Henning Schild Date: Tue, 13 Oct 2020 12:26:37 +0200 In-Reply-To: <61a681ed-f982-30a4-12f6-5b1b1d49b780@siemens.com> References: <20200625153351.3402179-1-hws@denx.de> <61a681ed-f982-30a4-12f6-5b1b1d49b780@siemens.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUID: YkvAEAvMO06T Hi Jan, On Tue, 2020-10-13 at 12:19 +0200, Jan Kiszka wrote: > On 25.06.20 17:33, Harald Seiler wrote: > > In some cases, postprocessing might trigger an update of the initramfs > > which would not appear in the deployed version. Fix this by running > > copy_boot_files only after all postprocessing completed. > > > > Signed-off-by: Harald Seiler > > --- > > meta/classes/image.bbclass | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass > > index 0150f2718573..21d634a8f34f 100644 > > --- a/meta/classes/image.bbclass > > +++ b/meta/classes/image.bbclass > > @@ -153,7 +153,7 @@ do_copy_boot_files() { > > cp -f "$dtb" "${DEPLOY_DIR_IMAGE}/" > > done > > } > > -addtask copy_boot_files before do_rootfs_postprocess after do_rootfs_install > > +addtask copy_boot_files before do_rootfs after do_rootfs_postprocess > > > > python do_image_tools() { > > """Virtual task""" > > > > There was a lengthy discussion after this, but I don't think the > conclusion was to hold back this patch, right? We are using it at least > in one case internally, so this should likely go in now. At least from my side we can drop this. In the project where I needed this it is now gone, because I switched to the alternate initramfs mechanism over there. Also, the arguments where this patch might break downstream use-cases do hold some truth so I'd rather err on the side of caution and not go this route. -- Harald DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-62 Fax: +49-8142-66989-80 Email: hws@denx.de