From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6982225646555496448 X-Received: by 2002:ac2:54a7:: with SMTP id w7mr12017996lfk.495.1625761225230; Thu, 08 Jul 2021 09:20:25 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:ac2:508b:: with SMTP id f11ls502186lfm.2.gmail; Thu, 08 Jul 2021 09:20:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzbvQZ5S3P20LAx1vwXRUgf3YKrkM172wrjOiHOFK9+KTHc/WY0W2DJPYxhG9I3UmO5Q8ur X-Received: by 2002:a19:c795:: with SMTP id x143mr24168188lff.354.1625761224100; Thu, 08 Jul 2021 09:20:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625761224; cv=none; d=google.com; s=arc-20160816; b=pI+uCOJX1sVoGNhHtjqA1QYaiDM7CESIqD3UoOyUq2ur9lHMNkJTP251C+VAmFqKvc B3eaStKljK9HHTiiF3u0f47E80SXJyIytvWkJprH+QyWG61cJnPVRsCYItrzTJXPWp9E q1lp2vbHUAXm2bTRJMjgsFUy39HubgZcHYr42CvzSlCDOyrRE0RZXoDTZeXnlLR93zDI pLQCGAase9rJxCJ5qyGdJbG54hqPAg8RjMuVnpjgjTqzO9V7lnpqFdeFhpUyj48Sk6Ls GUIrZSOnWtx71fz+gXOi3OgQqic68EoC8ppPVmFnhfArpI6FFLVaP7CAf5CD7gjajrR5 3Ryg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=E7OqpfIJmie8rAPVELcybft0TyTbPZrxRRwmJZpjjOs=; b=dJOffmiAx/Mn0Bt5wuwpOjTiSnglzaWrdyHa66FLFi7a//mfRtYWHlKuPOOCiYXdfv NUnEz2pyfOeDOsCNd4zns9Z/nfQfCNjxVFfN0UYPwmHxR/PncSCxSDqctdnIcswP2cqt 5lY4SUiHAAZ8pQLGPW60Hr4URFPpK8ZWwKfuqppygKLrMUKJDsVanfq9Yau/ALtx5osv koct8X6z3YlmJ6hFx2vZPDBZRU5Dyyp5UzaTg2MUBBTPYGSSnx3fDuOtYWww6mtQPzxp +vpyyHt+y7dzO3mnGeqtW1iVYWvIe4/CTYhLVQZ2j52NjCj0m7bFXR/lfqaANnKCR+5s k4fw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id n127si95841lfa.7.2021.07.08.09.20.23 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Jul 2021 09:20:24 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id 168GKNTb020035 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 8 Jul 2021 18:20:23 +0200 Received: from [167.87.42.31] ([167.87.42.31]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 168GKMTQ003319; Thu, 8 Jul 2021 18:20:23 +0200 Subject: Re: [PATCH v2] buildchroot: Add buildchroot dependency for imager To: Anton Mikanovich , isar-users@googlegroups.com References: <20210708152136.220186-1-amikan@ilbers.de> From: Jan Kiszka Message-ID: <33353ffa-63c3-ab32-4dce-05a51174db2c@siemens.com> Date: Thu, 8 Jul 2021 18:20:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210708152136.220186-1-amikan@ilbers.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: D2SprqhXUIHk On 08.07.21 17:21, Anton Mikanovich wrote: > To allow do_install_imager_deps depend on proper BUILDCHROOT based on > ISAR_CROSS_COMPILE value make dependency to be dynamic. > > Signed-off-by: Anton Mikanovich > --- > meta/classes/buildchroot.bbclass | 1 + > meta/classes/image-tools-extension.bbclass | 1 - > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/classes/buildchroot.bbclass b/meta/classes/buildchroot.bbclass > index 806a29f..1f90768 100644 > --- a/meta/classes/buildchroot.bbclass > +++ b/meta/classes/buildchroot.bbclass > @@ -18,6 +18,7 @@ python __anonymous() { > rootfs = d.getVar('BUILDCHROOT_HOST_DIR', True) > > d.setVarFlag('do_apt_fetch', 'depends', dep) > + d.setVarFlag('do_install_imager_deps', 'depends', dep) > d.setVar('BUILDCHROOT_DIR', rootfs) > } > > diff --git a/meta/classes/image-tools-extension.bbclass b/meta/classes/image-tools-extension.bbclass > index 4738479..df32911 100644 > --- a/meta/classes/image-tools-extension.bbclass > +++ b/meta/classes/image-tools-extension.bbclass > @@ -14,7 +14,6 @@ IMAGER_INSTALL ??= "" > IMAGER_BUILD_DEPS ??= "" > DEPENDS += "${IMAGER_BUILD_DEPS}" > > -do_install_imager_deps[depends] = "buildchroot-target:do_build" As explained, this pattern is cleaner than pushing the dependency to the required task. Same is true for do_apt_fetch, but that is not in scope of this patch. You should resolve which buildchroot you need and add the dependency here, in the proper context. > do_install_imager_deps[deptask] = "do_deploy_deb" > do_install_imager_deps[lockfiles] += "${REPO_ISAR_DIR}/isar.lock" > do_install_imager_deps() { > Jan -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux