Re: [PATCH] meta: Replace no longer available bb.build.FuncFailed

[Jan Kiszka <jan.kiszka@siemens.com>]

On 19.02.20 08:38, vijai kumar wrote:
> My patch[1] exactly addresses this :)
> 
> [1] https://groups.google.com/forum/#!topic/isar-users/ZAAKFICAbLA
> 

Oops, indeed, missed that.

Thanks,
Jan

> Thanks,
> Vijai Kumar K
> 
> On Wednesday, February 19, 2020 at 12:47:05 PM UTC+5:30, Jan Kiszka wrote:
> 
>     From: Jan Kiszka <jan....@siemens.com <javascript:>>
> 
>     Follow the pattern in oe-core and issue bb.fatal instead.
> 
>     Signed-off-by: Jan Kiszka <jan....@siemens.com <javascript:>>
>     ---
>       meta/classes/base.bbclass      | 4 ++--
>       meta/classes/dpkg-base.bbclass | 2 +-
>       2 files changed, 3 insertions(+), 3 deletions(-)
> 
>     diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
>     index e233164c..b7de921a 100644
>     --- a/meta/classes/base.bbclass
>     +++ b/meta/classes/base.bbclass
>     @@ -171,7 +171,7 @@ python do_fetch() {
>               fetcher = bb.fetch2.Fetch(src_uri, d)
>               fetcher.download()
>           except bb.fetch2.BBFetchException as e:
>     -        raise bb.build.FuncFailed(e)
>     +        bb.fatal(str(e))
>       }
> 
>       addtask fetch before do_build
>     @@ -190,7 +190,7 @@ python do_unpack() {
>               fetcher = bb.fetch2.Fetch(src_uri, d)
>               fetcher.unpack(rootdir)
>           except bb.fetch2.BBFetchException as e:
>     -        raise bb.build.FuncFailed(e)
>     +        bb.fatal(str(e))
>       }
> 
>       addtask unpack after do_fetch before do_build
>     diff --git a/meta/classes/dpkg-base.bbclass
>     b/meta/classes/dpkg-base.bbclass
>     index 1decf587..5d2c161c 100644
>     --- a/meta/classes/dpkg-base.bbclass
>     +++ b/meta/classes/dpkg-base.bbclass
>     @@ -42,7 +42,7 @@ python do_adjust_git() {
>                       if subprocess.call(cmd) != 0:
>                           bb.fatal("git alternates adjustment failed")
>               except bb.fetch2.BBFetchException as e:
>     -            raise bb.build.FuncFailed(e)
>     +            bb.fatal(str(e))
>       }
> 
>       addtask adjust_git after do_unpack before do_patch
>     -- 
>     2.16.4
> 
> 
>     -- 
>     Siemens AG, Corporate Technology, CT RDA IOT SES-DE
>     Corporate Competence Center Embedded Linux
> 
> -- 
> You received this message because you are subscribed to the Google 
> Groups "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send 
> an email to isar-users+unsubscribe@googlegroups.com 
> <mailto:isar-users+unsubscribe@googlegroups.com>.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/isar-users/2e0645f0-c397-48c0-b741-988f16a05384%40googlegroups.com 
> <https://groups.google.com/d/msgid/isar-users/2e0645f0-c397-48c0-b741-988f16a05384%40googlegroups.com?utm_medium=email&utm_source=footer>.

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux