From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6795053263826714624 X-Received: by 2002:a05:6000:108e:: with SMTP id y14mr34740372wrw.338.1582097990978; Tue, 18 Feb 2020 23:39:50 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a5d:65d0:: with SMTP id e16ls9076082wrw.1.gmail; Tue, 18 Feb 2020 23:39:50 -0800 (PST) X-Google-Smtp-Source: APXvYqyKgpja4OXxO4LpPoJgsDOLnNbQXvzb41E1wOwiOyAk0+k7MSoZz9/7/SFmY3lQxxkNyoCh X-Received: by 2002:adf:8b59:: with SMTP id v25mr35500327wra.419.1582097990309; Tue, 18 Feb 2020 23:39:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582097990; cv=none; d=google.com; s=arc-20160816; b=IFJaN7Fj/N+sGer7ve7PYj55vOhQms8XT7oviAYI0JFQ1alGU2kvr4iFRVYH3woh6E EtI6QS1Wo0qHV7yC90I/GUiVzEbTp1XkUgGJcm92ZQsgBrO/9Bo+K5+GXLQ/IGCAwCAk 8rY8IKOa8V4HF2RqS+KCkHH5p+/T7oIsIvUTl+rabZaOg96Uf70tAHcLwMb4jOcyxX9E m3eGx2t7jpiXf/F8ee2Os0DHx0V8dGHCkeKV1tmMi4Sgz/eIwst7jMb9gCPVmq25PfwP JwNqENqAC0g7h61G2Zod1sHtEYx4RAXkx5jlMcsi9im00dHbGsoni9e584YDf8h4G15e Na/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=NaAuWqX1L/0QHDCPlW3GQIWp16I0GtrLz6K3fJHfi/k=; b=xr4lUvxi00yhEJCpCj8xsaGSE/438imGKqHI2ZaksQ1pCruUDhK5wTUSEtXH0kivKn FeOYfxPjXO6Kpt67Jd1HKFctJgiYWzPUYPl0GvHZWVmfAdlHDzSS/eRGSFtvG0lrehrl VezXlZHVWVJh57HgN/KIo7E6nSDy30zSdEIAARK5G/JQkoBjhrdhSDjyjrwEZ7xvVMd7 ej5ilsNY2ozrz1ITm4/D91k1L5uK0Ecs7JKPOrITfC46k76KrnqrqSEpxnKzbVJT4hMp bFFvYc0DHDsQKETEIJzmsb+KplyAeZTkwY4eO4bkPsbuNm5Ae4aYooqQ5QhPFzjVJn36 QD9g== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id i15si73243wro.2.2020.02.18.23.39.50 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 18 Feb 2020 23:39:50 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id 01J7dnmH008983 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 19 Feb 2020 08:39:49 +0100 Received: from [139.22.44.97] ([139.22.44.97]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 01J7dmL7026310; Wed, 19 Feb 2020 08:39:49 +0100 Subject: Re: [PATCH] meta: Replace no longer available bb.build.FuncFailed To: vijai kumar , isar-users References: <94d92943-ea75-bda6-1b07-56440856eb14@siemens.com> <2e0645f0-c397-48c0-b741-988f16a05384@googlegroups.com> From: Jan Kiszka Message-ID: <33382b55-44e0-286c-a902-bdba7dd3292d@siemens.com> Date: Wed, 19 Feb 2020 08:39:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <2e0645f0-c397-48c0-b741-988f16a05384@googlegroups.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: vnJ3DO7eCVct On 19.02.20 08:38, vijai kumar wrote: > My patch[1] exactly addresses this :) > > [1] https://groups.google.com/forum/#!topic/isar-users/ZAAKFICAbLA > Oops, indeed, missed that. Thanks, Jan > Thanks, > Vijai Kumar K > > On Wednesday, February 19, 2020 at 12:47:05 PM UTC+5:30, Jan Kiszka wrote: > > From: Jan Kiszka > > > Follow the pattern in oe-core and issue bb.fatal instead. > > Signed-off-by: Jan Kiszka > > --- >  meta/classes/base.bbclass      | 4 ++-- >  meta/classes/dpkg-base.bbclass | 2 +- >  2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass > index e233164c..b7de921a 100644 > --- a/meta/classes/base.bbclass > +++ b/meta/classes/base.bbclass > @@ -171,7 +171,7 @@ python do_fetch() { >          fetcher = bb.fetch2.Fetch(src_uri, d) >          fetcher.download() >      except bb.fetch2.BBFetchException as e: > -        raise bb.build.FuncFailed(e) > +        bb.fatal(str(e)) >  } > >  addtask fetch before do_build > @@ -190,7 +190,7 @@ python do_unpack() { >          fetcher = bb.fetch2.Fetch(src_uri, d) >          fetcher.unpack(rootdir) >      except bb.fetch2.BBFetchException as e: > -        raise bb.build.FuncFailed(e) > +        bb.fatal(str(e)) >  } > >  addtask unpack after do_fetch before do_build > diff --git a/meta/classes/dpkg-base.bbclass > b/meta/classes/dpkg-base.bbclass > index 1decf587..5d2c161c 100644 > --- a/meta/classes/dpkg-base.bbclass > +++ b/meta/classes/dpkg-base.bbclass > @@ -42,7 +42,7 @@ python do_adjust_git() { >                  if subprocess.call(cmd) != 0: >                      bb.fatal("git alternates adjustment failed") >          except bb.fetch2.BBFetchException as e: > -            raise bb.build.FuncFailed(e) > +            bb.fatal(str(e)) >  } > >  addtask adjust_git after do_unpack before do_patch > -- > 2.16.4 > > > -- > Siemens AG, Corporate Technology, CT RDA IOT SES-DE > Corporate Competence Center Embedded Linux > > -- > You received this message because you are subscribed to the Google > Groups "isar-users" group. > To unsubscribe from this group and stop receiving emails from it, send > an email to isar-users+unsubscribe@googlegroups.com > . > To view this discussion on the web visit > https://groups.google.com/d/msgid/isar-users/2e0645f0-c397-48c0-b741-988f16a05384%40googlegroups.com > . -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux