[PATCH] image-tools-extension: Limit IMAGER_BUILD_DEPS to do_image_tools task

[PATCH] image-tools-extension: Limit IMAGER_BUILD_DEPS to do_image_tools task

['Jan Kiszka' via isar-users]

From: Jan Kiszka <jan.kiszka@siemens.com>

There is no reason to let the rootfs_install task wait for imager build
dependencies. This also avoid rebuilding the rootfs if only an imager
dependency was updated.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 meta/classes/image-tools-extension.bbclass | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/meta/classes/image-tools-extension.bbclass b/meta/classes/image-tools-extension.bbclass
index e8ace8f5..5e248f2e 100644
--- a/meta/classes/image-tools-extension.bbclass
+++ b/meta/classes/image-tools-extension.bbclass
@@ -1,5 +1,5 @@
 # This software is a part of ISAR.
-# Copyright (C) Siemens AG, 2019
+# Copyright (C) Siemens AG, 2019-2024
 #
 # SPDX-License-Identifier: MIT
 #
@@ -9,7 +9,11 @@ inherit sbuild
 
 IMAGER_INSTALL ??= ""
 IMAGER_BUILD_DEPS ??= ""
-DEPENDS += "${IMAGER_BUILD_DEPS}"
+
+python() {
+    for dep in d.getVar('IMAGER_BUILD_DEPS').split():
+        d.appendVarFlag('do_image_tools', 'depends', ' ' + dep + ':do_deploy_deb')
+}
 
 SCHROOT_MOUNTS = "${WORKDIR}:${PP_WORK} ${IMAGE_ROOTFS}:${PP_ROOTFS} ${DEPLOY_DIR_IMAGE}:${PP_DEPLOY}"
 SCHROOT_MOUNTS += "${REPO_ISAR_DIR}/${DISTRO}:/isar-apt"
-- 
2.43.0

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/143fcb5c-c8bb-4292-8cf8-760fa366020f%40siemens.com.

Re: [PATCH] image-tools-extension: Limit IMAGER_BUILD_DEPS to do_image_tools task

[Anton Mikanovich]

17/08/2025 19:20, 'Jan Kiszka' via isar-users wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> There is no reason to let the rootfs_install task wait for imager build
> dependencies. This also avoid rebuilding the rootfs if only an imager
> dependency was updated.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Applied to next, thanks.

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/911c155a-f7ee-40ea-9d22-45ae7b158ede%40ilbers.de.

Re: [PATCH] image-tools-extension: Limit IMAGER_BUILD_DEPS to do_image_tools task

['MOESSBAUER, Felix' via isar-users]

On Sun, 2025-08-17 at 18:20 +0200, 'Jan Kiszka' via isar-users wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> There is no reason to let the rootfs_install task wait for imager build
> dependencies. This also avoid rebuilding the rootfs if only an imager
> dependency was updated.

Hi, this patch breaks the swupdate (:swu) image type in isar-cip-core.

While I was not able to locate the root cause, I checked that the
swupdate.inc correctly appends the needed dependencies to
IMAGER_BUILD_DEPS:swu. Also, I saw that the packages never appear in
do_image_tools[depends]. Where they get lost remains unclear.

To debug this, I recommend to just look at the dependency graph
(bitbake -g cip-core-image, grep task-depends.dot "...").

Best regards,
Felix

> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  meta/classes/image-tools-extension.bbclass | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/classes/image-tools-extension.bbclass b/meta/classes/image-tools-extension.bbclass
> index e8ace8f5..5e248f2e 100644
> --- a/meta/classes/image-tools-extension.bbclass
> +++ b/meta/classes/image-tools-extension.bbclass
> @@ -1,5 +1,5 @@
>  # This software is a part of ISAR.
> -# Copyright (C) Siemens AG, 2019
> +# Copyright (C) Siemens AG, 2019-2024
>  #
>  # SPDX-License-Identifier: MIT
>  #
> @@ -9,7 +9,11 @@ inherit sbuild
>  
>  IMAGER_INSTALL ??= ""
>  IMAGER_BUILD_DEPS ??= ""
> -DEPENDS += "${IMAGER_BUILD_DEPS}"
> +
> +python() {
> +    for dep in d.getVar('IMAGER_BUILD_DEPS').split():
> +        d.appendVarFlag('do_image_tools', 'depends', ' ' + dep + ':do_deploy_deb')
> +}
>  
>  SCHROOT_MOUNTS = "${WORKDIR}:${PP_WORK} ${IMAGE_ROOTFS}:${PP_ROOTFS} ${DEPLOY_DIR_IMAGE}:${PP_DEPLOY}"
>  SCHROOT_MOUNTS += "${REPO_ISAR_DIR}/${DISTRO}:/isar-apt"
> -- 
> 2.43.0
> 
> -- 
> You received this message because you are subscribed to the Google Groups "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
> To view this discussion visit https://groups.google.com/d/msgid/isar-users/143fcb5c-c8bb-4292-8cf8-760fa366020f%40siemens.com.

-- 
Siemens AG
Linux Expert Center
Friedrich-Ludwig-Bauer-Str. 3
85748 Garching, Germany

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/336625dcdad7e66cd9798300b845cfac336b5a8d.camel%40siemens.com.

Re: [PATCH] image-tools-extension: Limit IMAGER_BUILD_DEPS to do_image_tools task

['Jan Kiszka' via isar-users]

On 16.10.25 16:41, Moessbauer, Felix (FT RPD CED OES-DE) wrote:
> On Sun, 2025-08-17 at 18:20 +0200, 'Jan Kiszka' via isar-users wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> There is no reason to let the rootfs_install task wait for imager build
>> dependencies. This also avoid rebuilding the rootfs if only an imager
>> dependency was updated.
> 
> Hi, this patch breaks the swupdate (:swu) image type in isar-cip-core.
> 
> While I was not able to locate the root cause, I checked that the
> swupdate.inc correctly appends the needed dependencies to
> IMAGER_BUILD_DEPS:swu. Also, I saw that the packages never appear in
> do_image_tools[depends]. Where they get lost remains unclear.
> 
> To debug this, I recommend to just look at the dependency graph
> (bitbake -g cip-core-image, grep task-depends.dot "...").
> 

This happened to bite me today as well - only fair. I'm debugging it
right now.

Jan

-- 
Siemens AG, Foundational Technologies
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/cd3ee231-1b18-4a06-8f61-cc3fcbb5103b%40siemens.com.