From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6608507886135934976 X-Received: by 2002:ac2:4359:: with SMTP id o25-v6mr612227lfl.31.1538996110917; Mon, 08 Oct 2018 03:55:10 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:9d05:: with SMTP id t5-v6ls7664lji.23.gmail; Mon, 08 Oct 2018 03:55:10 -0700 (PDT) X-Google-Smtp-Source: ACcGV62SyA7xcoEXtQXdi3qjWkcvTEGvQ/3UlTd9h37WOdXEMYhYh9Nt745EzpqnV4yznZOXjTUK X-Received: by 2002:a2e:3910:: with SMTP id g16-v6mr613667lja.13.1538996110267; Mon, 08 Oct 2018 03:55:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538996110; cv=none; d=google.com; s=arc-20160816; b=yyB6Opp1wO3tlPwuYLyvR1yoNvKhG4YQrcSFgLld/ikEizAnQVfu6/0pUv2YhJCoMk hJrFHYi2gLWc1ly16hZdrVrzPkdv0pkaRA+h3AC/AyticjbhBNmQ6f0L8ygtALgernGz 7YXqNRQHWO9ct64j1bt7VZ7CZnNR52iNRrvquxWDOav/P9OWzOHnw0RGKflBV0IwGULU nendEoMPzblU1XoMVOjWJ2JdJGU3AVtZhCPz5pi3zm63NTR4b5ehVwjTDfafBKyI8zI2 Y2Z3dfe0pz1K/1PUMyU6Ga0VwmHhYw98Kfiihb7vRXBXnKbHSlokHTflR2ZgcIk3k4kY 9iKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=fYeAQ78cHsvbhvoY6Kiye8WCdVdnZo8xbadX39YkCUo=; b=l9KB6lsb8wysAQ79uiOb4mHx46la7McVW6BLOaSGJIVA1lGpx9ipRDt/0v5STKLX11 BmhUBWPzpsI92iEzM89uHENm5GSgVyqZBwxl2UGNctetXNvZjl0iS+uXIquniCwgK8F7 ev8Utu482rl+1fH+Nca0zoSa7epMqR+LeQ7lfCruO8B3K4uwev4p6MgWOGV1aKnyUODm 18rU560CpPKePqYNkEGZo3dxoYkZQSwVzvz5dqUzJWPBrfZkb1EO0T0KrS33XfudrmuS iQTN9kQ8gdL9LnXAZ/el6gb/NoaBhtk0Rbx/9+PCKPdEs4zVoR1pBmlzEtNMn/v+ZKfp laQA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id r81-v6si703802ljb.2.2018.10.08.03.55.10 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Oct 2018 03:55:10 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id w98At9Vr003904 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 8 Oct 2018 12:55:09 +0200 Received: from [167.87.48.216] ([167.87.48.216]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id w98At846029730; Mon, 8 Oct 2018 12:55:09 +0200 Subject: Re: [PATCH] linux-custom: fall back to using "make defconfig" when no config given To: "[ext] Henning Schild" , isar-users References: <20181004142541.11757-1-henning.schild@siemens.com> From: Jan Kiszka Message-ID: <33b6fe32-c1c5-f7cf-f230-c20e811d5ec5@siemens.com> Date: Mon, 8 Oct 2018 12:55:08 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <20181004142541.11757-1-henning.schild@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: kWStlSn/hBAK On 04.10.18 16:25, [ext] Henning Schild wrote: > This allows us to write kernel recipes that do not have to bring what > they consider their defconfig. If KERNEL_DEFCONFIG is empty, do not > attempt to copy a file into the tree and call "make defconfig" instead > of "make olddefconfig". > > Signed-off-by: Henning Schild > --- > meta/recipes-kernel/linux/files/build-kernel.sh | 6 +++++- > meta/recipes-kernel/linux/linux-custom.inc | 6 ++++-- > 2 files changed, 9 insertions(+), 3 deletions(-) > > diff --git a/meta/recipes-kernel/linux/files/build-kernel.sh b/meta/recipes-kernel/linux/files/build-kernel.sh > index 3f39d43..32d62bf 100644 > --- a/meta/recipes-kernel/linux/files/build-kernel.sh > +++ b/meta/recipes-kernel/linux/files/build-kernel.sh > @@ -34,7 +34,11 @@ REPACK_LINUX_IMAGE_DIR="${REPACK_DIR}/linux-image" > REPACK_LINUX_HEADERS_DIR="${REPACK_DIR}/linux-headers" > > cd $1 > -make olddefconfig > +if [ -e .config ]; then > + make olddefconfig > +else > + make defconfig > +fi > > KV=$( make -s kernelrelease ) > if [ "${KV}" != "${PV}" ]; then > diff --git a/meta/recipes-kernel/linux/linux-custom.inc b/meta/recipes-kernel/linux/linux-custom.inc > index 34c9a62..6ee87d4 100644 > --- a/meta/recipes-kernel/linux/linux-custom.inc > +++ b/meta/recipes-kernel/linux/linux-custom.inc > @@ -10,7 +10,7 @@ FILESPATH =. "${LAYERDIR_core}/recipes-kernel/linux/files:" > DESCRIPTION ?= "Custom kernel" > > KERNEL_NAME_PRODVIDED ?= "${@ d.getVar('PN', True).partition('linux-')[2]}" > -KERNEL_DEFCONFIG ?= "defconfig" > +KERNEL_DEFCONFIG ?= "" > > python() { > kernel_name = d.getVar("KERNEL_NAME_PRODVIDED", True) > @@ -43,7 +43,9 @@ dpkg_runbuild() { > # Install package builder script > sudo install -m 755 ${WORKDIR}/build-kernel.sh ${BUILDCHROOT_DIR} > > - sudo cp ${WORKDIR}/${KERNEL_DEFCONFIG} ${S}/.config > + if [ ! -z ${KERNEL_DEFCONFIG} ]; then if [ -n ${KERNEL_DEFCONFIG} ]; ... > + sudo cp ${WORKDIR}/${KERNEL_DEFCONFIG} ${S}/.config > + fi > > E="${@ bb.utils.export_proxies(d)}" > > Looks good otherwise. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux