Re: [PATCH v4 4/8] meta/classes: add image-account-extension class

[Claudius Heine <claudius.heine.ext@siemens.com>]

Hi Jan,

On 31/05/2019 09.29, Jan Kiszka wrote:
[...]
>> +inherit image-account-extension
>>   # Extra space for rootfs in MB
>>   ROOTFS_EXTRA ?= "64"
>>
> 
> Seems like we are not rebuilding the affected recipes when variables 
> change. That's at least true for the root password I just played with.
> Fixable?

Interesting. My intention was to implement it in a way to avoid this 
issue, but I guess that needs some further investigation then.

Just to make clear how I thought it worked:

This line should add the all bitbake functions in 
`ROOTFS_CONFIGURE_COMMAND` and `ROOTFS_INSTALL_COMMAND` to the `vardeps` 
flag. Because bitbake functions are variables as well, that should mean 
that `do_rootfs_install` depends on the content of those functions, 
including all expanded bitbake variables (at least so I thought):

meta/classes/rootfs.bbclass:
   do_rootfs_install[vardeps] = "${ROOTFS_CONFIGURE_COMMAND} 
${ROOTFS_INSTALL_COMMAND}"

It would be good to investigate why that didn't work. A simple fix would 
be to add `IMAGE_ACCOUNTS_USERS` and `IMAGE_ACCOUNTS_GROUPS` to that 
flag as well. But it would be good to investigate first why that 
approach did not work and possible fix that, because that mechanism is 
used elsewhere as well.

regards,
Claudius


-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de