Re: [PATCH] scripts/start_vm: enclose -append args in quotes and use eval

[Uladzimir Bely <ubely@ilbers.de>]

On Thu, 2024-03-21 at 12:31 +0530, Badrikesh Prusty wrote:
> From: Badrikesh Prusty <badrikesh.prusty@siemens.com>
> 
> - Observing boot failure of qemuarm64 with error message:
>    'root=/dev/vda': No such file or directory
> - Fix syntax for providing -append arguments with qemu-system-*
> command
> - The -append arguments must be enclosed in quotes
> - Use eval to execute qemu-system-* command
> - Fix consistency with use of spaces instead of tabs
> 
> Signed-off-by: Badrikesh Prusty <badrikesh.prusty@siemens.com>
> ---
>  scripts/start_vm | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)

Hello.

We are planning to remove "scripts/start_vm" in favor of
"testsuite/start_vm.py" that is a drop-in replacement (but with
testsuite integration).

So, this patch is unlikely to be merged.

But if the issue you have faced can also be reproduced with
start_vm.py, it would worth fixing.