From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6917993065941565440 X-Received: by 2002:a5d:5917:: with SMTP id v23mr3336594wrd.308.1611046231112; Tue, 19 Jan 2021 00:50:31 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:e608:: with SMTP id p8ls11985647wrm.2.gmail; Tue, 19 Jan 2021 00:50:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJxKlDRn2GNTRR/wIoO9Wv9mCazxQoSxUj1tmHmXOx8po0I1lyosjk0UL54sctYwCPYrAtT9 X-Received: by 2002:a05:6000:23c:: with SMTP id l28mr3243722wrz.193.1611046230210; Tue, 19 Jan 2021 00:50:30 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1611046230; cv=pass; d=google.com; s=arc-20160816; b=JELivFjOuftftJFKjn9FaBZkDB2RP1Q0FmywnxORK6V+iz5+CYTLX1LuiDKufq9RMw v8bhGkR5DHhHvs0Zu/kcDKubQ7tz/JDkZYf6UEgiSxrV4uJkdb5BRXQ+21OY+wm9EpoF 9YIB5PZPIRBK8pTUZW36VbtV8whkn9TaureMkOERY2hGLjR3g+Fz594sPu0x9tlfqWIx MT18Ucu+nUtEU+VtS79rN1Fy6TS9zkUurXM5arN4mGhngXx/h05L14u6mVDQlN7R3YbO TYluWp3Vlk+2yXk38ULhdXnS73InfRbF4IUnr5t4RVoAd1Hb8HOSKcCuCLs8co2bcW+3 uFrg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-language:content-transfer-encoding:in-reply-to :user-agent:date:message-id:from:references:cc:to:subject :dkim-signature; bh=x4TOeo4+JVX+CFP2ssGbOYKRGnXjk007IwEGVbH4X74=; b=N599GNBQ6W6WWV0P4xfMmRhMtQ33WagykqNOAHxqMjfY3sRH0GPuUeiTd5fZlnmibC +2kJywddxXS667Ir1i/7wmpoU1L/4yUV8CyAQ7tFo6aW928VzftXXTeAj3IOFnSxh4IH xNhjNp7BetowAUqPn+NqEh4oaRQDGSV8nf0Cum0nv27mS0ka3wHnx9Jv+4N2ioitCK+M d18UmThkQ02uZ0mFUmpsFGUI1hancOnV+7yTtZ+Tg/pOfGh1xNL12QV/wdiQPY4m7p+u z+MbwQkti37MKc6fa0MbAD631rV3WqbEdqc275xRDSDwhGUErVHjY0VI4pyjXls8AJ6X rEWg== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.onmicrosoft.com header.s=selector1-siemens-onmicrosoft-com header.b=lSCtV+DA; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of silvano.cirujano-cuesta@siemens.com designates 40.107.22.68 as permitted sender) smtp.mailfrom=silvano.cirujano-cuesta@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2068.outbound.protection.outlook.com. [40.107.22.68]) by gmr-mx.google.com with ESMTPS id j133si115737wma.2.2021.01.19.00.50.30 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Jan 2021 00:50:30 -0800 (PST) Received-SPF: pass (google.com: domain of silvano.cirujano-cuesta@siemens.com designates 40.107.22.68 as permitted sender) client-ip=40.107.22.68; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.onmicrosoft.com header.s=selector1-siemens-onmicrosoft-com header.b=lSCtV+DA; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of silvano.cirujano-cuesta@siemens.com designates 40.107.22.68 as permitted sender) smtp.mailfrom=silvano.cirujano-cuesta@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N/YiKUAzyvtltJfTmg3jKCa5KkdbuLv25BeNf6ZVOKzphpDc1AJ0FjN72KJKJ5tgpd5X9rWgLxqTcYKSN2YR3PuvQB6AENQX/46f99EMrSLVSCZ3FL90dDxV2InEKU2ZBG1MWD8A2BZ4bJbk3eEUgzvBzd5HgvZH7wlqhi5b6nblY7BtDu+PNq0ojKt7RGIVZjt8vhAGv4984Wr/TMZsYoy/gcnjXKVJzQVVuY6AxIlsSxA5XeaFMl0Qj65WhcZJf0AjJZyw7vHE1P6wir8x3+mB3IfIbJlJOmtXi07CBrGKGwznn9JS8NlL65tgzXj+ISQC1URkKHYLgCfxree+2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x4TOeo4+JVX+CFP2ssGbOYKRGnXjk007IwEGVbH4X74=; b=BhZGb/eR54Nxc4EFcEclJu2xZ2MBHnN0TfH3f1btG8wFPk8k3DikYz1L4cQ4vFrV+sPOKfvdDEsIcXtkAFz8ZBq4k9QRr0MTIv0/grmZRwJF3Y2TWqCfe/OTDBps1vb1J8I6WoyyHzwTDJToYTk6H0QVHpYHvyJNxy3I7fxnVi9HRcGOi6rZ3NCSRMX4IE23nzsYSGsfJ1/9fVc8EIvu0/VvtRlSPR1vIPG0sI/mDCRSaUE62SCGGMzDC07ET5/fePNDhie05GvRJ+3KeQlfPni42tWhjEgzbaCdiaTMpE002elLVSEBQqduAXTMGnT0juSxxoNJSgACcYoekAEdZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.onmicrosoft.com; s=selector1-siemens-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x4TOeo4+JVX+CFP2ssGbOYKRGnXjk007IwEGVbH4X74=; b=lSCtV+DAx2Pxtjv5CzBYXeZWTCY3zSv9S+tuOPRGBH/Z1SXWkCW4r7XfEkczD9hsl9IJu4CkixcZzww6+mf/DtLWt5dlkAU+1ArC2mgOTOmESHRMRwAFlxXkMu8IwVleP0Ex+Cf73fNbmW7WTjC48B1iJ+GnjovuueeesrrVWuM= Authentication-Results: googlegroups.com; dkim=none (message not signed) header.d=none;googlegroups.com; dmarc=none action=none header.from=siemens.com; Received: from AM0PR10MB2708.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:12a::30) by AM9PR10MB4056.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:1f5::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.10; Tue, 19 Jan 2021 08:50:29 +0000 Received: from AM0PR10MB2708.EURPRD10.PROD.OUTLOOK.COM ([fe80::c035:62d1:fd79:1bc8]) by AM0PR10MB2708.EURPRD10.PROD.OUTLOOK.COM ([fe80::c035:62d1:fd79:1bc8%5]) with mapi id 15.20.3742.012; Tue, 19 Jan 2021 08:50:29 +0000 Subject: Re: image-postproc-extension.bbclass modifying /etc/os-release To: Henning Schild , Claudius Heine Cc: isar-users@googlegroups.com References: <67e1fac9-5af5-29aa-de57-9a0de0cdd165@siemens.com> <79cdea42-8338-2e7f-33dd-f396db634a14@siemens.com> <20210119092531.2cc80db5@md1za8fc.ad001.siemens.net> <20210119093324.52410271@md1za8fc.ad001.siemens.net> From: Silvano Cirujano Cuesta Message-ID: <34c9ad2c-a330-0074-cfd1-bffa1afcbd02@siemens.com> Date: Tue, 19 Jan 2021 09:50:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 In-Reply-To: <20210119093324.52410271@md1za8fc.ad001.siemens.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [2001:a61:3ba9:3102:e458:f9ae:a68a:ac3d] X-ClientProxiedBy: AM9P193CA0017.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:21e::22) To AM0PR10MB2708.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:12a::30) Return-Path: silvano.cirujano-cuesta@siemens.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2001:a61:3ba9:3102:e458:f9ae:a68a:ac3d] (2001:a61:3ba9:3102:e458:f9ae:a68a:ac3d) by AM9P193CA0017.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:21e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.10 via Frontend Transport; Tue, 19 Jan 2021 08:50:29 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: fb6a5b02-cdb7-4a01-fe77-08d8bc5745c5 X-MS-TrafficTypeDiagnostic: AM9PR10MB4056: X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EDkl7XWP13QECRdMljpkylCepPIExWlU/1pQnJ9jcvUSErLniYBrjXorNwp4n043y3r8deCDzbIPE1GU8VS+cfmQDlQkMvQkDmCUd1pZqz8P22tm4hpgC1nWowawldYscDys248Xy25FEy047F4A+g/hT3GsNrX3YcBasRahSMZIqKQvKmVD3ezhJqO60o8y2TjbH2xM9MnaTviR1KHNhh4jaAYqj/hohlmgFl3f0XuWlNhB2l5fTe/sYQspipGKJUB9gdzC57NbYZ9S8fULBv3Csr+Y56uUaNj50FEg+gbBpQTUdIMZhtFTHORNSCV/whJOhXw3I4CUQSsWwJvkD9Ajp2Qwsh33Ukn3HOL/sNcOWQgmZJ7GeBp69LF9vMLY8qP+iIXy/1zh/0/5IH+8+wZhdV+kVpTFRrRpSyqopIaM89Y/Z4PfeVoIjHm0frV0rA5hsgIZ5JZszPcFfk81TR8xXD2b6GqIfN2QsNOXRP+S7avKcUZOQVc7rf/ovbaVAFZH+pTCF+X1Ik2eoD1gUJ4vYoAVBblrtgubOo0cU9KRRSdzZwvZoCttwvgUoPKD X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR10MB2708.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(366004)(136003)(376002)(396003)(346002)(83380400001)(5660300002)(110136005)(478600001)(66946007)(8676002)(66556008)(966005)(31696002)(316002)(6486002)(2906002)(66476007)(4326008)(8936002)(16526019)(36756003)(186003)(31686004)(2616005)(86362001)(53546011)(45080400002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?WDJ1N1V3d1RKVk0vNDl1Nnh2UCtRMjNtWjcyZFBFUHBsbjl3R3crODFYUmxu?= =?utf-8?B?ajVhZnZOWUM3Y3lJU01pS0xWU0NjdFRtbXF0aE1hNzAvVXN2WlUwdjB5VUNw?= =?utf-8?B?T1J3QklvWlYvMFNSdWtKa0dVT3B0UnBWU3psSHVTZHZkaWtlRWRXanhIK3Z0?= =?utf-8?B?QnQ0MWw5ZHVlUTJYelhiODV3ejJZanZYZ2RZMjNhM2YwaU4rWllHOTJsN2Mr?= =?utf-8?B?Q2IyL3J0bmZPVXJvb2hQWFJucHhleENkbUtqZEdqRkpoZFZ5ZGJDTjJxWmF4?= =?utf-8?B?VWdxbEpTRnRpbXoreXVlcHU4OUVZelk0cC9GbzFjUHpERm55b1NGZkVweFVO?= =?utf-8?B?Q0YySEVGdm8zalBJSUFkbXZQYzZBbEo3ekFoQTF1WS9lSG1yWGQzQXhwQmU0?= =?utf-8?B?ZmVzOCtFemFpODhVTDFnRWI2ZytZcEVLZEltZU9BT1pUem1ySUJWNVh2ZUVy?= =?utf-8?B?N3VRYmRiYUVOSTRtU3FXLzdHcXphL1l5QytCc0U1M0czSHk1VXFWeDNndmZu?= =?utf-8?B?d2pIMW5BajE1RExhcTRlcDB5TEx1bmJ2eHpUUGZ2K0J1eUU2dC9JRXZzRHFs?= =?utf-8?B?R3BsaHRLUTNXL2IzczkwemdlcEVYcEl3d2ZpQldka0hjVjIvWlNwSi9mUEJ1?= =?utf-8?B?RExMUk9PWjhkdGZQckJkQ2tzT0NKTDdXbXBpMStFb0UzWWJVU1VFczl0dC92?= =?utf-8?B?QkxMQkV5Q2g5aGRvdlRGRG5pNWJhQVlqMjBqZ2JpelNKQU1jU3FLK053MHRL?= =?utf-8?B?aGhKbmtPQ25Td1ljalVFb3BoVWs1MC96QmJvUXl6VlA2VWRRb2NkNWZ3MjZD?= =?utf-8?B?eTY1Zm1YT3NTVFVlYjBmQ2hYOG9aUzBzbjAvSDF0TzNHb0JaUVA1TTd0V3dF?= =?utf-8?B?WmtZVVRidElsWWpiejZVWEFJWUpZajZsZ3FMTGRNY1pvemhJYlFyZU1CaE9G?= =?utf-8?B?UVFTQXhyakVXS2wvVm1idVZ4R3hRTURHNDAxdXd1RElvZytvWE82YW4vVmNZ?= =?utf-8?B?YWo0RFNUVGlkVTVmbkVsLzBkTFNOVjlDcGhWV0EvYkwwbEhNUExUVG00OVNo?= =?utf-8?B?YXk4Z3Y3QTd1SlNMYWJyQnhMNU1SamhvOEp5YXkvczZMRS9GQnl0SVhPRURk?= =?utf-8?B?eTBBckY3MmV0UDAyVWt1bHV3SlI0ZHoxOCsyL1d6ZWFOL0pSMEpOeFpsVERI?= =?utf-8?B?MWxWNS8wdzVJbTFuaG92TCtnVEwzdGJGTXNZemg5bkZ2ZlhLaVZJNUF0OXNs?= =?utf-8?B?Y3JBTDBhMlNGRzQ3R1FnbXVzWHZqbGFBQ3hvN25abi91TkZaWTkvby9tYmE5?= =?utf-8?B?bEdtZ01vU2dHS3I2OXNic0N5UjdZdmxWYmNZTGZyMjNKdStsT1J0bjVIRXVJ?= =?utf-8?B?QjI3c0c1WEIyWHBVOFhtaW5VRUFXeU0wZW1VZ3orTU5ZejNydm9uMy8rT1J6?= =?utf-8?Q?yYvdCVDe?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: fb6a5b02-cdb7-4a01-fe77-08d8bc5745c5 X-MS-Exchange-CrossTenant-AuthSource: AM0PR10MB2708.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2021 08:50:29.4254 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +gyImS1ghSH4N5E267XOjupaECOY1a4FpCa7H4CE+zhLSpJdODsDFEktPO0cuJVzTrDv6QC7XqsENmFNFS3xSUcMN3Y8eBPxD138z9RgKsmIudqfYbQ7GZUEc19trq7q X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR10MB4056 X-TUID: MsQs3JUKI1ti On 19/01/2021 09:33, Henning Schild wrote: > Am Tue, 19 Jan 2021 09:25:31 +0100 > schrieb "[ext] Henning Schild" : > >> Am Mon, 18 Jan 2021 13:35:53 +0100 >> schrieb Claudius Heine : >> >>> Hi Silvano, >>> >>> On 2021-01-18 12:35, Silvano Cirujano Cuesta wrote: >>>> I might try to provide a fix, if we agree that the current >>>> implementation has an issue. >>>> >>>> @Claudius: you wrote the original code [1]. Do you remember why >>>> you implemented it this way? Do you remember if you were aware of >>>> the issue I mentioned and you provided a mitigation for the issue >>>> that I see (assuming my analysis is right)? >>>> >>>> [1] >>>> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Filbers%2Fisar%2Fcommit%2F13ce96e5bc84b60f2fa7ccfe93dde045461884e6&data=04%7C01%7Csilvano.cirujano-cuesta%40siemens.com%7Cc75c1ca076a0460e8a2a08d8bc54e4dd%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C637466420092677953%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=c3d3xPuWoZC616jMfcDeqo9g1zolQIYgHsN%2FdKc1RC8%3D&reserved=0 >>>> >>>>   Silvano >>>> >>>> On 15/01/2021 15:26, [ext] Silvano Cirujano Cuesta wrote: >>>>> Hi, >>>>> >>>>> I've noticed that '/etc/os-release' is being changed on the image >>>>> in meta/classes/image-postproc-extension.bbclass [1].  What BTW >>>>> ends up changing '/usr/lib/os-release', since it's only a >>>>> symlink. But both '/etc/os-release' and '/usr/lib/os-release' >>>>> are owned by 'base-files'... >>>>> >>>>> An upgrade of 'base-files' would be replacing (silently, since is >>>>> not marked as a configuration file) '/usr/lib/os-release' with >>>>> the version of the upstream 'base-files' package and possibly >>>>> breaking any tools in the system relying on certain values in >>>>> that file. >>>>> >>>>> Is there a reason that I'm missing for doing so instead of the >>>>> Debian-way (file diversion with dpkg-divert)? Or any hack that >>>>> I've overseen that avoids the mentioned breakage? >>> Interesting, I didn't remember that `/etc/os-release` is a symlink, >>> could that be something that has changed in more recent debian >>> versions? >>> >>> If so then, of course that needs to be fixed. >> the problem seems to be that it is a symlink, otherwise one would >> assume that changes in /etc/ are allowed and covered by the config >> file exception and will be subject to merging if an updated package >> comes around. >> >> My guess would be that we need to >> - make it a copy instead of a symlink >> - modify it > Alternative would be to create /etc/os-release-isar as that modified > copy, and replace the symlink target /etc/os-release -> > /etc/os-release-isar No, nothing touching /etc/os-release off-band will block "base-files" from restoring it. Creating another package touching /etc/os-release will create a conflict that will be detected by dpkg. Either upstream "base-files" is not there or we create a file diversion for /etc/os-release. IMO we are creating a Debian Derivative and as therefore I'd consider their re-/de-branding guidelines (see separate thread). > > We can not have the modified file be part of any package, at least not > with its final content. The version control command has to happen on > every rootfs build and has to come "late", and a package would not have > that property. Plus a package would become subject to potential false > sharing in the multiconfig case ... The fields we change are mostly > image-properties, and not generic Image post-processing is deemed to fail. Sorry, I don't understand what you mean with "a package would become subject to potential false sharing in the multiconfig case". A package created on build-time can contain those image properties, right? I might be missing something...    Silvano > > Henning > >> In this case an update of the base-files package should leave it alone >> or ask for a merge. And i think that would be OK behaviour. >> >> Henning >> >>> regards, >>> Claudius >>> -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux