Re: [PATCH 1/2] isar: Change build folders tree

[Alexander Smirnov <asmirnov@ilbers.de>]

On 09/09/2017 12:39 PM, Claudius Heine wrote:
> Hi,
> 
> On Fri, 2017-09-08 at 15:36 +0300, Alexander Smirnov wrote:
>>>>     
>>>>     BUILDCHROOT_PREINSTALL ?= "gcc \
>>>>                                make \
>>>> @@ -21,8 +22,6 @@ BUILDCHROOT_PREINSTALL ?= "gcc \
>>>>                                apt \
>>>>                                automake"
>>>>     
>>>> -WORKDIR = "${TMPDIR}/work/${PF}/${DISTRO}"
>>>> -
>>>>     do_build[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
>>>>     
>>>>     do_build() {
>>>> @@ -40,9 +39,9 @@ do_build() {
>>>>         sed -i 's|##DISTRO_APT_SOURCE##|${DISTRO_APT_SOURCE}|'
>>>> ${WORKDIR}/multistrap.conf sed -i
>>>> 's|##DISTRO_SUITE##|${DISTRO_SUITE}|' ${WORKDIR}/multistrap.conf
>>>> sed
>>>> -i 's|##DISTRO_COMPONENTS##|${DISTRO_COMPONENTS}|'
>>>> ${WORKDIR}/multistrap.conf
>>>> -    sed -i
>>>> 's|##CONFIG_SCRIPT##|./tmp/work/${PF}/${DISTRO}/configscript.sh|'
>>>> ${WORKDIR}/multistrap.conf
>>>> -    sed -i
>>>> 's|##SETUP_SCRIPT##|./tmp/work/${PF}/${DISTRO}/setup.sh|'
>>>> ${WORKDIR}/multistrap.conf
>>>> -    sed -i
>>>> 's|##DIR_HOOKS##|./tmp/work/${PF}/${DISTRO}/hooks_multistrap|'
>>>> ${WORKDIR}/multistrap.conf
>>>> +    sed -i
>>>> 's|##CONFIG_SCRIPT##|./tmp/work/${DISTRO}-
>>>> ${DISTRO_ARCH}/${PF}/configscript.sh|'
>>>> ${WORKDIR}/multistrap.conf
>>>> +    sed -i
>>>> 's|##SETUP_SCRIPT##|./tmp/work/${DISTRO}-
>>>> ${DISTRO_ARCH}/${PF}/setup.sh|'
>>>> ${WORKDIR}/multistrap.conf
>>>> +    sed -i
>>>> 's|##DIR_HOOKS##|./tmp/work/${DISTRO}-
>>>> ${DISTRO_ARCH}/${PF}/hooks_multistrap|'
>>>> ${WORKDIR}/multistrap.conf
>>>
>>> The pattern tmp/work/${DISTRO}-${DISTRO_ARCH}/${PF}/ shows up all
>>> the
>>> time, can that be derived from $WORKDIR instead of writing it down
>>> again and again?
>>
>> That's mad, but mulstistrap understands relative paths only. Any
>> attempt
>> to replace it by absolute path lead to errors. That's why it was done
>> in
>> this way, because WORKDIR is absolute path. :-(
> 
> If only multistrap cannot deal with absolute paths, why not use
> `os.path.relpath` in these instances?


Didn't know about this, let me try...

Alex