Re: [PATCH v4 0/5] Debootstrap integration

[Jan Kiszka <jan.kiszka@siemens.com>]

On 2018-03-07 20:51, [ext] Jan Kiszka wrote:
> On 2018-03-07 17:44, [ext] claudius.heine.ext@siemens.com wrote:
>> From: Claudius Heine <ch@denx.de>
>>
>> Hi,
>>
>> sorry, just saw a small error, some changes to isar-bootstrap got into
>> the buildchroot patch.
>>
>> Cheers,
>> Claudius
>>
>> Changes from v3:
>>   - A small modification to isar-bootstrap.bb snuck into the buildchroot
>>     patch.
>>
>> Changes from v2:
>>   - rebased to current next
>>   - added missing newlines at the end of file
>>   - use cleandirs with root permissions
>>     this could be improved in some later patch series, so that this
>>     feature can be shared.
>>   - moved main source url of packages to apt source list files of the
>>     distributions:
>>     - Implemented some basic parsing of source.lists files in
>>       isar-bootstrap.
>>     - Made 'DISTRO_SUITE', 'DISTRO_APT_SOURCE' and 'DISTRO_COMPONENTS'
>>       variables obsolete.
>>   - implemented repo key fetching to support rasbian repositories
>>   - now the clean task removes the symlink of isar-bootstrap deploy task
>>
>> Changes from v1:
>>   - rebased to current next
>>   - added unmounting of /dev and /proc at the end of do_rootfs in isar-image-base
>>     This was necessary for image file creation, otherwise it tried to
>>     package stuff from the host.
>>   - added 'isar-bootstrap:do_deploy' dependency to do_rootfs task in
>>     image.bbclass.
>>   - Changed 'RFSDIR' variable name to 'ROOTFSDIR' in
>>     isar-bootstrap-helper.bbclass to be consistent with the variable
>>     name in isar-bootstrap.bb
>>   - Moved 'isar-apt' apt-preference settings from isar-bootstrap.bb to
>>     isar-bootstrap-helper.bbclass
>>   - Removed '--no-install-recommends' parameters in favor of adding the
>>     apt configuration in 'isar-bootstrap.bb'
>>   - unmount and remove possible existing bootstraped directories before
>>     bootstrapping in do_bootstrap task of 'isar-bootstrap.bb'
>>   - changed from /dev ro bind mounts to mounting devtmpfs to /dev to be
>>     consistent with the other places where /dev is mounted.
>>
>>
>> Claudius Heine (5):
>>   implement isar-bootstrap using debootstrap
>>   meta/isar-bootstrap-helper.bbclass: handle rfs customization centrally
>>   meta/buildchroot: switch to using isar-bootstrap
>>   meta-isar/isar-image-base: switch to using isar-bootstrap
>>   meta-isar/multiconfig: remove multistrap references
>>
>>  meta-isar/conf/distro/debian-jessie.conf           |   9 +-
>>  meta-isar/conf/distro/debian-jessie.list           |   3 +
>>  meta-isar/conf/distro/debian-stretch.conf          |   7 +-
>>  meta-isar/conf/distro/debian-stretch.list          |   3 +
>>  meta-isar/conf/distro/debian-wheezy.conf           |   9 +-
>>  meta-isar/conf/distro/debian-wheezy.list           |   3 +
>>  meta-isar/conf/distro/raspbian-jessie.conf         |  12 +-
>>  meta-isar/conf/distro/raspbian-jessie.list         |   1 +
>>  meta-isar/conf/local.conf.sample                   |   4 +-
>>  meta-isar/conf/multiconfig/qemuarm-jessie.conf     |   2 +-
>>  meta-isar/conf/multiconfig/qemuarm-wheezy.conf     |   2 +-
>>  meta-isar/conf/multiconfig/rpi-jessie.conf         |   2 +-
>>  .../recipes-core/images/files/download_dev-random  |  24 ---
>>  .../recipes-core/images/files/multistrap.conf.in   |  38 ----
>>  meta-isar/recipes-core/images/files/setup.sh       |  77 --------
>>  meta-isar/recipes-core/images/isar-image-base.bb   |  64 +++----
>>  meta/classes/image.bbclass                         |   2 +-
>>  meta/classes/isar-bootstrap-helper.bbclass         |  39 ++++
>>  .../isar-bootstrap/files/isar-apt.conf             |   2 +
>>  meta/recipes-core/isar-bootstrap/isar-bootstrap.bb | 205 +++++++++++++++++++++
>>  meta/recipes-devtools/buildchroot/buildchroot.bb   |  59 ++----
>>  meta/recipes-devtools/buildchroot/files/build.sh   |   2 +-
>>  .../buildchroot/files/configscript.sh              |  10 -
>>  .../buildchroot/files/multistrap.conf.in           |  37 ----
>>  meta/recipes-devtools/buildchroot/files/setup.sh   |  82 ---------
>>  25 files changed, 310 insertions(+), 388 deletions(-)
>>  create mode 100644 meta-isar/conf/distro/debian-jessie.list
>>  create mode 100644 meta-isar/conf/distro/debian-stretch.list
>>  create mode 100644 meta-isar/conf/distro/debian-wheezy.list
>>  create mode 100644 meta-isar/conf/distro/raspbian-jessie.list
>>  delete mode 100644 meta-isar/recipes-core/images/files/download_dev-random
>>  delete mode 100644 meta-isar/recipes-core/images/files/multistrap.conf.in
>>  delete mode 100755 meta-isar/recipes-core/images/files/setup.sh
>>  create mode 100644 meta/classes/isar-bootstrap-helper.bbclass
>>  create mode 100644 meta/recipes-core/isar-bootstrap/files/isar-apt.conf
>>  create mode 100644 meta/recipes-core/isar-bootstrap/isar-bootstrap.bb
>>  delete mode 100644 meta/recipes-devtools/buildchroot/files/multistrap.conf.in
>>  delete mode 100755 meta/recipes-devtools/buildchroot/files/setup.sh
>>
> 
> FWIW, I've successfully built all CI targets locally just now. No time
> to test the result, though.

Images also run, and I was specifically able to build and run the next
branch of jailhouse-images with these patches applied. Looks very good!
And I also like "310 insertions(+), 388 deletions(-)" a lot. :)

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux