Re: [PATCH] dpkg: acquire a read (shared) locks while building packages

[cedric_hombourger@mentor.com]

[-- Attachment #1.1: Type: text/plain, Size: 1062 bytes --]



On Friday, March 8, 2019 at 11:04:12 AM UTC+1, Jan Kiszka wrote:
>
> > diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass 
> > index 24b9fe3..f4e3d7a 100644 
> > --- a/meta/classes/dpkg.bbclass 
> > +++ b/meta/classes/dpkg.bbclass 
> > @@ -19,5 +19,6 @@ do_install_builddeps[stamp-extra-info] = 
> "${DISTRO}-${DISTRO_ARCH}" 
> >   # Build package from sources using build script 
> >   dpkg_runbuild() { 
> >       E="${@ bb.utils.export_proxies(d)}" 
> > +    flock -s "${REPO_ISAR_DIR}/isar.lock" \ 
> >       sudo -E chroot --userspec=$( id -u ):$( id -g ) ${BUILDCHROOT_DIR} 
> /isar/build.sh ${PP}/${PPS} ${DISTRO_ARCH} 
> >   } 
> > 
>
> Couldn't we have the same issue with dpkg-base derived classes? The 
> kernel? Or 
> downstream classes? IOW, shouldn't this go to the caller of dpkg_runbuild?


I do understand the intent but I don't think we can do something like:
flock -s <lock-file> dpkg_runbuild

is there another flock construct we could use to get around this?

I can update the patch to correct the typo in the commit log
 

[-- Attachment #1.2: Type: text/html, Size: 1427 bytes --]