Re: [PATCH] installer: use /run for abort trigger and drop systemd-tmpfs-tmp

[Zhihang Wei <wzh@ilbers.de>]

Applied to next, thanks.

Zhihang

On 4/13/26 12:27, 'Badrikesh Prusty' via isar-users wrote:
> Switch unattended abort trigger from /tmp to /run to rely on default
> tmpfs.
>
> Drop the systemd-tmpfs-tmp recipe and dependency, removing custom
> tmp.mount setup as it is no longer needed.
>
> Signed-off-by: Badrikesh Prusty <badrikesh.prusty@siemens.com>
> ---
>   .../deploy-image/deploy-image_0.1.bb             |  3 +--
>   .../files/usr/bin/deploy-image-wic.sh            |  6 +++---
>   .../systemd-tmpfs-tmp/files/postinst             | 16 ----------------
>   .../systemd-tmpfs-tmp/systemd-tmpfs-tmp_0.1.bb   | 13 -------------
>   4 files changed, 4 insertions(+), 34 deletions(-)
>   delete mode 100644 meta-isar/recipes-installer/systemd-tmpfs-tmp/files/postinst
>   delete mode 100644 meta-isar/recipes-installer/systemd-tmpfs-tmp/systemd-tmpfs-tmp_0.1.bb
>
> diff --git a/meta-isar/recipes-installer/deploy-image/deploy-image_0.1.bb b/meta-isar/recipes-installer/deploy-image/deploy-image_0.1.bb
> index 03b082a9..44b96c27 100644
> --- a/meta-isar/recipes-installer/deploy-image/deploy-image_0.1.bb
> +++ b/meta-isar/recipes-installer/deploy-image/deploy-image_0.1.bb
> @@ -13,8 +13,7 @@ SRC_URI = "file://usr/bin/deploy-image-wic.sh \
>             "
>   
>   DEPENDS:append:bookworm = " bmap-tools"
> -DEPENDS:append = " systemd-tmpfs-tmp"
> -DEBIAN_DEPENDS = "bmap-tools, pv, dialog, util-linux, parted, fdisk, gdisk, pigz, procps, systemd-tmpfs-tmp, xz-utils, pbzip2, zstd"
> +DEBIAN_DEPENDS = "bmap-tools, pv, dialog, util-linux, parted, fdisk, gdisk, pigz, procps, xz-utils, pbzip2, zstd"
>   do_install[cleandirs] = "${D}/usr/bin/ \
>                            ${D}/usr/lib/deploy-image-wic \
>                           "
> diff --git a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
> index 60944e58..9a4102b2 100755
> --- a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
> +++ b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
> @@ -11,12 +11,12 @@ SCRIPT_DIR=$( dirname -- "$( readlink -f -- "$0"; )"; )
>   . "${SCRIPT_DIR}/../lib/deploy-image-wic/handle-config.sh"
>   
>   if [ "$installer_unattended" = true ] && [ "$installer_unattended_abort_enable" = true ]; then
> -    abort_file=/tmp/attended_mode_trigger
> +    abort_file=/run/attended_mode_trigger
>       for ((i=$installer_unattended_abort_timeout; i>0; i--)); do
>           echo -ne "\rUnattended installation will start in $i seconds. Press any key to switch to attended mode..."
>   
> -	# Switch to attended mode if the abort file exists or any key pressed during countdown
> -	# Create abort file to notify all other console instances to abort
> +        # Switch to attended mode if the abort file exists or any key pressed during countdown
> +        # Create abort file to notify all other console instances to abort
>           if [ -f "$abort_file" ] || read -n 1 -t 1; then
>               installer_unattended=false
>               touch "$abort_file"
> diff --git a/meta-isar/recipes-installer/systemd-tmpfs-tmp/files/postinst b/meta-isar/recipes-installer/systemd-tmpfs-tmp/files/postinst
> deleted file mode 100644
> index 9d75025d..00000000
> --- a/meta-isar/recipes-installer/systemd-tmpfs-tmp/files/postinst
> +++ /dev/null
> @@ -1,16 +0,0 @@
> -#!/bin/sh
> -
> -set -e
> -
> -DEST="/etc/systemd/system/tmp.mount"
> -
> -if [ ! -e "${DEST}" ]; then
> -    # Possible source paths for tmp.mount
> -    for SRC in /usr/share/systemd/tmp.mount /usr/lib/systemd/system/tmp.mount; do
> -        # If the source file exists, copy it to the destination and exit the loop
> -        [ -e "${SRC}" ] && cp ${SRC} ${DEST} && break
> -    done
> -fi
> -
> -# Enable the mount unit using deb-systemd-helper; ignore errors if it fails
> -deb-systemd-helper enable tmp.mount || true
> diff --git a/meta-isar/recipes-installer/systemd-tmpfs-tmp/systemd-tmpfs-tmp_0.1.bb b/meta-isar/recipes-installer/systemd-tmpfs-tmp/systemd-tmpfs-tmp_0.1.bb
> deleted file mode 100644
> index 3112245e..00000000
> --- a/meta-isar/recipes-installer/systemd-tmpfs-tmp/systemd-tmpfs-tmp_0.1.bb
> +++ /dev/null
> @@ -1,13 +0,0 @@
> -# This software is a part of Isar.
> -# Copyright (C) Siemens AG, 2025
> -#
> -# SPDX-License-Identifier: MIT
> -
> -inherit dpkg-raw
> -
> -DESCRIPTION = "Configures /tmp as systemd-managed temporary filesystem (tmpfs), ensuring read-write access even if rootfs is read-only"
> -MAINTAINER = "isar-users <isar-users@googlegroups.com>"
> -
> -SRC_URI = "file://postinst"
> -
> -DEBIAN_DEPENDS = "systemd"

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/3601ea0e-68bc-4204-a5ae-63914e228902%40ilbers.de.