From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7150622362639007744 X-Received: by 2002:a17:906:db05:b0:741:5730:270e with SMTP id xj5-20020a170906db0500b007415730270emr18574328ejb.609.1664884482939; Tue, 04 Oct 2022 04:54:42 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:bb0a:b0:781:dc04:ef3e with SMTP id jz10-20020a170906bb0a00b00781dc04ef3els895466ejb.5.-pod-prod-gmail; Tue, 04 Oct 2022 04:54:41 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6HMDVhL/TGXCoeS03m8hvcCkjVjR+GIW4+XPy2bDr8nkW0Av7kgqTO+IA7nnUn3SqgFJvt X-Received: by 2002:a17:907:3e28:b0:782:81d:a4f9 with SMTP id hp40-20020a1709073e2800b00782081da4f9mr19034858ejc.558.1664884481610; Tue, 04 Oct 2022 04:54:41 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1664884481; cv=pass; d=google.com; s=arc-20160816; b=GeQCPrEXEpUIwozR3+MfV2sWxcgHsrMv4pKWl/doEMoZU93iScs/mKeVRyVttmfKbe HUaNqisbatezcWC1ups2nR2EMGSIoL99Pp6InB0yqBS2FHw1E5lqnCPKbVbzjsmVZB/Z uIH3tVqlv1mNPClvK9LO73tcvTt3wafCwsICPkhtSLIM3prH0FMkXaeuU5xEUAhee77B fbIhT8J+loHKBv5mYIlL1fPN5m6kPmW50BfUZ3oDNG9xGDLvC81Xmxp/Ov0TCv+/yh1l w4W9GszQRJKh29bJdtIU5m7DNXSv0pLJXW+ESru/tTI/K0qU3Bfzme+cDGIJM9t6Pj7j 5nZA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :dkim-signature; bh=Ey9bnJvVNBZrApohtHSNKeWmt7vR8oz89ayq681UUlk=; b=dDRXyg7Jy16TkaRP8zWVvfBdSkUOFj00ZiRq6Fckjfl1VFd8b7au6FtllmlWQ4JpHB lsFF6ooKsVIhATBnqB6fVfm6zYnofuDZIfzDB/ZXBbLVf3uLvph9elmnlMljTFY5Eh7c hADHCh+PTKdjCA2FeyGuAgR7GHr/2MWyc3q5BjaOkNzyx4iUnTOTIy0VeyKw/FvzRXqE FhgLGpnq3ODrx23ASJL61lGStVrUfH+ZWE4q9ivLNzGbSnmq4zoO5uKPfYogQUq0ZEXy Lca/jVq+LBzC+HQb6+pTy1OrwiB/hyJun+2nAWHom1yyZTo+6OMXodR2fHjiVXka54PT Htrg== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=w4kRudMf; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.21.59 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2059.outbound.protection.outlook.com. [40.107.21.59]) by gmr-mx.google.com with ESMTPS id n26-20020aa7c45a000000b00457860004cesi395509edr.0.2022.10.04.04.54.41 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Oct 2022 04:54:41 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.21.59 as permitted sender) client-ip=40.107.21.59; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=w4kRudMf; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.21.59 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TgHjC9urO7qM35ziZPhHlQRfWRxsGnfwaEPvXX6EQevuup+a2WFGWuN6xPipatDt/E47ZRyzSESMwHN0fJdLnsmuatiSdxzBP9mNnet/EXH4yZAQEumwSwzDWhMBQMF0P6rvzEMFngCHzM4VKufSt+cyjaXk4SIEfMBaw9IdGhzCxacjbzrDEciiY8Ja9mCJ4q0y/xnHybkWOsoFG3SH6zAcbxQSa68Y2csP8+um9+SUSIFq3KDWT2mgTIXsBkwAWrfrES7cDVwXE3VYd9xEnuQEs5kqTJBZAf7+WUv/oNfyOszihqX57TMJ5Nak8tQFLnv85ZUhavgqFfirADucpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ey9bnJvVNBZrApohtHSNKeWmt7vR8oz89ayq681UUlk=; b=nnQUOiJ0OyFiyjjWsaS+3XvKDDJFveDHrq51WqcGLV01c6WjyiVn+c5F6DdT5bGeu+yFN8IrCWqvsIaEtWIt83EvKaRGWELDecJPAWL3BTNZMbfX2UfthheHAN3JALT+CdOsapBLcIAkwdn4ykRd9qWAdiSmMK66THpPAMYWLFJNGZN+Xwh7JIeTpQ7MeLetYep0qtKPtEwVlGNV8vHQPJVhMrGbhKerPtQsGUKDHDF7MjOTvMC/PtXssxDez0lb8SEW5O0T6IfRZRuhHT63bakgVNgHPpr3OL6BOYE1qqeZIWW/SIraFa3x28PvyLpN6E7guDHJ5t1M4hbEZbmS9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 194.138.21.76) smtp.rcpttodomain=googlegroups.com smtp.mailfrom=siemens.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=siemens.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ey9bnJvVNBZrApohtHSNKeWmt7vR8oz89ayq681UUlk=; b=w4kRudMfa5jI8wmBElj/Z96R6IgXMQUrpP/8UkVqNk4r79BSUHFNpqykAOIIQoouMvkoS58qedMyKLu3IM192FucxJKy0WrqapV7OjgaFKpzr12GpaTTKothbWnAU9rogSMBbCGwOMPyWFFm5DyFikk3jdmULWiMHg52HnUPtM97V8DdaSxlF5tJFp703a0vgJ5SoavEmd6IuW5lTVmpFI2vwSnGJ9k/vYMG6baJDbweNPQ/C7+xwI1Bxu1R/zDCMqrwJkKuDJBiTpI3CjQDGdvCkOO+uBG2q1FoavTzdXAueGVAbkSAdhIYYotF7Z7ZpQvu6ohdKmzLLPgAof7yPA== Received: from FR0P281CA0121.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::19) by DBAPR10MB4108.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:1c5::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Tue, 4 Oct 2022 11:54:40 +0000 Received: from VE1EUR01FT032.eop-EUR01.prod.protection.outlook.com (2603:10a6:d10:97:cafe::39) by FR0P281CA0121.outlook.office365.com (2603:10a6:d10:97::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.30 via Frontend Transport; Tue, 4 Oct 2022 11:54:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 194.138.21.76) smtp.mailfrom=siemens.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=siemens.com; Received-SPF: Pass (protection.outlook.com: domain of siemens.com designates 194.138.21.76 as permitted sender) receiver=protection.outlook.com; client-ip=194.138.21.76; helo=hybrid.siemens.com; pr=C Received: from hybrid.siemens.com (194.138.21.76) by VE1EUR01FT032.mail.protection.outlook.com (10.152.2.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Tue, 4 Oct 2022 11:54:39 +0000 Received: from DEMCHDC89XA.ad011.siemens.net (139.25.226.103) by DEMCHDC8VSA.ad011.siemens.net (194.138.21.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.12; Tue, 4 Oct 2022 13:54:39 +0200 Received: from [167.87.50.151] (167.87.50.151) by DEMCHDC89XA.ad011.siemens.net (139.25.226.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.12; Tue, 4 Oct 2022 13:54:39 +0200 Message-ID: <362411aa-2aea-1c83-8c34-94d1b9154acc@siemens.com> Date: Tue, 4 Oct 2022 13:54:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH] image: remove / entry from fstab template Content-Language: en-US To: Henning Schild , CC: Felix Moessbauer References: <20221004114629.27275-1-henning.schild@siemens.com> From: Jan Kiszka In-Reply-To: <20221004114629.27275-1-henning.schild@siemens.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-Path: jan.kiszka@siemens.com X-Originating-IP: [167.87.50.151] X-ClientProxiedBy: DEMCHDC89XA.ad011.siemens.net (139.25.226.103) To DEMCHDC89XA.ad011.siemens.net (139.25.226.103) X-TM-AS-Product-Ver: SMEX-14.0.0.3080-8.6.1018-26680.007 X-TM-AS-Result: No-10--14.163600-8.000000 X-TMASE-MatchedRID: XYZjbEcsSe5o0FBZlmedTrZv+ayzmKtKPg9yfk4YC0ZZNYSHk3Zr0cqF E6gRdRObbDD7i2QfyEesgEG7z3115iUHDsJPFQuAo18lYeOuMNcUh606rb6lUBbwCXv1ucAPAhv JX5q+bOMdXtyyzrIOtzLk8G2qhCWTZzrAcxg4bAHQQKfAJT3uzE85Ae+vNy5zfJy8LojR0khLXP A26IG0hN9RlPzeVuQQyGyx/b8m3ydI/TiI98juzcLwCwig64UuKFbesJUuOxywWQIt56582y6My Pq4TWG5tsxVqq1TeAWSLvAQjXykCkGPbm3tak5+kZOl7WKIImrvXOvQVlExsHAruZnjhopu+gD2 vYtOFhgqtq5d3cxkNaxhj7dc/xAI0DEH28cmIO1Comar1kkkgV9xtspOe81MDk4Nc1cRTs8= X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--14.163600-8.000000 X-TMASE-Version: SMEX-14.0.0.3080-8.6.1018-26680.007 X-TM-SNTS-SMTP: B5065C2A3C80C0F7DD30AB951A1D2E963494C0414079ACF4D8B7B688922076EB2000:8 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1EUR01FT032:EE_|DBAPR10MB4108:EE_ X-MS-Office365-Filtering-Correlation-Id: 9123f7a6-c025-42f1-ed21-08daa5ff37ee X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Jv30Vx9SrL3uJk6g1aRYXWDU3PfPA5fpDAb/mtAwE2MuZD4/d4fVIVOZ2lY9tzeG2Ka9uLfgcV9lrgkOkjFvoZT5+Kx0HyzuEAiKpmx0vAk5mFiaCR5t/F54S0+f+SXLr6v87lurN7XM5uQs1Jjlrke097R8QvyFJf1j02hE/WJ9bI2VE6m4FEA7+dOjYWTr7ZtfbVu+4KYMEh+aTmDP40TGi+DG0UoDI3OhBaPLE2mJ+aZzdQyfZ7LYJP8SZEmVkC9AJP6YCsKEaeeouAjYdOveuSff/rUfuBwLi84E1eELCJ1UG9sBYIH32iamzFbBpUvU5LXx9n9TKJUhuPJqhC3QC/W8FMNeqmWS9dpG7oRFQy6uGKVKCwWPezW9NA5WJyxa7wlfO15Rt3wOAETTiSI1kgQt7WprmUKFAy/6l/tG7rXX6uQ0gB+vYWIo+o+2q2BSb7hOU/jwfF5Q8uR8ZGjtdOZUEhXFHdg0sGqZ+dGUBmIq6SA6K81O9ZnS1iwNVKwmZqWm0y4c/SDvdgUXZLWDRmfeFXD5E4s256jmSiw9ng/G+fzs8/yJ9MECVH89L2TbBbXnt09xN/THdbm76oKF7QAmNaBu531wQ6okE3oktqbPdsYTGddJCSg8SpgARBoklYVbTbts5DxjVHj46qi6sKoifnTFQmVhKxQylBlYBv4z591iztV7Cvm7ZGQdNYHZ3X5g/CdxbnsS4nZvZGr73yor5TgrgpTYeI3pWF5u+fpc2SaxwZQB+lnFOOqWMyu+vYO6ra50lAO6zADtJHQBwCj/Uc08RuIbaw1iHkuQn6OVRaLJZIEGvFcBmCm0GZcNtttmLvxT8hAPwlVQRzbi/QZ45NGfbKF6wWWnLAA= X-Forefront-Antispam-Report: CIP:194.138.21.76;CTRY:DE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:hybrid.siemens.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(396003)(376002)(39860400002)(451199015)(36840700001)(46966006)(40470700004)(6706004)(16576012)(110136005)(36860700001)(2906002)(40460700003)(8936002)(41300700001)(81166007)(44832011)(86362001)(356005)(31696002)(5660300002)(82960400001)(36756003)(82740400003)(316002)(4326008)(70206006)(70586007)(8676002)(40480700001)(53546011)(82310400005)(26005)(107886003)(83380400001)(47076005)(31686004)(478600001)(186003)(16526019)(2616005)(956004)(336012)(3940600001)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 11:54:39.9526 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9123f7a6-c025-42f1-ed21-08daa5ff37ee X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38ae3bcd-9579-4fd4-adda-b42e1495d55a;Ip=[194.138.21.76];Helo=[hybrid.siemens.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR01FT032.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR10MB4108 X-TUID: PAPANTNmdfuN On 04.10.22 13:46, Henning Schild wrote: > An fstab entry for / should usually not be required. It just makes a > rootfs less portable (USB vs. NFS, vs. SSD). The kernel is the one > that should know which fs to mount and how. That is done via a bootloader. > > Should additional mount options be needed for a concrete image, an > imager like wic might add an entry. i.e. for adding fspassno or > x-systemd.growfs > > So to make the rootfs more generic and to allow imagers to add their > individual / lines, instead of having to modify an existing one, remove > the line from the template. > > Signed-off-by: Henning Schild > --- > meta/classes/image.bbclass | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass > index ccff81066178..d8d605d3af07 100644 > --- a/meta/classes/image.bbclass > +++ b/meta/classes/image.bbclass > @@ -327,7 +327,6 @@ image_configure_fstab[weight] = "2" > image_configure_fstab() { > sudo tee '${IMAGE_ROOTFS}/etc/fstab' << EOF > # Begin /etc/fstab > -/dev/root / auto defaults 0 0 > proc /proc proc nosuid,noexec,nodev 0 0 > sysfs /sys sysfs nosuid,noexec,nodev 0 0 > devpts /dev/pts devpts gid=5,mode=620 0 0 This works also for other imagers than wic? Just poking to avoid that we miss the case where this was once added for (if that exists). Jan -- Siemens AG, Technology Competence Center Embedded Linux