From: chombourger@gmail.com
To: isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH v3 1/3] dpkg: move installation of dependencies into dpkg_prepare
Date: Fri, 31 Aug 2018 01:33:34 -0700 (PDT) [thread overview]
Message-ID: <3681e5f1-6401-4453-980b-585049d14329@googlegroups.com> (raw)
In-Reply-To: <b9c53f8c-3fb3-39ab-d5ff-a11c0e82ec50@siemens.com>
[-- Attachment #1.1: Type: text/plain, Size: 4583 bytes --]
On Friday, August 31, 2018 at 10:28:51 AM UTC+2, Jan Kiszka wrote:
>
> Re-reading the patch with my new knowledge:
>
> On 2018-08-26 08:21, Cedric Hombourger wrote:
> > diff --git a/meta/recipes-kernel/linux-module/module.inc
> b/meta/recipes-kernel/linux-module/module.inc
> > index 3075f44..3a3cab1 100644
> > --- a/meta/recipes-kernel/linux-module/module.inc
> > +++ b/meta/recipes-kernel/linux-module/module.inc
> > @@ -17,7 +17,7 @@ AUTOLOAD ?= "0"
> >
> > inherit dpkg
> >
> > -dpkg_runbuild_prepend() {
> > +do_prepare_prepend() {
>
> Shouldn't that be dpgk_prepare_append()?
>
Wouldn't it be too late?
I am afraid that debian/control wouldn't be complete and prevent
installation of build dependencies
>
> > cp -r ${WORKDIR}/debian ${S}/
> > sed -i -e 's/@PN@/${PN}/g' -e 's/@PV@/${PV}/g' \
> > -e 's/@KERNEL_NAME@/${KERNEL_NAME}/g' \
> >
>
> Jan
>
> --
> Siemens AG, Corporate Technology, CT RDA IOT SES-DE
> Corporate Competence Center Embedded Linux
>
On Friday, August 31, 2018 at 10:28:51 AM UTC+2, Jan Kiszka wrote:
>
> Re-reading the patch with my new knowledge:
>
> On 2018-08-26 08:21, Cedric Hombourger wrote:
> > diff --git a/meta/recipes-kernel/linux-module/module.inc
> b/meta/recipes-kernel/linux-module/module.inc
> > index 3075f44..3a3cab1 100644
> > --- a/meta/recipes-kernel/linux-module/module.inc
> > +++ b/meta/recipes-kernel/linux-module/module.inc
> > @@ -17,7 +17,7 @@ AUTOLOAD ?= "0"
> >
> > inherit dpkg
> >
> > -dpkg_runbuild_prepend() {
> > +do_prepare_prepend() {
>
> Shouldn't that be dpgk_prepare_append()?
>
> > cp -r ${WORKDIR}/debian ${S}/
> > sed -i -e 's/@PN@/${PN}/g' -e 's/@PV@/${PV}/g' \
> > -e 's/@KERNEL_NAME@/${KERNEL_NAME}/g' \
> >
>
> Jan
>
> --
> Siemens AG, Corporate Technology, CT RDA IOT SES-DE
> Corporate Competence Center Embedded Linux
>
On Friday, August 31, 2018 at 10:28:51 AM UTC+2, Jan Kiszka wrote:
>
> Re-reading the patch with my new knowledge:
>
> On 2018-08-26 08:21, Cedric Hombourger wrote:
> > diff --git a/meta/recipes-kernel/linux-module/module.inc
> b/meta/recipes-kernel/linux-module/module.inc
> > index 3075f44..3a3cab1 100644
> > --- a/meta/recipes-kernel/linux-module/module.inc
> > +++ b/meta/recipes-kernel/linux-module/module.inc
> > @@ -17,7 +17,7 @@ AUTOLOAD ?= "0"
> >
> > inherit dpkg
> >
> > -dpkg_runbuild_prepend() {
> > +do_prepare_prepend() {
>
> Shouldn't that be dpgk_prepare_append()?
>
> > cp -r ${WORKDIR}/debian ${S}/
> > sed -i -e 's/@PN@/${PN}/g' -e 's/@PV@/${PV}/g' \
> > -e 's/@KERNEL_NAME@/${KERNEL_NAME}/g' \
> >
>
> Jan
>
> --
> Siemens AG, Corporate Technology, CT RDA IOT SES-DE
> Corporate Competence Center Embedded Linux
>
On Friday, August 31, 2018 at 10:28:51 AM UTC+2, Jan Kiszka wrote:
>
> Re-reading the patch with my new knowledge:
>
> On 2018-08-26 08:21, Cedric Hombourger wrote:
> > diff --git a/meta/recipes-kernel/linux-module/module.inc
> b/meta/recipes-kernel/linux-module/module.inc
> > index 3075f44..3a3cab1 100644
> > --- a/meta/recipes-kernel/linux-module/module.inc
> > +++ b/meta/recipes-kernel/linux-module/module.inc
> > @@ -17,7 +17,7 @@ AUTOLOAD ?= "0"
> >
> > inherit dpkg
> >
> > -dpkg_runbuild_prepend() {
> > +do_prepare_prepend() {
>
> Shouldn't that be dpgk_prepare_append()?
>
> > cp -r ${WORKDIR}/debian ${S}/
> > sed -i -e 's/@PN@/${PN}/g' -e 's/@PV@/${PV}/g' \
> > -e 's/@KERNEL_NAME@/${KERNEL_NAME}/g' \
> >
>
> Jan
>
> --
> Siemens AG, Corporate Technology, CT RDA IOT SES-DE
> Corporate Competence Center Embedded Linux
>
On Friday, August 31, 2018 at 10:28:51 AM UTC+2, Jan Kiszka wrote:
>
> Re-reading the patch with my new knowledge:
>
> On 2018-08-26 08:21, Cedric Hombourger wrote:
> > diff --git a/meta/recipes-kernel/linux-module/module.inc
> b/meta/recipes-kernel/linux-module/module.inc
> > index 3075f44..3a3cab1 100644
> > --- a/meta/recipes-kernel/linux-module/module.inc
> > +++ b/meta/recipes-kernel/linux-module/module.inc
> > @@ -17,7 +17,7 @@ AUTOLOAD ?= "0"
> >
> > inherit dpkg
> >
> > -dpkg_runbuild_prepend() {
> > +do_prepare_prepend() {
>
> Shouldn't that be dpgk_prepare_append()?
>
> > cp -r ${WORKDIR}/debian ${S}/
> > sed -i -e 's/@PN@/${PN}/g' -e 's/@PV@/${PV}/g' \
> > -e 's/@KERNEL_NAME@/${KERNEL_NAME}/g' \
> >
>
> Jan
>
> --
> Siemens AG, Corporate Technology, CT RDA IOT SES-DE
> Corporate Competence Center Embedded Linux
>
[-- Attachment #1.2: Type: text/html, Size: 6340 bytes --]
next prev parent reply other threads:[~2018-08-31 8:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 11:34 [PATCH 0/1] acquire database lock when calling reprepro Cedric Hombourger
2018-08-22 11:34 ` [PATCH 1/1] dpkg: acquire " Cedric Hombourger
2018-08-22 12:20 ` Jan Kiszka
2018-08-22 12:48 ` Hombourger, Cedric
2018-08-22 13:41 ` Henning Schild
2018-08-22 13:47 ` Hombourger, Cedric
2018-08-22 13:48 ` Jan Kiszka
2018-08-26 6:21 ` [PATCH v3 1/3] dpkg: move installation of dependencies into dpkg_prepare Cedric Hombourger
2018-08-26 6:21 ` [PATCH v3 2/3] linux: leverage dpkg_prepare to install build dependencies Cedric Hombourger
2018-08-26 6:21 ` [PATCH v3 3/3] dpkg+linux: use Isar's lock via do_prepare[lockfiles] instead of flock Cedric Hombourger
2018-08-28 12:12 ` [PATCH v3 1/3] dpkg: move installation of dependencies into dpkg_prepare Maxim Yu. Osipov
2018-08-31 8:10 ` Jan Kiszka
2018-08-31 8:15 ` chombourger
2018-08-31 8:21 ` Jan Kiszka
2018-08-31 8:28 ` Jan Kiszka
2018-08-31 8:33 ` chombourger [this message]
2018-08-31 8:41 ` Jan Kiszka
2018-08-31 9:05 ` Jan Kiszka
2018-09-01 6:58 ` Jan Kiszka
2018-09-01 8:44 ` Cedric Hombourger
2018-09-01 9:31 ` Jan Kiszka
2018-08-22 11:58 ` [PATCH 0/1] acquire database lock when calling reprepro Alexander Smirnov
2018-08-22 12:07 ` Hombourger, Cedric
2018-08-22 12:47 ` [PATCH v2] dpkg: acquire " Cedric Hombourger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3681e5f1-6401-4453-980b-585049d14329@googlegroups.com \
--to=chombourger@gmail.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox