From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6592507174472122368 Date: Fri, 31 Aug 2018 01:33:34 -0700 (PDT) From: chombourger@gmail.com To: isar-users Message-Id: <3681e5f1-6401-4453-980b-585049d14329@googlegroups.com> In-Reply-To: References: <20180822154145.07d4a2ca@md1pvb1c.ad001.siemens.net> <1535264488-128-1-git-send-email-Cedric_Hombourger@mentor.com> Subject: Re: [PATCH v3 1/3] dpkg: move installation of dependencies into dpkg_prepare MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_557_1201565163.1535704414743" X-Google-Token: EN76o9wFjNPUh4PsFII0 X-Google-IP: 192.94.31.2 X-TUID: 3b9J1Z47IBC/ ------=_Part_557_1201565163.1535704414743 Content-Type: multipart/alternative; boundary="----=_Part_558_1511672078.1535704414744" ------=_Part_558_1511672078.1535704414744 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On Friday, August 31, 2018 at 10:28:51 AM UTC+2, Jan Kiszka wrote: > > Re-reading the patch with my new knowledge: > > On 2018-08-26 08:21, Cedric Hombourger wrote: > > diff --git a/meta/recipes-kernel/linux-module/module.inc > b/meta/recipes-kernel/linux-module/module.inc > > index 3075f44..3a3cab1 100644 > > --- a/meta/recipes-kernel/linux-module/module.inc > > +++ b/meta/recipes-kernel/linux-module/module.inc > > @@ -17,7 +17,7 @@ AUTOLOAD ?= "0" > > > > inherit dpkg > > > > -dpkg_runbuild_prepend() { > > +do_prepare_prepend() { > > Shouldn't that be dpgk_prepare_append()? > Wouldn't it be too late? I am afraid that debian/control wouldn't be complete and prevent installation of build dependencies > > > cp -r ${WORKDIR}/debian ${S}/ > > sed -i -e 's/@PN@/${PN}/g' -e 's/@PV@/${PV}/g' \ > > -e 's/@KERNEL_NAME@/${KERNEL_NAME}/g' \ > > > > Jan > > -- > Siemens AG, Corporate Technology, CT RDA IOT SES-DE > Corporate Competence Center Embedded Linux > On Friday, August 31, 2018 at 10:28:51 AM UTC+2, Jan Kiszka wrote: > > Re-reading the patch with my new knowledge: > > On 2018-08-26 08:21, Cedric Hombourger wrote: > > diff --git a/meta/recipes-kernel/linux-module/module.inc > b/meta/recipes-kernel/linux-module/module.inc > > index 3075f44..3a3cab1 100644 > > --- a/meta/recipes-kernel/linux-module/module.inc > > +++ b/meta/recipes-kernel/linux-module/module.inc > > @@ -17,7 +17,7 @@ AUTOLOAD ?= "0" > > > > inherit dpkg > > > > -dpkg_runbuild_prepend() { > > +do_prepare_prepend() { > > Shouldn't that be dpgk_prepare_append()? > > > cp -r ${WORKDIR}/debian ${S}/ > > sed -i -e 's/@PN@/${PN}/g' -e 's/@PV@/${PV}/g' \ > > -e 's/@KERNEL_NAME@/${KERNEL_NAME}/g' \ > > > > Jan > > -- > Siemens AG, Corporate Technology, CT RDA IOT SES-DE > Corporate Competence Center Embedded Linux > On Friday, August 31, 2018 at 10:28:51 AM UTC+2, Jan Kiszka wrote: > > Re-reading the patch with my new knowledge: > > On 2018-08-26 08:21, Cedric Hombourger wrote: > > diff --git a/meta/recipes-kernel/linux-module/module.inc > b/meta/recipes-kernel/linux-module/module.inc > > index 3075f44..3a3cab1 100644 > > --- a/meta/recipes-kernel/linux-module/module.inc > > +++ b/meta/recipes-kernel/linux-module/module.inc > > @@ -17,7 +17,7 @@ AUTOLOAD ?= "0" > > > > inherit dpkg > > > > -dpkg_runbuild_prepend() { > > +do_prepare_prepend() { > > Shouldn't that be dpgk_prepare_append()? > > > cp -r ${WORKDIR}/debian ${S}/ > > sed -i -e 's/@PN@/${PN}/g' -e 's/@PV@/${PV}/g' \ > > -e 's/@KERNEL_NAME@/${KERNEL_NAME}/g' \ > > > > Jan > > -- > Siemens AG, Corporate Technology, CT RDA IOT SES-DE > Corporate Competence Center Embedded Linux > On Friday, August 31, 2018 at 10:28:51 AM UTC+2, Jan Kiszka wrote: > > Re-reading the patch with my new knowledge: > > On 2018-08-26 08:21, Cedric Hombourger wrote: > > diff --git a/meta/recipes-kernel/linux-module/module.inc > b/meta/recipes-kernel/linux-module/module.inc > > index 3075f44..3a3cab1 100644 > > --- a/meta/recipes-kernel/linux-module/module.inc > > +++ b/meta/recipes-kernel/linux-module/module.inc > > @@ -17,7 +17,7 @@ AUTOLOAD ?= "0" > > > > inherit dpkg > > > > -dpkg_runbuild_prepend() { > > +do_prepare_prepend() { > > Shouldn't that be dpgk_prepare_append()? > > > cp -r ${WORKDIR}/debian ${S}/ > > sed -i -e 's/@PN@/${PN}/g' -e 's/@PV@/${PV}/g' \ > > -e 's/@KERNEL_NAME@/${KERNEL_NAME}/g' \ > > > > Jan > > -- > Siemens AG, Corporate Technology, CT RDA IOT SES-DE > Corporate Competence Center Embedded Linux > On Friday, August 31, 2018 at 10:28:51 AM UTC+2, Jan Kiszka wrote: > > Re-reading the patch with my new knowledge: > > On 2018-08-26 08:21, Cedric Hombourger wrote: > > diff --git a/meta/recipes-kernel/linux-module/module.inc > b/meta/recipes-kernel/linux-module/module.inc > > index 3075f44..3a3cab1 100644 > > --- a/meta/recipes-kernel/linux-module/module.inc > > +++ b/meta/recipes-kernel/linux-module/module.inc > > @@ -17,7 +17,7 @@ AUTOLOAD ?= "0" > > > > inherit dpkg > > > > -dpkg_runbuild_prepend() { > > +do_prepare_prepend() { > > Shouldn't that be dpgk_prepare_append()? > > > cp -r ${WORKDIR}/debian ${S}/ > > sed -i -e 's/@PN@/${PN}/g' -e 's/@PV@/${PV}/g' \ > > -e 's/@KERNEL_NAME@/${KERNEL_NAME}/g' \ > > > > Jan > > -- > Siemens AG, Corporate Technology, CT RDA IOT SES-DE > Corporate Competence Center Embedded Linux > ------=_Part_558_1511672078.1535704414744 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable


On Friday, August 31, 2018 at 10:28:51 AM UTC+2, J= an Kiszka wrote:
Re-reading the= patch with my new knowledge:

On 2018-08-26 08:21, Cedric Hombourger wrote:
> diff --git a/meta/recipes-kernel/linux-module/module.inc b/me= ta/recipes-kernel/linux-module/module.inc
> index 3075f44..3a3cab1 100644
> --- a/meta/recipes-kernel/linux-module/module.inc
> +++ b/meta/recipes-kernel/linux-module/module.inc
> @@ -17,7 +17,7 @@ AUTOLOAD ?=3D "0"
> =C2=A0=20
> =C2=A0 inherit dpkg
> =C2=A0=20
> -dpkg_runbuild_prepend() {
> +do_prepare_prepend() {

Shouldn't that be dpgk_prepare_append()?

Wouldn't it be too late?
I am afraid that debian/control wouldn't be complete and prevent insta= llation of build dependencies
=C2=A0

> =C2=A0 =C2=A0 =C2=A0 cp -r ${WORKDIR}/debian ${S}/
> =C2=A0 =C2=A0 =C2=A0 sed -i -e 's/@PN@/${PN}/g' -e 's/= @PV@/${PV}/g' \
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0-e 's/@KERNEL_= NAME@/${KERNEL_NAME}/g' \
>=20

Jan

--=20
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

On Friday, August 31, 2018 at 10:28:51 AM UTC+2, Jan K= iszka wrote:
Re-reading the pat= ch with my new knowledge:

On 2018-08-26 08:21, Cedric Hombourger wrote:
> diff --git a/meta/recipes-kernel/linux-module/module.inc b/me= ta/recipes-kernel/linux-module/module.inc
> index 3075f44..3a3cab1 100644
> --- a/meta/recipes-kernel/linux-module/module.inc
> +++ b/meta/recipes-kernel/linux-module/module.inc
> @@ -17,7 +17,7 @@ AUTOLOAD ?=3D "0"
> =C2=A0=20
> =C2=A0 inherit dpkg
> =C2=A0=20
> -dpkg_runbuild_prepend() {
> +do_prepare_prepend() {

Shouldn't that be dpgk_prepare_append()?

> =C2=A0 =C2=A0 =C2=A0 cp -r ${WORKDIR}/debian ${S}/
> =C2=A0 =C2=A0 =C2=A0 sed -i -e 's/@PN@/${PN}/g' -e 's/= @PV@/${PV}/g' \
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0-e 's/@KERNEL_= NAME@/${KERNEL_NAME}/g' \
>=20

Jan

--=20
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

On Friday, August 31, 2018 at 10:28:51 AM UTC+2, Jan K= iszka wrote:
Re-reading the pat= ch with my new knowledge:

On 2018-08-26 08:21, Cedric Hombourger wrote:
> diff --git a/meta/recipes-kernel/linux-module/module.inc b/me= ta/recipes-kernel/linux-module/module.inc
> index 3075f44..3a3cab1 100644
> --- a/meta/recipes-kernel/linux-module/module.inc
> +++ b/meta/recipes-kernel/linux-module/module.inc
> @@ -17,7 +17,7 @@ AUTOLOAD ?=3D "0"
> =C2=A0=20
> =C2=A0 inherit dpkg
> =C2=A0=20
> -dpkg_runbuild_prepend() {
> +do_prepare_prepend() {

Shouldn't that be dpgk_prepare_append()?

> =C2=A0 =C2=A0 =C2=A0 cp -r ${WORKDIR}/debian ${S}/
> =C2=A0 =C2=A0 =C2=A0 sed -i -e 's/@PN@/${PN}/g' -e 's/= @PV@/${PV}/g' \
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0-e 's/@KERNEL_= NAME@/${KERNEL_NAME}/g' \
>=20

Jan

--=20
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

On Friday, August 31, 2018 at 10:28:51 AM UTC+2, Jan K= iszka wrote:
Re-reading the pat= ch with my new knowledge:

On 2018-08-26 08:21, Cedric Hombourger wrote:
> diff --git a/meta/recipes-kernel/linux-module/module.inc b/me= ta/recipes-kernel/linux-module/module.inc
> index 3075f44..3a3cab1 100644
> --- a/meta/recipes-kernel/linux-module/module.inc
> +++ b/meta/recipes-kernel/linux-module/module.inc
> @@ -17,7 +17,7 @@ AUTOLOAD ?=3D "0"
> =C2=A0=20
> =C2=A0 inherit dpkg
> =C2=A0=20
> -dpkg_runbuild_prepend() {
> +do_prepare_prepend() {

Shouldn't that be dpgk_prepare_append()?

> =C2=A0 =C2=A0 =C2=A0 cp -r ${WORKDIR}/debian ${S}/
> =C2=A0 =C2=A0 =C2=A0 sed -i -e 's/@PN@/${PN}/g' -e 's/= @PV@/${PV}/g' \
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0-e 's/@KERNEL_= NAME@/${KERNEL_NAME}/g' \
>=20

Jan

--=20
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

On Friday, August 31, 2018 at 10:28:51 AM UTC+2, Jan K= iszka wrote:
Re-reading the pat= ch with my new knowledge:

On 2018-08-26 08:21, Cedric Hombourger wrote:
> diff --git a/meta/recipes-kernel/linux-module/module.inc b/me= ta/recipes-kernel/linux-module/module.inc
> index 3075f44..3a3cab1 100644
> --- a/meta/recipes-kernel/linux-module/module.inc
> +++ b/meta/recipes-kernel/linux-module/module.inc
> @@ -17,7 +17,7 @@ AUTOLOAD ?=3D "0"
> =C2=A0=20
> =C2=A0 inherit dpkg
> =C2=A0=20
> -dpkg_runbuild_prepend() {
> +do_prepare_prepend() {

Shouldn't that be dpgk_prepare_append()?

> =C2=A0 =C2=A0 =C2=A0 cp -r ${WORKDIR}/debian ${S}/
> =C2=A0 =C2=A0 =C2=A0 sed -i -e 's/@PN@/${PN}/g' -e 's/= @PV@/${PV}/g' \
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0-e 's/@KERNEL_= NAME@/${KERNEL_NAME}/g' \
>=20

Jan

--=20
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
------=_Part_558_1511672078.1535704414744-- ------=_Part_557_1201565163.1535704414743--