From: Alexander Smirnov <asmirnov@ilbers.de>
To: Henning Schild <henning.schild@siemens.com>, isar-users@googlegroups.com
Cc: Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [PATCH v3] Correctly use the bitbake variable S from now on
Date: Fri, 11 May 2018 18:33:12 +0300 [thread overview]
Message-ID: <369d2966-61d1-fc2a-d9de-fb04ba6f4753@ilbers.de> (raw)
In-Reply-To: <20180420123626.25330-1-henning.schild@siemens.com>
On 04/20/2018 03:36 PM, Henning Schild wrote:
> S is defined as ${WORKDIR}/${P} so it already contains ${WORKDIR} by its
> definition. In Isar it was often concatinated with WORKDIR again. One
> example where this was a problem is if you specified a patch in SRC_URI
> but did not actually overwrite S.
> Align the use of the variable with OE and bitbake defaults again.
>
> Impact: layers building on top of Isar will have to adjust their recipes
> like the internal ones needed modification. The suggestion is to not set
> S and make sure to unpack to ${WORKDIR}/${P}. When setting S make sure
> to include ${WORKDIR}. This patch also introduces a warning and tries to
> preserve the old behaviour a bit. However if your recipe uses patches in
> SRC_URI and sets S you will get the warning and do_patch will fail.
>
Applied to next, thanks!
Alex
prev parent reply other threads:[~2018-05-11 15:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-19 9:26 [PATCH] " Henning Schild
2018-04-19 9:45 ` Jan Kiszka
2018-04-19 10:36 ` Henning Schild
2018-04-19 11:42 ` Jan Kiszka
2018-04-19 16:56 ` Henning Schild
2018-04-19 16:58 ` [PATCH v2] " Henning Schild
2018-04-20 11:06 ` Henning Schild
2018-04-20 12:36 ` [PATCH v3] " Henning Schild
2018-04-20 12:37 ` Henning Schild
2018-04-20 12:39 ` Jan Kiszka
2018-04-20 12:43 ` Henning Schild
2018-05-11 15:33 ` Alexander Smirnov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=369d2966-61d1-fc2a-d9de-fb04ba6f4753@ilbers.de \
--to=asmirnov@ilbers.de \
--cc=henning.schild@siemens.com \
--cc=isar-users@googlegroups.com \
--cc=jan.kiszka@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox