From mboxrd@z Thu Jan  1 00:00:00 1970
X-GM-THRID: 6546088382730076160
X-Received: by 2002:a1c:5bd1:: with SMTP id p200-v6mr275692wmb.17.1526052802149;
        Fri, 11 May 2018 08:33:22 -0700 (PDT)
X-BeenThere: isar-users@googlegroups.com
Received: by 2002:a1c:e642:: with SMTP id d63-v6ls466893wmh.0.gmail; Fri, 11
 May 2018 08:33:21 -0700 (PDT)
X-Google-Smtp-Source: AB8JxZomvAgsjGkN7BkqH1nSgZnFj0scr9cDwQfAdZqK/chQPipZYQT9Ndq/0lqMV8Qm0KHJeYTa
X-Received: by 2002:a1c:eb07:: with SMTP id j7-v6mr308791wmh.19.1526052801689;
        Fri, 11 May 2018 08:33:21 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1526052801; cv=none;
        d=google.com; s=arc-20160816;
        b=casYeoyNlyvU5n2YNNaB+LmcMQpc5lh0yzSV61/ogM2/h1RHDf+SL/Qhh6JzpsIM4x
         tvi/eHQYiTbBI4pRKbntaBkoKoD/1bYEwwKmYhBvGEER2X2pME2mO/v2xSQ+AiuOggXX
         512x+cF7sc93HftjEeuMCoZPpzQo6OWylqe5LlHIrXG3XHLvNXdqn+sG/srDlYG7CuK7
         xfDPiRFd9XFSvWTLstgavK2WMBFeBQByHIkIPJMDdgW6BhlU9uRjvPIEcv4FQ/Bt6h6q
         K5SryXAqUkIGZqp/U1SRhOi2xryBPHjuPI16V6B/3ns4bFAOutQorzHyvcwkGr9TfHBb
         plIA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=content-transfer-encoding:content-language:in-reply-to:mime-version
         :user-agent:date:message-id:from:references:cc:to:subject
         :arc-authentication-results;
        bh=Nor7oN79x+OR28PMnbT/RIbOmX4e/X5vNcrZpRAKi4c=;
        b=v/IO4HkQIRGcY12XcUARLlbbELAtHZL5qmN1NLFB9r4IKRk5il9lyIDi/KU9tfztqp
         z4vbz5p2fqKWjxWBjMP4FYhgyHI0XmcmvTcbRu3eeNQVhyJgiMZDwyRMZduuXoMaSmZ8
         SloeiliunubPKn2yLugs/xtmpOsd0Q9CpSnwDz1FRly54j1fz1xi/rX3Edp0bZFFEX5q
         loFdmL3qqxe/n+E9iFtgD0dY0lkr8cx3lWaU4fXLPTgDyDs5IY52SNXQb3tHEr384ywM
         mIfTVtDLLfix5emoKgKHJgCxecqtX7BfdEpNMwEroRSN/i0DETeY/xdr8bgXNRRGRRq5
         glqg==
ARC-Authentication-Results: i=1; gmr-mx.google.com;
       spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de
Return-Path: <asmirnov@ilbers.de>
Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211])
        by gmr-mx.google.com with ESMTPS id m80-v6si105872wmb.1.2018.05.11.08.33.21
        for <isar-users@googlegroups.com>
        (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
        Fri, 11 May 2018 08:33:21 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211;
Authentication-Results: gmr-mx.google.com;
       spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de
Received: from [10.0.2.15] ([188.227.110.165])
	(authenticated bits=0)
	by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id w4BFXIcL002200
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);
	Fri, 11 May 2018 17:33:20 +0200
Subject: Re: [PATCH v3] Correctly use the bitbake variable S from now on
To: Henning Schild <henning.schild@siemens.com>, isar-users@googlegroups.com
Cc: Jan Kiszka <jan.kiszka@siemens.com>
References: <20180419165832.10741-1-henning.schild@siemens.com>
 <20180420123626.25330-1-henning.schild@siemens.com>
From: Alexander Smirnov <asmirnov@ilbers.de>
Message-ID: <369d2966-61d1-fc2a-d9de-fb04ba6f4753@ilbers.de>
Date: Fri, 11 May 2018 18:33:12 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20180420123626.25330-1-henning.schild@siemens.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-TUID: R4468XWMB/pi

On 04/20/2018 03:36 PM, Henning Schild wrote:
> S is defined as ${WORKDIR}/${P} so it already contains ${WORKDIR} by its
> definition. In Isar it was often concatinated with WORKDIR again. One
> example where this was a problem is if you specified a patch in SRC_URI
> but did not actually overwrite S.
> Align the use of the variable with OE and bitbake defaults again.
> 
> Impact: layers building on top of Isar will have to adjust their recipes
> like the internal ones needed modification. The suggestion is to not set
> S and make sure to unpack to ${WORKDIR}/${P}. When setting S make sure
> to include ${WORKDIR}. This patch also introduces a warning and tries to
> preserve the old behaviour a bit. However if your recipe uses patches in
> SRC_URI and sets S you will get the warning and do_patch will fail.
> 

Applied to next, thanks!

Alex