public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Anton Mikanovich <amikan@ilbers.de>
To: "Moessbauer, Felix" <felix.moessbauer@siemens.com>,
	"isar-users@googlegroups.com" <isar-users@googlegroups.com>
Cc: "henning.schild@siemens.com" <henning.schild@siemens.com>,
	"jan.kiszka@siemens.com" <jan.kiszka@siemens.com>
Subject: Re: [PATCH] mount: Cleanup reference counters before build
Date: Fri, 25 Jun 2021 14:25:09 +0300	[thread overview]
Message-ID: <36ad6945-e841-c8fb-3779-44768667e7a4@ilbers.de> (raw)
In-Reply-To: <AM9PR10MB4869DD8B22589D2793C74F1289069@AM9PR10MB4869.EURPRD10.PROD.OUTLOOK.COM>

[-- Attachment #1: Type: text/plain, Size: 2742 bytes --]

Thanks for informing, I hope Jan's issues will be also fixed.

Isar documentation needs some rebuilding. I will prepare appropriate 
patchset.

25.06.2021 11:19, Moessbauer, Felix wrote:
> Hi Anton,
>
> this patch solved the build issues at least for my use-case.
> While it required me to add the buildchroot_do_mounts / buildchroot_undo_mounts to custom tasks, I guess that is the new intended behavior.
>
> There should be a BIG warning somewhere in the documentation that this might require changes to (ill-formed) recipes.
>
> Best regards,
> Felix
>
>> -----Original Message-----
>> From: isar-users@googlegroups.com <isar-users@googlegroups.com> On
>> Behalf Of Anton Mikanovich
>> Sent: Wednesday, June 23, 2021 1:58 PM
>> To: isar-users@googlegroups.com
>> Cc: Anton Mikanovich <amikan@ilbers.de>
>> Subject: [PATCH] mount: Cleanup reference counters before build
>>
>> Reference counters are not cleared in case unsuccessful build happens.
>> So we need to force cleanup before the build.
>>
>> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
>> ---
>>   meta/classes/isar-events.bbclass | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/meta/classes/isar-events.bbclass b/meta/classes/isar-events.bbclass
>> index 73419b4..2f8bf6e 100644
>> --- a/meta/classes/isar-events.bbclass
>> +++ b/meta/classes/isar-events.bbclass
>> @@ -8,6 +8,8 @@ addhandler build_started
>>
>>   python build_started() {
>>       bb.utils.remove(d.getVar('TMPDIR') + "/work/*/*/*/temp/once.*")
>> +    bb.utils.remove(d.getVar('TMPDIR') + "/work/*/*/*/rootfs.mount")
>> +    bb.utils.remove(d.getVar('TMPDIR') + "/deploy/buildchroot-*/*.mount")
>>   }
>>   build_started[eventmask] = "bb.event.BuildStarted"
>>
>> --
>> 2.20.1
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "isar-users" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email
>> to isar-users+unsubscribe@googlegroups.com.
>> To view this discussion on the web visit
>> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.g
>> oogle.com%2Fd%2Fmsgid%2Fisar-users%2F20210623115823.136514-1-
>> amikan%2540ilbers.de&amp;data=04%7C01%7Cfelix.moessbauer%40siemens.c
>> om%7Ccb2b9bb12a8c440d39f308d9363e3b61%7C38ae3bcd95794fd4addab42e
>> 1495d55a%7C1%7C0%7C637600463175992733%7CUnknown%7CTWFpbGZsb3d
>> 8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D
>> %7C1000&amp;sdata=XJvU0n32Mh0DrWQXD%2B18VEenK5t2e8lKDLLkyy1tamg
>> %3D&amp;reserved=0.

-- 
Anton Mikanovich
Promwad Ltd.
External service provider of ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn, Germany
+49 (89) 122 67 24-0
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov


[-- Attachment #2: Type: text/html, Size: 4028 bytes --]

  reply	other threads:[~2021-06-25 11:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-23 11:58 Anton Mikanovich
2021-06-25  8:19 ` Moessbauer, Felix
2021-06-25 11:25   ` Anton Mikanovich [this message]
2021-06-29 13:49     ` Jan Kiszka
2021-07-05 14:30       ` Anton Mikanovich
2021-07-26 14:34 ` Anton Mikanovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=36ad6945-e841-c8fb-3779-44768667e7a4@ilbers.de \
    --to=amikan@ilbers.de \
    --cc=felix.moessbauer@siemens.com \
    --cc=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox