From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6976957543224442880 X-Received: by 2002:a19:8588:: with SMTP id h130mr7640902lfd.501.1624620317524; Fri, 25 Jun 2021 04:25:17 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:865a:: with SMTP id i26ls52166ljj.1.gmail; Fri, 25 Jun 2021 04:25:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyLJEj3PboNv66F3FZ4zBkCjwsNhN2M7UidNKqqscnl623ci7c23yaT3f0RuR2ZjNTacn8l X-Received: by 2002:a05:651c:102a:: with SMTP id w10mr7697740ljm.486.1624620316540; Fri, 25 Jun 2021 04:25:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624620316; cv=none; d=google.com; s=arc-20160816; b=pucLF9Ux3VXSkipTyou8jwPN7qPW4Z3drTFsun/rsI0DLVcYUOejD2JTdhb2pEyLAr aNLhg8x6Pt0EIjPSYBQOoiY9j2nBzNAMbArv44saawxQClucmjECBOH9UB0/DhpAFcJp VqdXR1P7Q/Ej08vaZWzwMx0rMsFVyElNWZ6ZX6lciS6hxAIIuKnrLbvi2QDd6q5Sa0+h OOewWitmOv2+i5pxoXVIhr51pdPCJKOCzRAsQFWjhZpY1k1hpYZP30jvvMt3E/pwM/FU WbnUmbfxxJ8vfYvVu2/ZJyaG+nilOPmEAuzuIraGFRHrf4T4DSlsu7rILoEz0iMpdAhe 4k4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=WvRa9p02jO8CCov7ub412aQubUjn59TuL5CsDGaXMo8=; b=dtd+tZrxt6k+hBTWJb4QatZi+pcs2dM829SM1aviJN/2zhdxBTwvFFV4oZz2+FZqHv egkDvzWtA3EKwsk/h3IIFnEoq1Zxi6bnK92rRKVKkCdqWahxY1emHmEedEv/g7DTvOL1 B0Pvso4MMOHJ5m9qQZKgzu+lvg3Hr7J1e2VOHZciMCBWlXrzORWNFsyxNB26c2Ck2Hit 7qoEfvI4LjGVsBgLsmLIif7yWvfRlalE1AhQz9TcEGmj/t9rkCM0Q9eQvRTf3nBwQdJN gdgI3TEwctavfwUNioFEzyT1Zfg6UqNftGgZCfkZLBVKDXfx8P62/2AYUFl83dCW0goj D8lg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id z4si217161lfs.0.2021.06.25.04.25.16 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 25 Jun 2021 04:25:16 -0700 (PDT) Received-SPF: pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Received: from [192.168.67.164] (mm-26-60-214-37.mgts.dynamic.pppoe.byfly.by [37.214.60.26] (may be forged)) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id 15PBPEqd016526 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 25 Jun 2021 13:25:15 +0200 Subject: Re: [PATCH] mount: Cleanup reference counters before build To: "Moessbauer, Felix" , "isar-users@googlegroups.com" Cc: "henning.schild@siemens.com" , "jan.kiszka@siemens.com" References: <20210623115823.136514-1-amikan@ilbers.de> From: Anton Mikanovich Message-ID: <36ad6945-e841-c8fb-3779-44768667e7a4@ilbers.de> Date: Fri, 25 Jun 2021 14:25:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/alternative; boundary="------------E0E17E9E9F0E5721F2564CC1" Content-Language: en-US X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: 4hrOJMFxogT3 This is a multi-part message in MIME format. --------------E0E17E9E9F0E5721F2564CC1 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Thanks for informing, I hope Jan's issues will be also fixed. Isar documentation needs some rebuilding. I will prepare appropriate patchset. 25.06.2021 11:19, Moessbauer, Felix wrote: > Hi Anton, > > this patch solved the build issues at least for my use-case. > While it required me to add the buildchroot_do_mounts / buildchroot_undo_mounts to custom tasks, I guess that is the new intended behavior. > > There should be a BIG warning somewhere in the documentation that this might require changes to (ill-formed) recipes. > > Best regards, > Felix > >> -----Original Message----- >> From: isar-users@googlegroups.com On >> Behalf Of Anton Mikanovich >> Sent: Wednesday, June 23, 2021 1:58 PM >> To: isar-users@googlegroups.com >> Cc: Anton Mikanovich >> Subject: [PATCH] mount: Cleanup reference counters before build >> >> Reference counters are not cleared in case unsuccessful build happens. >> So we need to force cleanup before the build. >> >> Signed-off-by: Anton Mikanovich >> --- >> meta/classes/isar-events.bbclass | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/meta/classes/isar-events.bbclass b/meta/classes/isar-events.bbclass >> index 73419b4..2f8bf6e 100644 >> --- a/meta/classes/isar-events.bbclass >> +++ b/meta/classes/isar-events.bbclass >> @@ -8,6 +8,8 @@ addhandler build_started >> >> python build_started() { >> bb.utils.remove(d.getVar('TMPDIR') + "/work/*/*/*/temp/once.*") >> + bb.utils.remove(d.getVar('TMPDIR') + "/work/*/*/*/rootfs.mount") >> + bb.utils.remove(d.getVar('TMPDIR') + "/deploy/buildchroot-*/*.mount") >> } >> build_started[eventmask] = "bb.event.BuildStarted" >> >> -- >> 2.20.1 >> >> -- >> You received this message because you are subscribed to the Google Groups >> "isar-users" group. >> To unsubscribe from this group and stop receiving emails from it, send an email >> to isar-users+unsubscribe@googlegroups.com. >> To view this discussion on the web visit >> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.g >> oogle.com%2Fd%2Fmsgid%2Fisar-users%2F20210623115823.136514-1- >> amikan%2540ilbers.de&data=04%7C01%7Cfelix.moessbauer%40siemens.c >> om%7Ccb2b9bb12a8c440d39f308d9363e3b61%7C38ae3bcd95794fd4addab42e >> 1495d55a%7C1%7C0%7C637600463175992733%7CUnknown%7CTWFpbGZsb3d >> 8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D >> %7C1000&sdata=XJvU0n32Mh0DrWQXD%2B18VEenK5t2e8lKDLLkyy1tamg >> %3D&reserved=0. -- Anton Mikanovich Promwad Ltd. External service provider of ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn, Germany +49 (89) 122 67 24-0 Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov --------------E0E17E9E9F0E5721F2564CC1 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit

Thanks for informing, I hope Jan's issues will be also fixed.

Isar documentation needs some rebuilding. I will prepare appropriate patchset.

25.06.2021 11:19, Moessbauer, Felix wrote:
Hi Anton,

this patch solved the build issues at least for my use-case.
While it required me to add the buildchroot_do_mounts / buildchroot_undo_mounts to custom tasks, I guess that is the new intended behavior.

There should be a BIG warning somewhere in the documentation that this might require changes to (ill-formed) recipes.

Best regards,
Felix

-----Original Message-----
From: isar-users@googlegroups.com <isar-users@googlegroups.com> On
Behalf Of Anton Mikanovich
Sent: Wednesday, June 23, 2021 1:58 PM
To: isar-users@googlegroups.com
Cc: Anton Mikanovich <amikan@ilbers.de>
Subject: [PATCH] mount: Cleanup reference counters before build

Reference counters are not cleared in case unsuccessful build happens.
So we need to force cleanup before the build.

Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
---
 meta/classes/isar-events.bbclass | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/classes/isar-events.bbclass b/meta/classes/isar-events.bbclass
index 73419b4..2f8bf6e 100644
--- a/meta/classes/isar-events.bbclass
+++ b/meta/classes/isar-events.bbclass
@@ -8,6 +8,8 @@ addhandler build_started

 python build_started() {
     bb.utils.remove(d.getVar('TMPDIR') + "/work/*/*/*/temp/once.*")
+    bb.utils.remove(d.getVar('TMPDIR') + "/work/*/*/*/rootfs.mount")
+    bb.utils.remove(d.getVar('TMPDIR') + "/deploy/buildchroot-*/*.mount")
 }
 build_started[eventmask] = "bb.event.BuildStarted"

--
2.20.1

--
You received this message because you are subscribed to the Google Groups
"isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to isar-users+unsubscribe@googlegroups.com.
To view this discussion on the web visit
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.g
oogle.com%2Fd%2Fmsgid%2Fisar-users%2F20210623115823.136514-1-
amikan%2540ilbers.de&amp;data=04%7C01%7Cfelix.moessbauer%40siemens.c
om%7Ccb2b9bb12a8c440d39f308d9363e3b61%7C38ae3bcd95794fd4addab42e
1495d55a%7C1%7C0%7C637600463175992733%7CUnknown%7CTWFpbGZsb3d
8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D
%7C1000&amp;sdata=XJvU0n32Mh0DrWQXD%2B18VEenK5t2e8lKDLLkyy1tamg
%3D&amp;reserved=0.

    
-- 
Anton Mikanovich
Promwad Ltd.
External service provider of ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn, Germany
+49 (89) 122 67 24-0
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov
--------------E0E17E9E9F0E5721F2564CC1--