From mboxrd@z Thu Jan  1 00:00:00 1970
X-GM-THRID: 6995471841453146112
Date: Fri, 13 Aug 2021 01:31:47 -0700 (PDT)
From: Uladzimir Bely <ubely@ilbers.de>
To: isar-users <isar-users@googlegroups.com>
Message-Id: <3710f21b-429e-40c2-8a8f-814bf1b734c2n@googlegroups.com>
In-Reply-To: <cover.1628768932.git.jan.kiszka@siemens.com>
References: <cover.1628768932.git.jan.kiszka@siemens.com>
Subject: Re: [PATCH v2 0/4] Make adjust_git work in both worlds
MIME-Version: 1.0
Content-Type: multipart/mixed; 
	boundary="----=_Part_488_1465233003.1628843507152"
X-TUID: NKQ5RQmTp/h4

------=_Part_488_1465233003.1628843507152
Content-Type: multipart/alternative; 
	boundary="----=_Part_489_1000957102.1628843507152"

------=_Part_489_1000957102.1628843507152
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

I've checked your series in CI (fast run) and it was OK.

Actually, the problem with cowsay rebuild appeared on some manual work with 
ISAR, when some changes in configuration were done and rebuild was started 
on top of previous build. So, the problem was reproducable only in such 
manual conditions.

I'm going to add some test to CI that will reproduce these conditions so 
that we would be sure the fix is complete.

On Thursday, August 12, 2021 at 2:48:54 PM UTC+3 Jan Kiszka wrote:

> Finally allow the adjusted git repos work both inside and outside the 
> buildchroots. Also fixes the race introduced by patching links in 
> DL_DIR. 
>
> Changes in v2: 
> - build relative alternates path so that destsuffix paths are respected 
> - fix task dependencies so that devshell gets adjusted git again 
>
> NOTE: Still not yet fully tested, fast CI takes 3:30h (plus retries). 
>
> Jan 
>
> Jan Kiszka (4): 
> dpkg-base: Lock do_adjust_git against each other 
> dpkg-base: Make mirror link relative 
> Rework do_adjust_git to support inside and outside usage 
> Revert "dpkg: adjust task order to allow using "git" for patching" 
>
> meta/classes/dpkg-base.bbclass | 22 ++++++++++++++----- 
> meta/conf/bitbake.conf | 1 + 
> .../buildchroot/buildchroot.inc | 2 ++ 
> 3 files changed, 20 insertions(+), 5 deletions(-) 
>
> -- 
> 2.31.1 
>
>
------=_Part_489_1000957102.1628843507152
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: 7bit

<div>I've checked your series in CI (fast run) and it was OK.</div><div><br></div><div>Actually, the problem with cowsay rebuild appeared on some manual work with ISAR, when some changes in configuration were done and rebuild was started on top of previous build. So, the problem was reproducable only in such manual conditions.</div><div><br></div><div>I'm going to add some test to CI that will reproduce these conditions so that we would be sure the fix is complete.<br></div><br><div class="gmail_quote"><div dir="auto" class="gmail_attr">On Thursday, August 12, 2021 at 2:48:54 PM UTC+3 Jan Kiszka wrote:<br></div><blockquote class="gmail_quote" style="margin: 0 0 0 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">Finally allow the adjusted git repos work both inside and outside the
<br>buildchroots. Also fixes the race introduced by patching links in
<br>DL_DIR.
<br>
<br>Changes in v2:
<br> - build relative alternates path so that destsuffix paths are respected
<br> - fix task dependencies so that devshell gets adjusted git again
<br>
<br>NOTE: Still not yet fully tested, fast CI takes 3:30h (plus retries).
<br>
<br>Jan
<br>
<br>Jan Kiszka (4):
<br>  dpkg-base: Lock do_adjust_git against each other
<br>  dpkg-base: Make mirror link relative
<br>  Rework do_adjust_git to support inside and outside usage
<br>  Revert "dpkg: adjust task order to allow using "git" for patching"
<br>
<br> meta/classes/dpkg-base.bbclass                | 22 ++++++++++++++-----
<br> meta/conf/bitbake.conf                        |  1 +
<br> .../buildchroot/buildchroot.inc               |  2 ++
<br> 3 files changed, 20 insertions(+), 5 deletions(-)
<br>
<br>-- 
<br>2.31.1
<br>
<br></blockquote></div>
------=_Part_489_1000957102.1628843507152--

------=_Part_488_1465233003.1628843507152--