public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'Quirin Gylstorff' via isar-users" <isar-users@googlegroups.com>
To: isar-users@googlegroups.com
Subject: Re: [PATCH v2 4/4] image-postproc-extension: extract systemd's version using rootfs_cmd
Date: Fri, 20 Jun 2025 11:16:44 +0200	[thread overview]
Message-ID: <376af427-8a16-41ed-b361-8bdbe96a0c29@siemens.com> (raw)
In-Reply-To: <20250618135040.8252-5-cedric.hombourger@siemens.com>



On 6/18/25 15:50, 'Cedric Hombourger' via isar-users wrote:
> Elevated privileges are not required to query the rootfs for the version
> of systemd: replace "sudo chroot" with "rootfs_cmd"
> 
> Signed-off-by: Cedric Hombourger <cedric.hombourger@siemens.com>
> ---
>   meta/classes/image-postproc-extension.bbclass | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/image-postproc-extension.bbclass b/meta/classes/image-postproc-extension.bbclass
> index 0af588d8..21dcfccc 100644
> --- a/meta/classes/image-postproc-extension.bbclass
> +++ b/meta/classes/image-postproc-extension.bbclass
> @@ -55,7 +55,7 @@ image_postprocess_mark() {
>   
>   # Use dpkg to find out which version of systemd is installed into the image or reports "0"
>   image_systemd_version() {
> -    sudo chroot ${IMAGE_ROOTFS} dpkg-query --showformat='${source:Upstream-Version}' --show systemd || echo "0"
> +    rootfs_cmd ${IMAGE_ROOTFS} -- dpkg-query --showformat='${source:Upstream-Version}' --show systemd || echo "0"
>   }
Why are we not using the root parameter of dpkg-query for this?

Quirin
>   
>   ROOTFS_POSTPROCESS_COMMAND =+ "image_postprocess_machine_id"

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/376af427-8a16-41ed-b361-8bdbe96a0c29%40siemens.com.

  reply	other threads:[~2025-06-20  9:16 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-15 15:07 [RFC PATCH 0/2] optimize caching of source packages 'Cedric Hombourger' via isar-users
2025-05-15 15:07 ` [RFC PATCH 1/2] rootfs: introduce wrapper to run native commands against a rootfs 'Cedric Hombourger' via isar-users
2025-05-19 11:57   ` [PATCH 0/4] non-privileged commands in chroot 'Cedric Hombourger' via isar-users
2025-05-19 11:57     ` [PATCH 1/4] rootfs: introduce wrapper to run commands against a rootfs 'Cedric Hombourger' via isar-users
2025-05-22 14:32       ` 'MOESSBAUER, Felix' via isar-users
2025-06-05  6:42         ` 'cedric.hombourger@siemens.com' via isar-users
2025-06-05 12:20           ` 'MOESSBAUER, Felix' via isar-users
2025-06-05 12:43             ` Baurzhan Ismagulov
2025-06-06  6:05               ` 'cedric.hombourger@siemens.com' via isar-users
2025-06-05 13:57       ` 'Jan Kiszka' via isar-users
2025-06-06  6:02         ` 'cedric.hombourger@siemens.com' via isar-users
2025-06-06  6:11           ` 'Jan Kiszka' via isar-users
2025-05-19 11:57     ` [PATCH 2/4] deb-dl-dir: optimize caching of source packages using apt natively 'Cedric Hombourger' via isar-users
2025-05-19 11:57     ` [PATCH 3/4] image-postproc-extension: refactor systemd version checks 'Cedric Hombourger' via isar-users
2025-05-19 11:57     ` [PATCH 4/4] image-postproc-extension: extract systemd's version using rootfs_cmd 'Cedric Hombourger' via isar-users
2025-05-19 13:33     ` [PATCH 0/4] non-privileged commands in chroot Srinuvasan Arjunan
2025-06-18 13:50     ` [PATCH v2 " 'Cedric Hombourger' via isar-users
2025-06-18 13:50       ` [PATCH v2 1/4] rootfs: introduce wrapper to run commands against a rootfs 'Cedric Hombourger' via isar-users
2025-06-18 13:50       ` [PATCH v2 2/4] deb-dl-dir: optimize caching of source packages using apt natively 'Cedric Hombourger' via isar-users
2025-06-18 13:50       ` [PATCH v2 3/4] image-postproc-extension: refactor systemd version checks 'Cedric Hombourger' via isar-users
2025-06-18 13:50       ` [PATCH v2 4/4] image-postproc-extension: extract systemd's version using rootfs_cmd 'Cedric Hombourger' via isar-users
2025-06-20  9:16         ` 'Quirin Gylstorff' via isar-users [this message]
2025-05-15 15:07 ` [RFC PATCH 2/2] deb-dl-dir: optimize caching of source packages using apt natively 'Cedric Hombourger' via isar-users

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=376af427-8a16-41ed-b361-8bdbe96a0c29@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=quirin.gylstorff@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox