[PATCH v1] linux-module: remove double quotes around AUTOLOAD

[PATCH v1] linux-module: remove double quotes around AUTOLOAD

[Daniel Machon]

If the AUTOLOAD variable has more than 1 entry the for-loop in
do_prepare_build() doesn't expand and therefor result in a
one-line entry into the postinst file. This in turn gives the
wrong format for the /etc/modules (all module names are on the
same line) and therefor fails to load at startup.

Signed-off-by: Daniel Machon <dama@universal-robots.com>
Signed-off-by: Torsten Bonde Christensen <tbch@universal-robots.com>
---
 meta/recipes-kernel/linux-module/module.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-kernel/linux-module/module.inc b/meta/recipes-kernel/linux-module/module.inc
index 968ac4c..fa13e41 100644
--- a/meta/recipes-kernel/linux-module/module.inc
+++ b/meta/recipes-kernel/linux-module/module.inc
@@ -30,7 +30,7 @@ TEMPLATE_VARS += "KERNEL_IMAGE_PKG KERNEL_HEADERS_PKG"
 do_prepare_build() {
     cp -r ${WORKDIR}/debian ${S}/
 
-    for module in "${AUTOLOAD}"; do
+    for module in ${AUTOLOAD}; do
         echo "echo $module >> /etc/modules" >> ${S}/debian/postinst
     done
 }
-- 
2.25.1

Re: [PATCH v1] linux-module: remove double quotes around AUTOLOAD

[Henning Schild]

Good catch!

Well written modules will know when to load and how to depend on each
other. MODULE_ALIAS MODULES_SOFTDEP and some more, but yes if your
modules do not do that and one package has multiple your patch is valid.

Thanks!
Henning

Am Thu,  3 Mar 2022 12:47:24 +0100
schrieb Daniel Machon <dmachon.dev@gmail.com>:

> If the AUTOLOAD variable has more than 1 entry the for-loop in
> do_prepare_build() doesn't expand and therefor result in a
> one-line entry into the postinst file. This in turn gives the
> wrong format for the /etc/modules (all module names are on the
> same line) and therefor fails to load at startup.
> 
> Signed-off-by: Daniel Machon <dama@universal-robots.com>
> Signed-off-by: Torsten Bonde Christensen <tbch@universal-robots.com>
> ---
>  meta/recipes-kernel/linux-module/module.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-kernel/linux-module/module.inc
> b/meta/recipes-kernel/linux-module/module.inc index 968ac4c..fa13e41
> 100644 --- a/meta/recipes-kernel/linux-module/module.inc
> +++ b/meta/recipes-kernel/linux-module/module.inc
> @@ -30,7 +30,7 @@ TEMPLATE_VARS += "KERNEL_IMAGE_PKG
> KERNEL_HEADERS_PKG" do_prepare_build() {
>      cp -r ${WORKDIR}/debian ${S}/
>  
> -    for module in "${AUTOLOAD}"; do
> +    for module in ${AUTOLOAD}; do
>          echo "echo $module >> /etc/modules" >> ${S}/debian/postinst
>      done
>  }

Re: [PATCH v1] linux-module: remove double quotes around AUTOLOAD

[Anton Mikanovich]

03.03.2022 14:47, Daniel Machon wrote:
> If the AUTOLOAD variable has more than 1 entry the for-loop in
> do_prepare_build() doesn't expand and therefor result in a
> one-line entry into the postinst file. This in turn gives the
> wrong format for the /etc/modules (all module names are on the
> same line) and therefor fails to load at startup.
>
> Signed-off-by: Daniel Machon <dama@universal-robots.com>
> Signed-off-by: Torsten Bonde Christensen <tbch@universal-robots.com>

Applied to next, thanks.