From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Fri, 16 Jan 2026 17:15:05 +0100 X-Sieve: CMU Sieve 2.4 Received: from mail-lj1-f184.google.com (mail-lj1-f184.google.com [209.85.208.184]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 60GGF4JO011552 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 16 Jan 2026 17:15:05 +0100 Received: by mail-lj1-f184.google.com with SMTP id 38308e7fff4ca-382fbcb5033sf17836091fa.1 for ; Fri, 16 Jan 2026 08:15:05 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1768580099; cv=pass; d=google.com; s=arc-20240605; b=DY6dNwT9HLYezyHMDbosrCS7+6/l6f11P71+6xy/ySvyL1vBVYNs375imoN8bTJENz WpiXCKJjd54c7v7xBJILco1qyoMK9dwwtnibdDgjMJ/VR8J8hqOiDs1Y1jH1jskEcTZi Gw80rDUWJGQ7Hq2R35eHo01Ka1wgrxyVPQZLtQYooedU038bK1nG1QAXTvqm3fBhjtD1 gy9Ab+CayLIzr+vSUImICeXHv8MHmNx47mAoAzO2M4SV8mGV3CS7jIYqgPxqYIGDjMGE g7aBVez1qhiBY9oRYElMo5Lg/dRc4kTGGEpd++gW9NJZKG6KMjFGdoWQ7fcxwc9OgGo7 uWtA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :sender:dkim-signature; bh=1hkA8OiRWczBZYl9VVjstFM7iLba45KwobM3XjHPmXY=; fh=K/Zhh+/zYOfsjIRFA6cc8+zJem7hM4swyhiL3hsHXHg=; b=duB14kyBQtPfRISXPG+4C+GvLDMdpDKxxRODXTqF1eVcx2AFJTRaKh/5FRbU9Fn1F1 Zh1VvCjWtWHcRQHYk7U9Ufmgkmf5Y6UKDLItcCMLw8mlxwoMPTNP6k/e1M7KzOSGEZsF GHFCiYIoRdpuzPQ84Y3Sr87lJkCx4RvHgtC91stIQ0C9OnEVIB0h+3A6nokxsEfX9KDF C6rfkMr7+CKp3pozkjH5rIJrC1OkJl4j5xsBQVUcJcUmHVd/o/Kw9OzynV5aFBPEMh87 Hd6IReYssBPgl1cU31kUPpsL+pXaGKI78sanwuf09N3w371GPK4JhW4gU7GBuf1jtOd4 P5ag==; darn=ilbers.de ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=wzh@ilbers.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1768580099; x=1769184899; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:in-reply-to:from:content-language:references:to :subject:user-agent:mime-version:date:message-id:sender:from:to:cc :subject:date:message-id:reply-to; bh=1hkA8OiRWczBZYl9VVjstFM7iLba45KwobM3XjHPmXY=; b=MSVOpqiiVKlNIqHnMk8GQrpf642N5Um3gDWl6Vn/b7++DCMHedvRFQ9JjiRchBwt2g cnkXNWUMx3+ggf+pmMdGILHu0W3R4So8h5HjsnL0ossGZWBvlrHco0KdLnOVNEanQQXM SZiKX86u0mUsupNzsY3CoSYlaxy5Hm1uz+h06+yCbXT9r6uBPWQaO/0+rqiYD1bwqQ0p zk5yf92XRdGxZAFpdPRHMqPbgF+/fXnMiQtV4EwoLnuwVXo22GdNNgtXXIG+MoOFnanh x4IwX4ymQTsruyt2ONNTU6TwaRFw8omUdce+9OBZ11auKv5LCPtCnadMxM9b/uhUmC46 p7nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768580099; x=1769184899; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:in-reply-to :from:content-language:references:to:subject:user-agent:mime-version :date:message-id:x-beenthere:x-gm-message-state:sender:from:to:cc :subject:date:message-id:reply-to; bh=1hkA8OiRWczBZYl9VVjstFM7iLba45KwobM3XjHPmXY=; b=dujtZvTPBC2O2s7Df2Kb6yoOtsoCkn5Uymg7OMDZx71+1XBu9MjxwKt8iJPa+EO3LX Vvxqz4jRUeRH2Iq9veA+lUzguIuFItL4XESh+CABTrbQX2d1wbL0+JZgwYos9zBtT9j5 9EQbpwhbkK3YXKNLmBHybQwYN3WR3hZ1iJQwRU9rqBiNRjVovaKkZ8Ox6JBmuV6NcWSs ewYbJzEMDKcKm0LwlYm23Kot876dWLN+HYdTpkFmj36RCE5B/4aQDeNY+GQDzmSktad0 /FElmpfpHdp8J8xmgHqR/ei4I3NLtITDNB2v4yavrtatDLKykitTsi35xFyG+cSE3E/E M2rQ== Sender: isar-users@googlegroups.com X-Forwarded-Encrypted: i=2; AJvYcCUfxYZvQEDThDSdW/Dl96Fadaj7PWWKqWynez80Gwf5KkGk5lNLTGGDjT1Jhd518MYiuxfG@ilbers.de X-Gm-Message-State: AOJu0YwFrI2JtAij33loX88qy5Y125EjEVXQeARAc0AXUhxrMbYqdwUy v2kJRgyvDmO8p251njA/1BtPvdK/j+BWTZyG9ClCVwHZWcTErGYczPOO X-Received: by 2002:a05:651c:b29:b0:382:5f1b:99c5 with SMTP id 38308e7fff4ca-38386a35041mr11210071fa.28.1768580098865; Fri, 16 Jan 2026 08:14:58 -0800 (PST) X-BeenThere: isar-users@googlegroups.com; h="AV1CL+HAGXOkljaskxMZgMJhmJs5Nc5e1yHoDhKCkar5MiWSQQ==" Received: by 2002:a05:6512:318f:b0:59b:7c74:ce9 with SMTP id 2adb3069b0e04-59ba6b4b408ls750526e87.1.-pod-prod-06-eu; Fri, 16 Jan 2026 08:14:56 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCUW62SolIQ5C2P3OyYI22dhjV8awMUh2TeTWNi1c1vruVe7i5J8+1N0bvCQ2In2j33nzEl0yo33M3tu@googlegroups.com X-Received: by 2002:a05:6512:3f1e:b0:59b:6f38:9071 with SMTP id 2adb3069b0e04-59bafdb6ca8mr1113219e87.17.1768580096005; Fri, 16 Jan 2026 08:14:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1768580095; cv=none; d=google.com; s=arc-20240605; b=Z0xJcvMZEKamgUYQBefkp4Vis9Kz9tTiGQSoTSW/T8rwruv7VZ6mn00m+w2+UD9Vbc pmwrybCVrM52ajLeCDN0MFPQuFcb/4IZny7rgJlEx2qvogRTDyLyrRBhpeLYjVlUgPMY FiK9KRohCtoM+vzrnqu1p6WWweK2RQsuW1lCRGCsaDW+DoXbVgPsT/nzIr5xpZAB1rkl VNE69w8FjBKeCZuWLAwqYBMRpbmG3FO8KJSbLwS2eTD5pQv2+r0i4xRVLpgbPCFuRBS9 UszhHjUL3Ym2VOkag+DN0uHW5PaqIoLXjLLS9b2UG4q+aCl4YNjceNcivnxA3npozoh2 f9Lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id; bh=gjAHnP7RKQx+v9cpc18zIlBJ8HjF3Dg1dWWpMxuaYRw=; fh=u13w2Z9nliFTQvR0S4mEri2n2f2KAn/PtoBVIp6Vuw8=; b=Nvgv3AIxaq/lpS8fA2KzUXvVbC9FOhj3BWINa7hgXfJWrUIkZz9p8WdRnvcMqMR4q2 qyhUNRP6uhc+2riAV7aeuYb2c8Ddm/zjNUi13lNz3vVhCoeMTH5k+1rfi4lJf1aMzf5d TSkWIPW0myGXeLr2Kl6AhS++7hjQwNgVKf06bukX/J5ETvdRStYMFjqEbajtk14USVtM IRCsmxbKUlQO6NS+XcDxu4bL6O96CVkFoVhA8pjQlDs76b0rnpVnXzw7Y4QRDeLNZDFo 3Zn8a1CsRugMSM3tg2W+UQlS691/KW8PA7llKX0J1uXNQnhiFIBLPFAjsi1riEL3PJcT Orhw==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=wzh@ilbers.de Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id 2adb3069b0e04-59baf341ef5si65129e87.1.2026.01.16.08.14.55 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 16 Jan 2026 08:14:55 -0800 (PST) Received-SPF: pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Received: from [192.168.178.117] ([88.130.203.42]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 60GGEswi011541 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 16 Jan 2026 17:14:54 +0100 Message-ID: <395d5f33-14be-4865-8469-8b9c10aa65b5@ilbers.de> Date: Fri, 16 Jan 2026 17:14:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Bitbake: use LAYERDIR_RE when setting BBFILE_PATTERN_x To: "Schwarz, Konrad" , "isar-users@googlegroups.com" References: <20260112160613.40413-1-konrad.schwarz@siemens.com> Content-Language: en-US From: Zhihang Wei In-Reply-To: <20260112160613.40413-1-konrad.schwarz@siemens.com> Content-Type: text/plain; charset="UTF-8"; format=flowed X-Spam-Status: No, score=-4.6 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2, RCVD_IN_RP_CERTIFIED,RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-Original-Sender: wzh@ilbers.de X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=wzh@ilbers.de Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-TUID: r+Dr6RRtaHr5 Applied to next, thanks. Zhihang On 1/12/26 17:06, 'Schwarz, Konrad' via isar-users wrote: > From: Konrad Schwarz > > The `BBFILE_PATTERN_x` variables are regular expressions. > Hence, regular expression special characters such as `.` > need to be protected if intended to be used literally. > > Bitbake facilitates this by automatically poviding a variant of the > `LAYERDIR` variable, `LAYERDIR_RE`, in which all regex special characters > are escaped (and are thus interpreted as ordinary characters). > `LAYERDIR_RE` should be used instead of `LAYERDIR` in the value > of `BBFILE_PATTERN_x`. > > The Bitbake User Manual consistenly uses `LAYERDIR_RE` when assigning > to `BBFILE_PATTERN_x`. see Chapters 7 [1], "Variables Glossary", > and 9.4 [2], "The Hello World Example". > > [1]: https://docs.yoctoproject.org/bitbake/bitbake-user-manual/bitbake-user-manual-ref-variables.html# > [2]: https://docs.yoctoproject.org/bitbake/bitbake-user-manual/bitbake-user-manual-hello.html#the-hello-world-example > > Note that this is a systematic mistake. Although > this patch addressse Isar, projects based on Isar > are likely to contain this mistake in their own layer configurations. > > `BBFILE_PATTERN_x`/`LAYERDIR_RE` are the only > such pair in Bitbake documented in the user's manual; > the problem should not extend to other variable uses. > > Signed-off-by: Konrad Schwarz > --- > bitbake/lib/layerindexlib/tests/testdata/layer1/conf/layer.conf | 2 +- > bitbake/lib/layerindexlib/tests/testdata/layer2/conf/layer.conf | 2 +- > bitbake/lib/layerindexlib/tests/testdata/layer3/conf/layer.conf | 2 +- > bitbake/lib/layerindexlib/tests/testdata/layer4/conf/layer.conf | 2 +- > meta-isar/conf/layer.conf | 2 +- > meta-test/conf/layer.conf | 2 +- > meta/conf/layer.conf | 2 +- > testsuite/cibuilder.py | 2 +- > 8 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/bitbake/lib/layerindexlib/tests/testdata/layer1/conf/layer.conf b/bitbake/lib/layerindexlib/tests/testdata/layer1/conf/layer.conf > index 966d5319..c7a372d7 100644 > --- a/bitbake/lib/layerindexlib/tests/testdata/layer1/conf/layer.conf > +++ b/bitbake/lib/layerindexlib/tests/testdata/layer1/conf/layer.conf > @@ -4,7 +4,7 @@ BBPATH .= ":${LAYERDIR}" > BBFILES += "${LAYERDIR}/recipes-*/*/*.bb" > > BBFILE_COLLECTIONS += "core" > -BBFILE_PATTERN_core = "^${LAYERDIR}/" > +BBFILE_PATTERN_core = "^${LAYERDIR_RE}/" > BBFILE_PRIORITY_core = "5" > > LAYERSERIES_CORENAMES = "sumo" > diff --git a/bitbake/lib/layerindexlib/tests/testdata/layer2/conf/layer.conf b/bitbake/lib/layerindexlib/tests/testdata/layer2/conf/layer.conf > index 7569d1c2..dc9d36a6 100644 > --- a/bitbake/lib/layerindexlib/tests/testdata/layer2/conf/layer.conf > +++ b/bitbake/lib/layerindexlib/tests/testdata/layer2/conf/layer.conf > @@ -6,7 +6,7 @@ BBFILES += "${LAYERDIR}/recipes-*/*/*.bb \ > ${LAYERDIR}/recipes-*/*/*.bbappend" > > BBFILE_COLLECTIONS += "networking-layer" > -BBFILE_PATTERN_networking-layer := "^${LAYERDIR}/" > +BBFILE_PATTERN_networking-layer := "^${LAYERDIR_RE}/" > BBFILE_PRIORITY_networking-layer = "5" > > # This should only be incremented on significant changes that will > diff --git a/bitbake/lib/layerindexlib/tests/testdata/layer3/conf/layer.conf b/bitbake/lib/layerindexlib/tests/testdata/layer3/conf/layer.conf > index 7089071f..54ddee90 100644 > --- a/bitbake/lib/layerindexlib/tests/testdata/layer3/conf/layer.conf > +++ b/bitbake/lib/layerindexlib/tests/testdata/layer3/conf/layer.conf > @@ -5,7 +5,7 @@ BBPATH .= ":${LAYERDIR}" > BBFILES += "${LAYERDIR}/recipes*/*/*.bb ${LAYERDIR}/recipes*/*/*.bbappend" > > BBFILE_COLLECTIONS += "meta-python" > -BBFILE_PATTERN_meta-python := "^${LAYERDIR}/" > +BBFILE_PATTERN_meta-python := "^${LAYERDIR_RE}/" > BBFILE_PRIORITY_meta-python = "7" > > # This should only be incremented on significant changes that will > diff --git a/bitbake/lib/layerindexlib/tests/testdata/layer4/conf/layer.conf b/bitbake/lib/layerindexlib/tests/testdata/layer4/conf/layer.conf > index 6649ee02..4646c234 100644 > --- a/bitbake/lib/layerindexlib/tests/testdata/layer4/conf/layer.conf > +++ b/bitbake/lib/layerindexlib/tests/testdata/layer4/conf/layer.conf > @@ -5,7 +5,7 @@ BBPATH .= ":${LAYERDIR}" > BBFILES += "${LAYERDIR}/recipes-*/*/*.bb ${LAYERDIR}/recipes-*/*/*.bbappend" > > BBFILE_COLLECTIONS += "openembedded-layer" > -BBFILE_PATTERN_openembedded-layer := "^${LAYERDIR}/" > +BBFILE_PATTERN_openembedded-layer := "^${LAYERDIR_RE}/" > > # Define the priority for recipes (.bb files) from this layer, > # choosing carefully how this layer interacts with all of the > diff --git a/meta-isar/conf/layer.conf b/meta-isar/conf/layer.conf > index 2209b18b..577f47b5 100644 > --- a/meta-isar/conf/layer.conf > +++ b/meta-isar/conf/layer.conf > @@ -8,7 +8,7 @@ BBPATH .= ":${LAYERDIR}" > BBFILES += "${LAYERDIR}/recipes-*/*/*.bb ${LAYERDIR}/recipes-*/*/*.bbappend" > > BBFILE_COLLECTIONS += "isar" > -BBFILE_PATTERN_isar = "^${LAYERDIR}/" > +BBFILE_PATTERN_isar = "^${LAYERDIR_RE}/" > BBFILE_PRIORITY_isar = "5" > > # This should only be incremented on significant changes that will > diff --git a/meta-test/conf/layer.conf b/meta-test/conf/layer.conf > index 0f15119d..425e9251 100644 > --- a/meta-test/conf/layer.conf > +++ b/meta-test/conf/layer.conf > @@ -8,7 +8,7 @@ BBPATH .= ":${LAYERDIR}" > BBFILES += "${LAYERDIR}/recipes-*/*/*.bb ${LAYERDIR}/recipes-*/*/*.bbappend" > > BBFILE_COLLECTIONS += "test" > -BBFILE_PATTERN_test = "^${LAYERDIR}/" > +BBFILE_PATTERN_test = "^${LAYERDIR_RE}/" > BBFILE_PRIORITY_test = "10" > > # This should only be incremented on significant changes that will > diff --git a/meta/conf/layer.conf b/meta/conf/layer.conf > index 15f01233..69225172 100644 > --- a/meta/conf/layer.conf > +++ b/meta/conf/layer.conf > @@ -8,7 +8,7 @@ BBPATH .= ":${LAYERDIR}" > BBFILES += "${LAYERDIR}/recipes-*/*/*.bb ${LAYERDIR}/recipes-*/*/*.bbappend" > > BBFILE_COLLECTIONS += "core" > -BBFILE_PATTERN_core = "^${LAYERDIR}/" > +BBFILE_PATTERN_core = "^${LAYERDIR_RE}/" > BBFILE_PRIORITY_core = "5" > > LAYERSERIES_CORENAMES = "v0.6 next" > diff --git a/testsuite/cibuilder.py b/testsuite/cibuilder.py > index 366f6a1f..80f9362e 100755 > --- a/testsuite/cibuilder.py > +++ b/testsuite/cibuilder.py > @@ -362,7 +362,7 @@ class CIBuilder(Test): > 'BBPATH .= ":${LAYERDIR}"\n' > 'BBFILES += "${LAYERDIR}/recipes-*/*/*.bbappend"\n' > 'BBFILE_COLLECTIONS += "tmp"\n' > - 'BBFILE_PATTERN_tmp = "^${LAYERDIR}/"\n' > + 'BBFILE_PATTERN_tmp = "^${LAYERDIR_RE}/"\n' > 'BBFILE_PRIORITY_tmp = "5"\n' > 'LAYERVERSION_tmp = "1"\n' > 'LAYERSERIES_COMPAT_tmp = "v0.6"\n' -- You received this message because you are subscribed to the Google Groups "isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/395d5f33-14be-4865-8469-8b9c10aa65b5%40ilbers.de.