From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6669723628337102848 X-Received: by 2002:a05:600c:c7:: with SMTP id u7mr1095161wmm.25.1552922002204; Mon, 18 Mar 2019 08:13:22 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:63d6:: with SMTP id x205ls2088096wmb.11.gmail; Mon, 18 Mar 2019 08:13:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqyx5FGKAl9MD76OOjGR7jtynU1tmnKu82JAvRrBzeHDSWlEeHYRcpJGX6ZkMwm0XSx1sd2O X-Received: by 2002:a1c:f414:: with SMTP id z20mr1129934wma.18.1552922001685; Mon, 18 Mar 2019 08:13:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552922001; cv=none; d=google.com; s=arc-20160816; b=Vjy0BFybDpAM/H9gvY8SsUJMVnJY/WxbQFdGnwSukaGUxQnMmF5fGBASd0v3mOH36u W8sSyzoYvHcVulsFlN6Yt2dgK6aAZrK0dCBYQ/j0kI1ICWF9GnwsbvzkGPTBYSQSKjbX 8jjW9mek8x+CKyuMeKf7ODsG5TR13wHWl0tb7a7jC+U0xPV3PckoiVqtSSD1y364RCtc iiRLNEUY2LpsBGhHa48hOKDrWlysClSQu+Q2PNIMn2vawRaXoLcGQl5GNOhpYONOjsLM EGuPuVdXSuL6IMy3yjJAafKAs0kKQxD4g2Ua+ti2mcyu7ePYJ7e5UtO86+NBcYgwaJkh exmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:from:references:to:subject; bh=MW2IMpmxxyb5DpLL/CA5HRe99HZqTdp69WqzZWEX6pI=; b=EnQegk5hnCrDVEItDbieywShOvkXyAzECgvsx+z218+nPN+l9mIJTg85EC6kRMRdAV 5zoj3g2Ip6tvWXHZni6LB9SUFTZs68fzGaRJvlM8N/uzcSCwyGC3JchsWgqzaqUMPD7c YqWTLqjqXR3h9XMN85gpdXvqw3aggLzlZVwqHU8kVMhrTYVLhliM5mBUWcC5vL7c5wdU I/cpGta7G1vo4WR3PkE+yamkoQE2p/dNtOIxR37+nMzuIyC5vPgFJZ29S4g1U2a5smQO NM14RVlVa9Wu9c3o0ZvYWUy6c+XV5SosdKehNTZje8Yb5FQoxrEGgr6QuGmDjpNntvqG giUg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id n5si563262wrj.0.2019.03.18.08.13.21 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Mar 2019 08:13:21 -0700 (PDT) Received-SPF: pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Received: from [192.168.50.163] (d51a48a80.access.telenet.be [81.164.138.128]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id x2IFDJ7A011557 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 Mar 2019 16:13:20 +0100 Subject: Re: [PATCH v5 0/5] Fix usage of additional apt keys and repos To: "Andreas J. Reichel" , isar-users@googlegroups.com References: <20190318133205.29705-1-andreas.reichel.ext@siemens.com> From: "Maxim Yu. Osipov" Organization: ilbers GmbH Message-ID: <3969feb6-c01a-d140-a30f-3755319c192f@ilbers.de> Date: Mon, 18 Mar 2019 16:13:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190318133205.29705-1-andreas.reichel.ext@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: CO/hvG0hI0No Hi Andreas, I've applied your series and "fast" CI build (just call `./scripts/ci_build.sh -q -f' failed. See for details http://isar-build.org:8080/job/isar_mosipov_develop/61/console If you need an account on CI build server - just let me know. Regards, Maxim. On 3/18/19 2:31 PM, Andreas J. Reichel wrote: > From: Andreas Reichel > > Diff to v4: > * don't remove keyring deployed to target rootfs > so that one can do updates later > * keys are temporarily held in WORKDIR/aptkeys, not > TMPDIR/aptkeys > * variable renamed from APTKEYTMPDIR to APT_KEYS_DIR > > Unchanged with reason: > * function for retreiving override for https is unchanged, > since renaming this to one global function > "get_distro_overrides" is better done in a separate patch. > This patch should concentrate on getting things finally > working, before changing too much code that is more or less > a beautification. > * (Other comments on mailing list) > * HAVE_CUSTOM_APT_KEYS is used in patch 4, but introduced in > patch 5, which is okay here, because we check if it exists... > > What this series does: > * Enable/fix possibility of additional apt repos > * Enable/fix handling of additional apt keys > * Deduplicate some code > > Signed-off-by: Andreas Reichel > > Andreas Reichel (5): > Revert "isar-bootstrap: Allow to set local keys in DISTRO_APT_KEYS" > Remove duplicate code from apt-keyring generation > Fix fetched key location in apt-keyring generator > Use apt-key to generate apt-keyring > If we use a custom keyring debootstrap may fall to https > > .../conf/multiconfig/qemuamd64-buster.conf | 1 - > .../conf/multiconfig/qemuamd64-jessie.conf | 1 - > meta/classes/isar-bootstrap-helper.bbclass | 2 + > meta/conf/bitbake.conf | 1 + > .../isar-bootstrap/isar-bootstrap.inc | 62 +++++++++++++------ > 5 files changed, 47 insertions(+), 20 deletions(-) > -- Maxim Osipov ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn Germany +49 (151) 6517 6917 mosipov@ilbers.de http://ilbers.de/ Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov