From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6646963335912751104 X-Received: by 2002:a1c:aece:: with SMTP id x197mr373557wme.0.1547640708994; Wed, 16 Jan 2019 04:11:48 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:e919:: with SMTP id q25ls115428wmc.6.gmail; Wed, 16 Jan 2019 04:11:48 -0800 (PST) X-Google-Smtp-Source: ALg8bN6uEbRSDyA4n+DISyEP+/LQM3vobSLVb/Ywlg+xTzmu2gG2g3Jq4Jt4RLwhuT0nA6sc9XTG X-Received: by 2002:a1c:dc82:: with SMTP id t124mr743492wmg.0.1547640708445; Wed, 16 Jan 2019 04:11:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547640708; cv=none; d=google.com; s=arc-20160816; b=xVVtWi0ZRwZq54yV+6hyh8TSSRTIewYlDjjkKw0v6bNb2IKCUzilSRe80F9kv+05jw AO+yu/dahP8yEzdfHEgEd2BgsMAkd5vuPdDhImy1rObMoh6v57JoHEENXiINMs0ts41p fAimTS3tlsetPeBbndawXryBmy/lboHnjgmBMuWkeEOt0WyxWm1bIROOhBy8O7T5UVMC 8rV91pgMV/slCIyx7YLBuRcuTN1xyz4te+oJBg3z2p3XRTAp13K29uK6Up6oJ29/124Z IYjQ0L1Q/Xd1/N2bWaVYey/WlwHy6utH46LvRbDN75eB458XSe53CwiotDN3ZQ9o0D3o nxQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=cOOol2Tr0v2SrH8G/Gcx++EUOjuaBnhiKIuBTiLQ3xE=; b=tporItZq42Z7+SxYsKaxMdeM2ICIdxc1T7AIiGiDEXIqI5gO8cpy168KQXGh3KP9D/ RlMWGY4KcUuGYLEuNIaWn16ppb5pTWSUsbczyCOt1fYZCWYUTP0ZfcTFDhhaC9JLWIRY nRVQahVYi6z+NiXjAX+8WW/NEYuT+6VBkz8VOfWhIYryAi/ZZ66k/y7m2i1UHJxSbUbT kTJjU3Cl9tsKmtH6S36m2CsFALbFoyNIcOzgG+RZSi17Xqca7oKBO8QYwps06a+gaxN0 8L9w5+9zREtJRbQX5/r+wmOfvxUSTyBOlNKzLXESMtwRCDl4yqYJY8jw3Q4aQkoZKhDS 7gWA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id k39si2619648wre.2.2019.01.16.04.11.48 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Jan 2019 04:11:48 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id x0GCBmrb005389 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 16 Jan 2019 13:11:48 +0100 Received: from [139.23.230.199] ([139.23.230.199]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x0GCBlFi023351; Wed, 16 Jan 2019 13:11:47 +0100 Subject: Re: [PATCH v3 01/14] dpkg-raw: Respect file permissions defined by recipe if requested To: Henning Schild Cc: isar-users References: <97edc3d29b4aaa19dbbb067e13335beda3f74447.1547616747.git.jan.kiszka@siemens.com> <20190116104138.356cd52c@md1za8fc.ad001.siemens.net> From: Jan Kiszka Message-ID: <39793b3d-d5c5-4bc4-d16a-7aff13baaa5f@siemens.com> Date: Wed, 16 Jan 2019 13:11:47 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <20190116104138.356cd52c@md1za8fc.ad001.siemens.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: EQzk3w/JCezE On 16.01.19 10:41, Henning Schild wrote: > Am Wed, 16 Jan 2019 06:32:14 +0100 > schrieb Jan Kiszka : > >> From: Jan Kiszka >> >> dh_fixperms overwrites the permissions do_install may have defined. To >> avoid that, allow the recipe write to define an exception list via the >> PRESERVE_PERMS variable. >> >> Fixes: f301ccb2b5b1 ("meta/dpkg-raw: build raw packages like all >> others") CC: Henning Schild >> Signed-off-by: Jan Kiszka >> --- >> RECIPE-API-CHANGELOG.md | 7 +++++++ >> meta/classes/dpkg-raw.bbclass | 9 ++++++++- >> 2 files changed, 15 insertions(+), 1 deletion(-) >> >> diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md >> index 06a01e3..2bc1585 100644 >> --- a/RECIPE-API-CHANGELOG.md >> +++ b/RECIPE-API-CHANGELOG.md >> @@ -124,3 +124,10 @@ updated hence recipes using them shouldn't be >> impacted per se. >> These packages depend on a specific kernel. Its identification is >> now appended to the binary package names in the form >> "-${KERNEL_NAME}". + >> +### PRESERVE_PERMS needed with dpkg-raw for implicit file permission >> setting + >> +In order to use the same file permissions for an input file to a >> dpkg-raw +package on the build machine as well as on the target, its >> absolute target path +needs to be listed in the PRESERVE_PERMS >> variable (space-separated list of +files). Otherwise, default >> permissions are used. diff --git a/meta/classes/dpkg-raw.bbclass >> b/meta/classes/dpkg-raw.bbclass index 8d11433..42276e5 100644 >> --- a/meta/classes/dpkg-raw.bbclass >> +++ b/meta/classes/dpkg-raw.bbclass >> @@ -53,12 +53,19 @@ Description: ${DESCRIPTION} >> EOF >> } >> >> +FIXPERM_EXCLUSIONS = \ >> + "${@' '.join(['-X ' + x for x in \ >> + (d.getVar('PRESERVE_PERMS', False) or >> '').split()])}" + >> deb_create_rules() { >> cat << EOF > ${S}/debian/rules >> #!/usr/bin/make -f >> + >> +override_dh_fixperms: >> + dh_fixperms ${FIXPERM_EXCLUSIONS} >> + > > This should be done only if the variable is non-empty, to keep that > code generic. Also the variable name should maybe start with DH_ or > DEBIAN_. I can change the naming, but I disagree regarding your other concern: dh_fixperms is by definition the default case if there is no override. Therefore override_dh_fixperms: dh_fixperms would be pointless but always correct. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux