public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Uladzimir Bely <ubely@ilbers.de>
To: Anton Mikanovich <amikan@ilbers.de>, isar-users@googlegroups.com
Subject: Re: [PATCH 0/1] External fix for sporadic schroot race issue
Date: Tue, 24 Dec 2024 14:56:58 +0300	[thread overview]
Message-ID: <39e9170eeafbad5f43ab94ad2d2f98273ba32392.camel@ilbers.de> (raw)
In-Reply-To: <20241220082959.3123651-1-amikan@ilbers.de>

On Fri, 2024-12-20 at 10:29 +0200, Anton Mikanovich wrote:
> After some experimenting with locking inside and outside of schroot
> and
> sbuild tools I've finally found the way how to made almost the same
> locking in Isar only without much build speed influence.
> 
> The idea is to cover all separate schroot calls with the lock based
> on
> what type of the call it is:
> - Session begin and any commands in already present session will use
> the lock in shared mode, so multiple executions possible.
> - Session end which can remove config files and cause race scenario
> will use the lock in exclusive mode, so it will wait for the time no
> other schroot instances running.
> 
> Luckly we always use schroot with separate session create/end
> commands
> even inside sbuild.
> The only thing needed is to put a little script into the location
> inserted to PATH.
> 
> This patch is just a copy of RFC was sent previously with no changes.
> It was tested on our CI and now is ready to be merged.
> 
> Anton Mikanovich (1):
>   meta: Protect schroot config management
> 
>  meta/classes/dpkg.bbclass   |  3 +++
>  meta/classes/sbuild.bbclass |  6 ++++++
>  scripts/schroot             | 43
> +++++++++++++++++++++++++++++++++++++
>  3 files changed, 52 insertions(+)
>  create mode 100755 scripts/schroot
> 
> -- 
> 2.34.1
> 

Applied to next.

-- 
Best regards,
Uladzimir.



-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/39e9170eeafbad5f43ab94ad2d2f98273ba32392.camel%40ilbers.de.

      parent reply	other threads:[~2024-12-24 11:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-20  8:29 Anton Mikanovich
2024-12-20  8:29 ` [PATCH 1/1] meta: Protect schroot config management Anton Mikanovich
2024-12-24 11:56 ` Uladzimir Bely [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39e9170eeafbad5f43ab94ad2d2f98273ba32392.camel@ilbers.de \
    --to=ubely@ilbers.de \
    --cc=amikan@ilbers.de \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox