Re: [PATCH 3/6] meta/dpkg: rename to dpkg-debian and add comment

[Claudius Heine <claudius.heine.ext@siemens.com>]

Hi,

On 08/30/2017 09:03 PM, [ext] Henning Schild wrote:
> Issues:
> In order to have multiple classes that create debian packages we need to
> come up with different names for them.
> 
> Change:
> Give the class a name that is supposed to reflect that this class should
> be used if you have sources and a /debian directory for them. Also add a
> small comment to the header to make that more clear.
> Update the one user in the Isar repository as well.
> 
> Impact:
> This patch does not change the behaviour of Isar. It addresses the
> issue. However, all forks of Isar will have to update all recipes that
> inherited the class.
> 
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
>   meta-isar/recipes-app/hello/hello.bb               | 2 +-
>   meta/classes/{dpkg.bbclass => dpkg-debian.bbclass} | 4 ++++
>   2 files changed, 5 insertions(+), 1 deletion(-)
>   rename meta/classes/{dpkg.bbclass => dpkg-debian.bbclass} (84%)

I am not 100% behind the new 'dpkg-debian' name, because its redundant.
One might think: "Of course a dpkg is for debian, because dpkg stands
for debian package."
I know that you are referencing the /debian directory with the '-debian' 
prefix, but I think this is not intuitive.

Here are some other/better/worse suggestions:

   - dpkg-src-dir
     Its a directory that contains prepared debian package source files.
   - dpkg-src
     Simpler but then we should later expand this to support all source
     package formats from debian [1] in a custom unpack routine (if
     bitbake does not support all these different source package formats
     already)

[1] https://people.debian.org/~hertzog/dpkg-source.html#lbAH

Cheers,
Claudius

> 
> diff --git a/meta-isar/recipes-app/hello/hello.bb b/meta-isar/recipes-app/hello/hello.bb
> index 56424fb..30cf8a8 100644
> --- a/meta-isar/recipes-app/hello/hello.bb
> +++ b/meta-isar/recipes-app/hello/hello.bb
> @@ -15,4 +15,4 @@ SRCREV = "ad7065ecc4840cc436bfcdac427386dbba4ea719"
>   
>   SRC_DIR = "git"
>   
> -inherit dpkg
> +inherit dpkg-debian
> diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg-debian.bbclass
> similarity index 84%
> rename from meta/classes/dpkg.bbclass
> rename to meta/classes/dpkg-debian.bbclass
> index 0b8c7c4..7466254 100644
> --- a/meta/classes/dpkg.bbclass
> +++ b/meta/classes/dpkg-debian.bbclass
> @@ -1,5 +1,9 @@
>   # This software is a part of ISAR.
>   # Copyright (C) 2015-2016 ilbers GmbH
> +#
> +# This class allows you to build debian packages from sources.
> +# These sources need to be enabled for that, they need to have the
> +# debian/ folder.
>   
>   # Add dependency from buildchroot creation
>   DEPENDS += "buildchroot"
> 

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de